From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: abhimanyu.saini@xilinx.com, dev@dpdk.org
Cc: chenbo.xia@intel.com, andrew.rybchenko@oktetlabs.ru,
vsrivast@xilinx.com, Abhimanyu Saini <asaini@xilinx.com>
Subject: Re: [PATCH v2] vdpa/sfc: make MCDI memzone name unique
Date: Tue, 1 Feb 2022 09:21:09 +0100 [thread overview]
Message-ID: <68d64efb-a861-219a-ce02-d6a0199389c1@redhat.com> (raw)
In-Reply-To: <20220117112906.23823-1-asaini@xilinx.com>
Hi Abhimanyu,
On 1/17/22 12:29, abhimanyu.saini@xilinx.com wrote:
> From: Abhimanyu Saini <asaini@xilinx.com>
>
> Buffer for MCDI channel is allocated using rte_memzone_reserve_aligned
> with zone name 'mcdi'. Since multiple MCDI channels are needed to
> support multiple VF(s) and rte_memzone_reserve_aligned expects unique
> zone names, append PCI address to zone name to make it unique.
>
> Signed-off-by: Abhimanyu Saini <asaini@xilinx.com>
> ---
> v2:
> * Formatting changes
>
> drivers/vdpa/sfc/sfc_vdpa_hw.c | 15 ++++++++++++---
> 1 file changed, 12 insertions(+), 3 deletions(-)
>
The patch itself looks goof to me, but it seems you have issues with its
formatting (I guess you need to configure indents properly in your
editor):
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#153: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:28:
+ char mz_name[RTE_MEMZONE_NAMESIZE];$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#159: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:34:
+ ret = snprintf(mz_name, RTE_MEMZONE_NAMESIZE, "%s_%s",$
ERROR:CODE_INDENT: code indent should use tabs where possible
#160: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:35:
+ sva->pdev->name, name);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#160: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:35:
+ sva->pdev->name, name);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#161: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:36:
+ if (ret < 0 || ret >= RTE_MEMZONE_NAMESIZE) {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional
statements (7, 15)
#161: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:36:
+ if (ret < 0 || ret >= RTE_MEMZONE_NAMESIZE) {
+ sfc_vdpa_err(sva, "%s_%s too long to fit in mz_name",
ERROR:CODE_INDENT: code indent should use tabs where possible
#162: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:37:
+ sfc_vdpa_err(sva, "%s_%s too long to fit in mz_name",$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#162: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:37:
+ sfc_vdpa_err(sva, "%s_%s too long to fit in mz_name",$
ERROR:CODE_INDENT: code indent should use tabs where possible
#163: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:38:
+ sva->pdev->name, name);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#163: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:38:
+ sva->pdev->name, name);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#164: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:39:
+ return -EINVAL;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#164: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:39:
+ return -EINVAL;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#165: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:40:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#168: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:42:
+ sfc_vdpa_log_init(sva, "name=%s, len=%zu", mz_name, len);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#171: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:44:
+ mz = rte_memzone_reserve_aligned(mz_name, mcdi_buff_size,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#178: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:50:
+ mz_name, (unsigned int)len,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#178: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:50:
+ mz_name, (unsigned int)len,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#179: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:51:
+ rte_strerror(rte_errno));$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#179: FILE: drivers/vdpa/sfc/sfc_vdpa_hw.c:51:
+ rte_strerror(rte_errno));$
total: 6 errors, 13 warnings, 33 lines checked
next prev parent reply other threads:[~2022-02-01 8:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-11 5:33 [PATCH] " abhimanyu.saini
2022-01-14 7:06 ` Xia, Chenbo
2022-01-17 11:29 ` [PATCH v2] " abhimanyu.saini
2022-02-01 8:21 ` Maxime Coquelin [this message]
2022-02-14 10:51 ` [PATCH v3] " abhimanyu.saini
2022-02-15 10:56 ` Maxime Coquelin
2022-02-15 10:59 ` Maxime Coquelin
2022-02-15 12:21 ` Maxime Coquelin
2022-02-17 8:54 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68d64efb-a861-219a-ce02-d6a0199389c1@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=abhimanyu.saini@xilinx.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=asaini@xilinx.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=vsrivast@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).