From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Jiayu Hu <jiayu.hu@intel.com>, dev@dpdk.org
Cc: chenbo.xia@intel.com, xingguang.he@intel.com
Subject: Re: [PATCH v3] vhost: fix packed ring descriptor update in async enqueue
Date: Tue, 16 Nov 2021 11:25:37 +0100 [thread overview]
Message-ID: <69580123-a73c-cfe4-c02f-bd205ec2bee4@redhat.com> (raw)
In-Reply-To: <20211116151756.2420165-1-jiayu.hu@intel.com>
On 11/16/21 16:17, Jiayu Hu wrote:
> If the packet uses multiple descriptors and its descriptor indices are
> wrapped, the first descriptor flag is not updated last, which may cause
> virtio read the incomplete packet. For example, given a packet uses 64
> descriptors, and virtio ring size is 256, and its descriptor indices are
> 224~255 and 0~31, current implementation will update 224~255 descriptor
> flags earlier than 0~31 descriptor flags.
>
> This patch fixes this issue by updating descriptor flags in one loop,
> so that the first descriptor flag is always updated last.
>
> Fixes: 873e8dad6f49 ("vhost: support packed ring in async datapath")
>
> Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
> Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
> ---
> v3:
> * fix typo
> v2:
> * update commit log
> ---
> lib/vhost/virtio_net.c | 122 ++++++++++++++++++-----------------------
> 1 file changed, 54 insertions(+), 68 deletions(-)
>
Applied to dpdk-next-virtio/main.
Thanks,
Maxime
prev parent reply other threads:[~2021-11-16 10:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-04 10:19 [dpdk-dev] [PATCH] " Jiayu Hu
2021-11-08 8:42 ` Maxime Coquelin
2021-11-10 12:40 ` [dpdk-dev] [PATCH v2] " Jiayu Hu
2021-11-16 6:27 ` Xia, Chenbo
2021-11-16 15:17 ` [PATCH v3] " Jiayu Hu
2021-11-16 9:59 ` Maxime Coquelin
2021-11-16 10:25 ` Maxime Coquelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69580123-a73c-cfe4-c02f-bd205ec2bee4@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=jiayu.hu@intel.com \
--cc=xingguang.he@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).