From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: dev@dpdk.org, Yuanhan Liu <yliu@fridaylinux.org>,
Tetsuya Mukawa <mtetsuyah@gmail.com>
Subject: Re: [dpdk-dev] [PATCH v2 0/2] vhost: introduce rte_vhost_vring_call()
Date: Wed, 3 Jan 2018 09:17:32 +0100 [thread overview]
Message-ID: <698ad293-18d8-30c6-eae7-df5e1bd2b64c@redhat.com> (raw)
In-Reply-To: <20180102181141.GC22252@stefanha-x1.localdomain>
On 01/02/2018 07:11 PM, Stefan Hajnoczi wrote:
> On Tue, Jan 02, 2018 at 11:27:02AM +0100, Maxime Coquelin wrote:
>> Hi Stefan,
>>
>> On 01/02/2018 10:31 AM, Stefan Hajnoczi wrote:
>>> v2:
>>> * Add internal vhost_vring_call() helper function [Maxime]
>>>
>>> These patches eliminate code duplication for vhost_virtqueue->callfd users by
>>> introducing rte_vhost_vring_call() (public API) and vhost_vring_call()
>>> (librte_vhost-internal API).
>>>
>>> Stefan Hajnoczi (2):
>>> vhost: add vhost_vring_call() helper
>>> vhost: introduce rte_vhost_vring_call()
>>>
>>> lib/librte_vhost/rte_vhost.h | 15 +++++++++++++++
>>> lib/librte_vhost/vhost.h | 12 ++++++++++++
>>> examples/vhost/virtio_net.c | 11 ++---------
>>> examples/vhost_scsi/vhost_scsi.c | 6 +++---
>>> lib/librte_vhost/vhost.c | 21 +++++++++++++++++++++
>>> lib/librte_vhost/virtio_net.c | 23 +++--------------------
>>> lib/librte_vhost/rte_vhost_version.map | 7 +++++++
>>> 7 files changed, 63 insertions(+), 32 deletions(-)
>>>
>>
>> I just wonder whether tagging the new API as experimental is needed,
>> but apart from that it looks good to me:
>>
>> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>
> From 3.2. Managing ABI updates, General Guidelines:
>
> New APIs will be marked as experimental for at least one release to
> allow any issues found by users of the new API to be fixed quickly.
>
> http://dpdk.org/doc/guides/contributing/versioning.html
>
> I'm new to DPDK so I followed this guideline strictly and expect the
> maintainers to mark the API stable at some point in the future when they
> are happy with it. Maybe this guideline isn't followed strictly for
> librte_vhost?
Thanks for the pointer, it seems it is not strictly followed for
librte_vhost & other libs. Let's keep it experimental for the coming
release.
Maxime
> Stefan
>
next prev parent reply other threads:[~2018-01-03 8:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-02 9:31 Stefan Hajnoczi
2018-01-02 9:31 ` [dpdk-dev] [PATCH v2 1/2] vhost: add vhost_vring_call() helper Stefan Hajnoczi
2018-01-02 9:31 ` [dpdk-dev] [PATCH v2 2/2] vhost: introduce rte_vhost_vring_call() Stefan Hajnoczi
2018-01-02 10:27 ` [dpdk-dev] [PATCH v2 0/2] " Maxime Coquelin
[not found] ` <20180102181141.GC22252@stefanha-x1.localdomain>
2018-01-03 8:17 ` Maxime Coquelin [this message]
2018-01-08 13:46 ` Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=698ad293-18d8-30c6-eae7-df5e1bd2b64c@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=mtetsuyah@gmail.com \
--cc=stefanha@redhat.com \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).