From: "Medvedkin, Vladimir" <vladimir.medvedkin@intel.com>
To: Ruifeng Wang <ruifeng.wang@arm.com>,
bruce.richardson@intel.com, olivier.matz@6wind.com
Cc: dev@dpdk.org, stephen@networkplumber.org,
konstantin.ananyev@intel.com, gavin.hu@arm.com,
honnappa.nagarahalli@arm.com, dharmik.thakkar@arm.com,
nd@arm.com, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH v2 5/6] test/lpm: reset total time
Date: Wed, 18 Sep 2019 17:17:34 +0100 [thread overview]
Message-ID: <69f7bd6d-cc41-a79a-c4e1-c8db784c9952@intel.com> (raw)
In-Reply-To: <20190906094534.36060-6-ruifeng.wang@arm.com>
Hi Ruifeng,
Thanks for this bug fix.
I think it should be sent separately from this RCU related patch series.
On 06/09/2019 10:45, Ruifeng Wang wrote:
> From: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
>
> total_time needs to be reset to measure the cycles for delete API.
>
> Fixes: af75078fece3 ("first public release")
> Cc: stable@dpdk.org
>
> Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> ---
> app/test/test_lpm_perf.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/app/test/test_lpm_perf.c b/app/test/test_lpm_perf.c
> index 77eea66ad..a2578fe90 100644
> --- a/app/test/test_lpm_perf.c
> +++ b/app/test/test_lpm_perf.c
> @@ -460,7 +460,7 @@ test_lpm_perf(void)
> (double)total_time / ((double)ITERATIONS * BATCH_SIZE),
> (count * 100.0) / (double)(ITERATIONS * BATCH_SIZE));
>
> - /* Delete */
> + /* Measure Delete */
> status = 0;
> begin = rte_rdtsc();
>
> @@ -470,7 +470,7 @@ test_lpm_perf(void)
> large_route_table[i].depth);
> }
>
> - total_time += rte_rdtsc() - begin;
> + total_time = rte_rdtsc() - begin;
>
> printf("Average LPM Delete: %g cycles\n",
> (double)total_time / NUM_ROUTE_ENTRIES);
--
Regards,
Vladimir
next prev parent reply other threads:[~2019-09-18 16:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190822063457.41596-1-ruifeng.wang@arm.com>
[not found] ` <20190906094534.36060-1-ruifeng.wang@arm.com>
2019-09-06 9:45 ` Ruifeng Wang
2019-09-18 16:17 ` Medvedkin, Vladimir [this message]
2019-09-19 6:22 ` Ruifeng Wang (Arm Technology China)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69f7bd6d-cc41-a79a-c4e1-c8db784c9952@intel.com \
--to=vladimir.medvedkin@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dharmik.thakkar@arm.com \
--cc=gavin.hu@arm.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=konstantin.ananyev@intel.com \
--cc=nd@arm.com \
--cc=olivier.matz@6wind.com \
--cc=ruifeng.wang@arm.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).