From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] igb: set default thresholds correctly based on mac type
Date: Mon, 1 Feb 2016 02:59:13 +0000 [thread overview]
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09090342613B@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1453426717-2522-1-git-send-email-stephen@networkplumber.org>
> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Friday, January 22, 2016 9:39 AM
> To: Lu, Wenzhuo
> Cc: dev@dpdk.org; Stephen Hemminger
> Subject: [PATCH] igb: set default thresholds correctly based on mac type
>
> This brings the DPDK igb driver inline with the behavior used by the current Linux
> driver. The IGB hardware has several different MAC types and the threshold
> values that work vary based on the hardware.
>
> Since DPDK 1.8 it has been up to devices to provide the correct default
> configuration parameter. But the igb driver gives values that are broken on
> some devices, and always causes a warning message at startup.
>
> Please test this on real hardware, I don't have the luxury of a hardware lab full
> of variations of this chip.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
next prev parent reply other threads:[~2016-02-01 2:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-22 1:38 Stephen Hemminger
2016-02-01 2:59 ` Lu, Wenzhuo [this message]
2016-02-16 10:34 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6A0DE07E22DDAD4C9103DF62FEBC09090342613B@shsmsx102.ccr.corp.intel.com \
--to=wenzhuo.lu@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).