From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 00/12] update ixgbe base driver
Date: Sun, 14 Feb 2016 02:33:02 +0000 [thread overview]
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09090342A3FE@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20160211223548.GA19068@bricha3-MOBL3>
Hi Bruce,
> -----Original Message-----
> From: Richardson, Bruce
> Sent: Friday, February 12, 2016 6:36 AM
> To: Lu, Wenzhuo
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 00/12] update ixgbe base driver
>
> On Tue, Jan 19, 2016 at 10:48:01AM +0800, Wenzhuo Lu wrote:
> > *add new devices and mac type
> > *use PHY token for X550EM_a
> > *set VF mac address only when acked by PF *always turn PHY power on
> > when requested *add definition of a register for mac SGMII busy
> > *support fuse for both x550em_x V1 and V2 *remove duplicate setting
> > for fdir no match drop *consolidate MDIO speed-setting *use link
> > instead of I2C combined abstraction
> >
> >
> > Wenzhuo Lu (12):
> > ixgbe/base: update readme
> > ixgbe/base: add new devices and mac type
> > ixgeb/base: use PHY token for X550EM_a
> > ixgbe/base: set VF mac address only when acked by PF
> > ixgbe/base: always turn PHY power on when requested
> > ixgbe/base: add definition of a register for mac SGMII busy
> > ixgbe/base: support fuse for both x550em_x V1 and V2
> > ixgbe/base: remove duplicate setting for fdir no match drop
> > ixgbe/base: consolidate MDIO speed-setting
> > ixgbe/base: use link instead of I2C combined abstraction
> > ixgbe: support new devices and mac types
> > doc: update release note for ixgbe base code update
> >
> Hi Wenzhuo
>
> Thanks for this patchset. Just some feedback on it.
>
> * Can you please take the new features etc. called out in the doc patch and just
> add the RN update as part of the patch adding the feature itself. Those additions
> that were part of a previous base code update (presumably part of a previous
> release) shouldn't go in the latest release notes. There shouldn't need to be a
> separate doc patch in this set.
> * The order of the patches could do with being changed. I'd suggest having the
> readme updated as the last of the base code update series, right before the
> ixgbe patch.
> * The "new devices and mac types" patch, only seems to add one new device
> type, so I'd call it out explicitly in the title.
> * The X550em_x V1/V2 patch is similarly adding new device support so should go
> alongside the other new device patch. I'd suggest titling both patches similarly
> e.g.
> ixgbe/base: add x550em_a device support
> ixgbe/base: add x550em_x V2 device support
>
> * Some of the titles are a bit long or are not a great summary of the primary
> purpose of the patch. For example: "always turn PHY power on when requested"
> might be better titled: "ignore manageability for phy power on".
>
> Can you maybe send out a V2 with the above changes taken into account -
> especially the release note split?
Sure, I'll send a V2. Thanks for the comments.
>
> Thanks,
> /Bruce
next prev parent reply other threads:[~2016-02-14 2:33 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-19 2:48 Wenzhuo Lu
2016-01-19 2:48 ` [dpdk-dev] [PATCH 01/12] ixgbe/base: update readme Wenzhuo Lu
2016-01-19 2:48 ` [dpdk-dev] [PATCH 02/12] ixgbe/base: add new devices and mac type Wenzhuo Lu
2016-01-19 2:48 ` [dpdk-dev] [PATCH 03/12] ixgeb/base: use PHY token for X550EM_a Wenzhuo Lu
2016-01-19 2:48 ` [dpdk-dev] [PATCH 04/12] ixgbe/base: set VF mac address only when acked by PF Wenzhuo Lu
2016-01-19 2:48 ` [dpdk-dev] [PATCH 05/12] ixgbe/base: always turn PHY power on when requested Wenzhuo Lu
2016-01-19 2:48 ` [dpdk-dev] [PATCH 06/12] ixgbe/base: add definition of a register for mac SGMII busy Wenzhuo Lu
2016-01-19 2:48 ` [dpdk-dev] [PATCH 07/12] ixgbe/base: support fuse for both x550em_x V1 and V2 Wenzhuo Lu
2016-01-19 2:48 ` [dpdk-dev] [PATCH 08/12] ixgbe/base: remove duplicate setting for fdir no match drop Wenzhuo Lu
2016-01-19 2:48 ` [dpdk-dev] [PATCH 09/12] ixgbe/base: consolidate MDIO speed-setting Wenzhuo Lu
2016-01-19 2:48 ` [dpdk-dev] [PATCH 10/12] ixgbe/base: use link instead of I2C combined abstraction Wenzhuo Lu
2016-01-19 2:48 ` [dpdk-dev] [PATCH 11/12] ixgbe: support new devices and mac types Wenzhuo Lu
2016-01-19 2:48 ` [dpdk-dev] [PATCH 12/12] doc: update release note for ixgbe base code update Wenzhuo Lu
2016-02-11 22:35 ` [dpdk-dev] [PATCH 00/12] update ixgbe base driver Bruce Richardson
2016-02-14 2:33 ` Lu, Wenzhuo [this message]
2016-02-14 8:54 ` [dpdk-dev] [PATCH v2 00/11] " Wenzhuo Lu
2016-02-14 8:54 ` [dpdk-dev] [PATCH v2 01/11] ixgbe/base: add x550em_a device support Wenzhuo Lu
2016-02-14 8:54 ` [dpdk-dev] [PATCH v2 02/11] ixgbe/base: add x550em_x V2 " Wenzhuo Lu
2016-02-14 8:54 ` [dpdk-dev] [PATCH v2 03/11] ixgbe/base: sw-firmware sync for resource sharing Wenzhuo Lu
2016-02-14 8:54 ` [dpdk-dev] [PATCH v2 04/11] ixgbe/base: set VF mac addr only when acked by PF Wenzhuo Lu
2016-02-14 8:55 ` [dpdk-dev] [PATCH v2 05/11] ixgbe/base: ignore manageability for phy power on Wenzhuo Lu
2016-02-14 8:55 ` [dpdk-dev] [PATCH v2 06/11] ixgbe/base: add register definition for SGMII busy Wenzhuo Lu
2016-02-14 8:55 ` [dpdk-dev] [PATCH v2 07/11] ixgbe/base: fix setting flow dir flag twice Wenzhuo Lu
2016-02-14 8:55 ` [dpdk-dev] [PATCH v2 08/11] ixgbe/base: set MDIO speed after MAC reset Wenzhuo Lu
2016-02-14 8:55 ` [dpdk-dev] [PATCH v2 09/11] ixgbe/base: abstract out link read/write ops Wenzhuo Lu
2016-02-14 8:55 ` [dpdk-dev] [PATCH v2 10/11] ixgbe/base: update readme Wenzhuo Lu
2016-02-14 8:55 ` [dpdk-dev] [PATCH v2 11/11] ixgbe: support new devices and mac types Wenzhuo Lu
2016-02-15 21:39 ` [dpdk-dev] [PATCH v2 00/11] update ixgbe base driver Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6A0DE07E22DDAD4C9103DF62FEBC09090342A3FE@shsmsx102.ccr.corp.intel.com \
--to=wenzhuo.lu@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).