From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: Igor Ryzhov <iryzhov@nfware.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,
"Zhang, Helin" <helin.zhang@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Subject: Re: [dpdk-dev] [PATCH] ethdev: don't count missed packets in erroneous packets counter
Date: Mon, 14 Mar 2016 08:26:49 +0000 [thread overview]
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09090343AF93@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <804A039F-3BC4-48A7-8708-7ED3805CA239@nfware.com>
Hi,
> -----Original Message-----
> From: Igor Ryzhov [mailto:iryzhov@nfware.com]
> Sent: Monday, March 14, 2016 3:31 PM
> To: Игорь Рыжов
> Cc: dev@dpdk.org; Rahul Lakkireddy; Lu, Wenzhuo; Zhang, Helin; Ananyev,
> Konstantin
> Subject: Re: [dpdk-dev] [PATCH] ethdev: don't count missed packets in
> erroneous packets counter
>
> Ping.
>
> CCing to maintainers of affected drivers.
>
> > 10 марта 2016 г., в 16:03, Igor Ryzhov <iryzhov@nfware.com> написал(а):
> >
> > Comment for "ierrors" counter says that it counts erroneous received packets.
> But for some reason "imissed" counter is added to "ierrors" counter in most
> drivers. It is a mistake, because missed packets are obviously not received. This
> patch fixes it.
> >
> > Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
Agree with Igor. As we have a counter for imissed, we need not to mix it with ierror.
next prev parent reply other threads:[~2016-03-14 8:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-10 13:03 Igor Ryzhov
2016-03-14 7:30 ` Igor Ryzhov
2016-03-14 8:26 ` Lu, Wenzhuo [this message]
2016-03-17 12:02 ` Rahul Lakkireddy
2016-03-17 16:40 ` Thomas Monjalon
2016-03-22 10:06 ` Thomas Monjalon
2016-03-22 15:23 ` Tahhan, Maryam
2016-03-22 15:57 ` [dpdk-dev] [PATCH] doc: notify Rx errors not counting missed packets anymore Thomas Monjalon
2016-03-22 16:58 ` Thomas Monjalon
2016-03-22 18:28 ` [dpdk-dev] [PATCH] ethdev: don't count missed packets in erroneous packets counter Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6A0DE07E22DDAD4C9103DF62FEBC09090343AF93@shsmsx102.ccr.corp.intel.com \
--to=wenzhuo.lu@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=iryzhov@nfware.com \
--cc=konstantin.ananyev@intel.com \
--cc=rahul.lakkireddy@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).