From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] lib: fix DCB config issue on ixgbe
Date: Tue, 12 Apr 2016 00:39:06 +0000 [thread overview]
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC090903454571@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <2081231.H599pWkcUZ@xps13>
Hi Thomas,
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Monday, April 11, 2016 5:52 PM
> To: Lu, Wenzhuo
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] lib: fix DCB config issue on ixgbe
>
> 2016-04-11 16:24, Wenzhuo Lu:
> > An issue is found that DCB cannot be configged on ixgbe NICs. It's
> > said the TX queue number is not right.
> > On ixgbe the max TX queue number is not fixed, it depends on the
> > multi-queue mode. The API rte_eth_dev_configure should be used to
> > config this mode. But the input of this API includes TX queue number.
> > The problem is before the mode is configged, we cannot decide the TX
> > queue number.
> >
> > This patch adds an API to config RX & TX multi-queue mode separately.
> > After the mode is configged, the max RX & TX queue number is decided.
> > Then we can set the appropriate RX & TX queue number.
> >
> > Fixes: 96c0450dff86 (ixgbe: fix dropping packets from unsupported Tx
> > queues)
> > Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> > ---
> > app/test-pmd/testpmd.c | 40 +++++++++++++++++++---------------
> > lib/librte_ether/rte_ethdev.c | 17 +++++++++++++++
> > lib/librte_ether/rte_ethdev.h | 19 ++++++++++++++++
> > lib/librte_ether/rte_ether_version.map | 1 +
> > 4 files changed, 59 insertions(+), 18 deletions(-)
>
> Obviously, it will be considered for 16.07.
OK. I've got some feedback from the users that DCB is working, so I think it's not a critical issue and maybe only testpmd is impacted.
I'll send a new version later. As rte_ether_version.map should be change for 16.07.
Thanks.
next prev parent reply other threads:[~2016-04-12 0:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-11 8:24 Wenzhuo Lu
2016-04-11 9:52 ` Thomas Monjalon
2016-04-12 0:39 ` Lu, Wenzhuo [this message]
2016-05-04 21:47 ` [dpdk-dev] [PATCH v2] " Wenzhuo Lu
2016-05-05 21:33 ` [dpdk-dev] [PATCH v3] ethdev: " Wenzhuo Lu
2016-06-17 11:21 ` De Lara Guarch, Pablo
2016-06-22 17:01 ` Thomas Monjalon
2016-06-23 1:04 ` Lu, Wenzhuo
2016-06-23 12:21 ` Thomas Monjalon
2016-06-24 0:45 ` Lu, Wenzhuo
2016-06-30 1:40 ` Lu, Wenzhuo
2016-06-30 7:41 ` Thomas Monjalon
2016-06-30 8:23 ` Lu, Wenzhuo
2016-06-30 8:47 ` Lu, Wenzhuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6A0DE07E22DDAD4C9103DF62FEBC090903454571@shsmsx102.ccr.corp.intel.com \
--to=wenzhuo.lu@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).