From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Markos Chandras <mchandras@suse.de>
Subject: Re: [dpdk-dev] [PATCH] e1000/base: Add missing braces to the 'if' statements
Date: Fri, 24 Jun 2016 08:31:05 +0000 [thread overview]
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09090348A53B@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <2260730.VRpmIevhvb@xps13>
Hi Thomas, Markos,
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Friday, June 24, 2016 3:13 PM
> To: Lu, Wenzhuo
> Cc: dev@dpdk.org; Markos Chandras
> Subject: Re: [dpdk-dev] [PATCH] e1000/base: Add missing braces to the 'if'
> statements
>
> 2016-06-24 00:43, Lu, Wenzhuo:
> > Thanks for this patch. But normally the code in the base directory is synced
> from the kernel driver. So we don't change it if there's no critical issue. It's easy
> for us to maintain it. Thanks.
>
> I think a build error is critical enough.
OK. The change itself looks fine to me.
next prev parent reply other threads:[~2016-06-24 8:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-23 9:25 Markos Chandras
2016-06-23 10:26 ` Anupam Kapoor
2016-06-23 10:34 ` Markos Chandras
2016-06-23 10:46 ` Anupam Kapoor
2016-06-24 0:43 ` Lu, Wenzhuo
2016-06-24 7:12 ` Thomas Monjalon
2016-06-24 8:31 ` Lu, Wenzhuo [this message]
2016-06-27 15:05 ` Bruce Richardson
2016-06-27 14:39 ` Bruce Richardson
2016-06-27 15:47 ` Markos Chandras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6A0DE07E22DDAD4C9103DF62FEBC09090348A53B@shsmsx102.ccr.corp.intel.com \
--to=wenzhuo.lu@intel.com \
--cc=dev@dpdk.org \
--cc=mchandras@suse.de \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).