From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: "Dai, Wei" <wei.dai@intel.com>, "dev@dpdk.org" <dev@dpdk.org>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>,
"david.marchand@6wind.com" <david.marchand@6wind.com>,
"Dai, Wei" <wei.dai@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] eal/linuxapp: fix return value check of mknod()
Date: Wed, 16 Nov 2016 03:28:06 +0000 [thread overview]
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093935007B@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1479264047-67966-1-git-send-email-wei.dai@intel.com>
Hi Wei,
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wei Dai
> Sent: Wednesday, November 16, 2016 10:41 AM
> To: dev@dpdk.org; Burakov, Anatoly; david.marchand@6wind.com; Dai, Wei
> Subject: [dpdk-dev] [PATCH v2] eal/linuxapp: fix return value check of mknod()
>
> In function pci_mknod_uio_dev() in lib/librte_eal/eal/eal_pci_uio.c, The return
> value of mknod() is ret, not f got by fopen().
> So the value of ret should be checked for mknod().
>
> Fixes: 67c536bdad93 ("pci: move uio mapping in a dedicated file")
>
> Signed-off-by: Wei Dai <wei.dai@intel.com>
> ---
> fix my local git setting and send same patch again to make merging easier
>
> lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_uio.c
> b/lib/librte_eal/linuxapp/eal/eal_pci_uio.c
> index 1786b75..3e4ffb5 100644
> --- a/lib/librte_eal/linuxapp/eal/eal_pci_uio.c
> +++ b/lib/librte_eal/linuxapp/eal/eal_pci_uio.c
> @@ -133,7 +133,7 @@ pci_mknod_uio_dev(const char *sysfs_uio_path,
> unsigned uio_num)
> snprintf(filename, sizeof(filename), "/dev/uio%u", uio_num);
> dev = makedev(major, minor);
> ret = mknod(filename, S_IFCHR | S_IRUSR | S_IWUSR, dev);
> - if (f == NULL) {
> + if (ret != 0) {
I think checkpatch will suggest to just use if (ret)
next prev parent reply other threads:[~2016-11-16 3:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-16 2:12 [dpdk-dev] [PATCH] " Zhiyong Yang
2016-11-16 2:40 ` [dpdk-dev] [PATCH v2] " Wei Dai
2016-11-16 3:28 ` Lu, Wenzhuo [this message]
2016-11-16 11:04 ` Ferruh Yigit
2016-11-16 15:17 ` Dai, Wei
2016-11-16 11:23 ` David Marchand
2016-11-16 15:18 ` Dai, Wei
2016-11-17 6:47 ` [dpdk-dev] [PATCH v3] " Wei Dai
2016-12-06 10:44 ` Olivier Matz
2016-12-06 11:01 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6A0DE07E22DDAD4C9103DF62FEBC09093935007B@shsmsx102.ccr.corp.intel.com \
--to=wenzhuo.lu@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=wei.dai@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).