From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: Adrien Mazarguil <adrien.mazarguil@6wind.com>,
Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "Liu, Yong" <yong.liu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change for cloud filter
Date: Fri, 20 Jan 2017 02:14:49 +0000 [thread overview]
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B55C21C@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20170119184552.GB3779@6wind.com>
Hi Adrien, Thomas, Yong,
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Adrien Mazarguil
> Sent: Friday, January 20, 2017 2:46 AM
> To: Thomas Monjalon
> Cc: Liu, Yong; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change for cloud filter
>
> On Thu, Jan 19, 2017 at 10:06:34AM +0100, Thomas Monjalon wrote:
> > 2017-01-19 13:34, Yong Liu:
> > > +* ABI changes are planned for 17.05: structure
> > > +``rte_eth_tunnel_filter_conf``
> > > + will be extended with a new member ``vf_id`` in order to enable
> > > +cloud filter
> > > + on VF device.
> >
> > I think we should stop rely on this API, and migrate to rte_flow instead.
> > Adrien any thought?
>
> I'm all for using rte_flow in any case. I've already documented an approach to
> convert TUNNEL filter rules to rte_flow rules [1], although it may be
> incomplete due to my limited experience with this filter type. We already
> know several tunnel item types must be added (currently only VXLAN is
> defined).
>
> I understand ixgbe/i40e currently map rte_flow on top of the legacy
> framework, therefore extending this structure might still be needed in the
> meantime. Not sure we should prevent this change as long as such rules can be
> configured through rte_flow as well.
>
> [1] http://dpdk.org/doc/guides/prog_guide/rte_flow.html#tunnel-to-eth-ipv4-
> ipv6-vxlan-or-other-queue
The problem is we haven't finished transferring all the functions from the regular filters to the generic filters.
For example, igb, fm10k and enic haven't support generic filters yet. Ixgbe and i40e have supported the basic functions, but some advance features are not transferred to generic filters yet.
Seems it's not the time to remove the regular filters. Yong, I suggest to support both generic filter and regular filter in parallel.
So, we need to announce ABI change for the regular filter, until someday we remove the regular filter API.
>
> --
> Adrien Mazarguil
> 6WIND
next prev parent reply other threads:[~2017-01-20 2:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 5:34 Yong Liu
2017-01-19 9:06 ` Thomas Monjalon
2017-01-19 18:45 ` Adrien Mazarguil
2017-01-20 2:14 ` Lu, Wenzhuo [this message]
2017-01-20 2:18 ` Liu, Yong
2017-01-20 14:57 ` Thomas Monjalon
2017-02-14 3:19 ` Jerin Jacob
2017-01-19 17:39 ` Mcnamara, John
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6A0DE07E22DDAD4C9103DF62FEBC09093B55C21C@shsmsx102.ccr.corp.intel.com \
--to=wenzhuo.lu@intel.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
--cc=yong.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).