From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: "Legacy, Allain (Wind River)" <allain.legacy@windriver.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/e1000: advertise offload capabilities for the EM PMD
Date: Mon, 13 Mar 2017 03:15:49 +0000 [thread overview]
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B56EE2A@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1489156701-185471-1-git-send-email-allain.legacy@windriver.com>
Hi,
> -----Original Message-----
> From: Allain Legacy [mailto:allain.legacy@windriver.com]
> Sent: Friday, March 10, 2017 10:38 PM
> To: Lu, Wenzhuo
> Cc: dev@dpdk.org
> Subject: [PATCH] net/e1000: advertise offload capabilities for the EM PMD
>
> The hardware offload capabilities are not being advertised for the EM PMD.
> Because of this, applications that only enable these features if the device
> advertises them will never do so.
>
> Normally this is not an issue since normal packet processing should work even if
> hardware offload is not available. But, in older versions of Virtual Box the e1000
> device emulation (Intel PRO/1000 MT Desktop 82540EM) assumes that it should
> enable VLAN stripping even if the driver does not request it. This means that any
> ingress packets that have a VLAN tag will be stripped. Since the application did
> not request to enable VLAN stripping it is not expecting these packets so they
> are not processed as VLAN packets.
>
> Regardless of the Virtual Box issue, the driver should be advertising supported
> capabilities as is done in other drivers.
>
> Signed-off-by: Allain Legacy <allain.legacy@windriver.com>
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
next prev parent reply other threads:[~2017-03-13 3:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-10 14:38 Allain Legacy
2017-03-13 3:15 ` Lu, Wenzhuo [this message]
2017-03-14 15:19 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6A0DE07E22DDAD4C9103DF62FEBC09093B56EE2A@shsmsx102.ccr.corp.intel.com \
--to=wenzhuo.lu@intel.com \
--cc=allain.legacy@windriver.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).