From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: "Yang, Qiming" <qiming.yang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] igbvf: fix MAC address set problem
Date: Fri, 28 Apr 2017 07:20:24 +0000 [thread overview]
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B59DA11@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <F5DF4F0E3AFEF648ADC1C3C33AD4DBF16EE054CE@SHSMSX101.ccr.corp.intel.com>
Hi Qiming,
> -----Original Message-----
> From: Yang, Qiming
> Sent: Friday, April 28, 2017 2:54 PM
> To: Lu, Wenzhuo; dev@dpdk.org
> Cc: stable@dpdk.org
> Subject: RE: [PATCH] igbvf: fix MAC address set problem
>
> Hi, Wenzhuo
>
> > -----Original Message-----
> > From: Lu, Wenzhuo
> > Sent: Friday, April 28, 2017 8:39 AM
> > To: Yang, Qiming <qiming.yang@intel.com>; dev@dpdk.org
> > Cc: stable@dpdk.org
> > Subject: RE: [PATCH] igbvf: fix MAC address set problem
> >
> > Hi Qiming,
> >
> > > -----Original Message-----
> > > From: Yang, Qiming
> > > Sent: Thursday, April 27, 2017 5:02 PM
> > > To: dev@dpdk.org
> > > Cc: Lu, Wenzhuo; stable@dpdk.org; Yang, Qiming
> > > Subject: [PATCH] igbvf: fix MAC address set problem
> > >
> > > We find that VF receive address register is not set if MAC address
> > > is assigned by PF. This patch fixes it.
> > >
> > > Signed-off-by: Qiming Yang <qiming.yang@intel.com>
> > >
> > > Fixes: 2a3cf07108b4 ("igbvf: fix MAC address if none assigned by
> > > PF")
> > A little confused about the Fixes. You said this patch is for when mac
> > address is set by PF. But the fixes said the previous patch is for not
> > set by PF. Seems they're different scenarios. Why this can a fix for a
> different scenario?
> > Thanks.
>
> Previous patch only do rar set when random a MAC for VF, when MAC
> address is assigned by PF, register is not set.
> Maybe I should correct the fix line, the issue I fixed is exist before
> 2a3cf07108b4.
Better if you can find the previous patch :)
next prev parent reply other threads:[~2017-04-28 7:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-27 9:02 Qiming Yang
2017-04-28 0:39 ` Lu, Wenzhuo
2017-04-28 6:53 ` Yang, Qiming
2017-04-28 7:20 ` Lu, Wenzhuo [this message]
2017-05-03 5:52 ` [dpdk-stable] [PATCH v2] net/e1000: fix VF " Qiming Yang
2017-05-03 7:13 ` Lu, Wenzhuo
2017-05-05 14:45 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6A0DE07E22DDAD4C9103DF62FEBC09093B59DA11@shsmsx102.ccr.corp.intel.com \
--to=wenzhuo.lu@intel.com \
--cc=dev@dpdk.org \
--cc=qiming.yang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).