DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: "Mcnamara, John" <john.mcnamara@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] doc: update ixgbe doc
Date: Wed, 10 May 2017 01:03:25 +0000	[thread overview]
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B5AC236@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <B27915DBBA3421428155699D51E4CFE2332CA5C6@IRSMSX103.ger.corp.intel.com>

Hi John,

> -----Original Message-----
> From: Mcnamara, John
> Sent: Wednesday, May 10, 2017 12:39 AM
> To: Lu, Wenzhuo; dev@dpdk.org
> Subject: RE: [PATCH] doc: update ixgbe doc
> 
> 
> 
> > -----Original Message-----
> > From: Lu, Wenzhuo
> > Sent: Wednesday, May 3, 2017 6:55 AM
> > To: dev@dpdk.org
> > Cc: Mcnamara, John <john.mcnamara@intel.com>; Lu, Wenzhuo
> > <wenzhuo.lu@intel.com>
> > Subject: [PATCH] doc: update ixgbe doc
> >
> > Add more explanation about how to disable MDD on kernel PF.
> >
> > Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> > ---
> >  doc/guides/nics/ixgbe.rst | 9 ++++++---
> >  1 file changed, 6 insertions(+), 3 deletions(-)
> >
> > diff --git a/doc/guides/nics/ixgbe.rst b/doc/guides/nics/ixgbe.rst
> > index
> > 130765b..6773fe5 100644
> > --- a/doc/guides/nics/ixgbe.rst
> > +++ b/doc/guides/nics/ixgbe.rst
> > @@ -186,9 +186,12 @@ the advanced context descriptor should be set
> and
> > set it. And DPDK has to ask  the info about the header length from the
> > upper layer, because parsing the  packet itself is not acceptable. So,
> > it's too expensive to support MDD.
> >  When using kernel PF + DPDK VF on x550, please make sure using the
> > kernel -driver that disables MDD or can disable MDD. (Some kernel
> > driver can use -this CLI 'insmod ixgbe.ko MDD=0,0' to disable MDD.
> > Some kernel driver disables -it by default.)
> > +PF driver that disables MDD or can disable MDD.
> > +Some kernel driver already disables MDD by default.
> > +Some kernel driver can use this CLI "insmod ixgbe.ko MDD=0,0" to
> > +disable
> > MDD.
> > +Every "0" in the CLI means a port. Users need to add more "0"s if the
> > +machine has more ports. For example, if there're 6 ixgbe ports, the
> > +CLI should be changed to "insmod ixgbe.ko MDD=0,0,0,0,0,0".
> 
> Something like this would be better:
> 
> ...
> When using kernel PF + DPDK VF on x550, please make sure to use a kernel
> PF driver that disables MDD or can disable MDD.
> 
> Some kernel drivers already disable MDD by default while some kernels can
> use the command ``insmod ixgbe.ko MDD=0,0`` to disable MDD. Each "0" in
> the command refers to a port. For example, if there are 6 ixgbe ports, the
> command should be changed to ``insmod ixgbe.ko MDD=0,0,0,0,0,0``.
Thanks for your comments. I'll reword the patch.

  reply	other threads:[~2017-05-10  1:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-03  5:54 Wenzhuo Lu
2017-05-09 16:38 ` Mcnamara, John
2017-05-10  1:03   ` Lu, Wenzhuo [this message]
2017-05-10  1:39 ` [dpdk-dev] [PATCH v2] doc: update ixgbe doc about mdd in kernel pf Wenzhuo Lu
2017-05-10  9:36   ` Mcnamara, John
2017-05-10 20:15     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6A0DE07E22DDAD4C9103DF62FEBC09093B5AC236@SHSMSX103.ccr.corp.intel.com \
    --to=wenzhuo.lu@intel.com \
    --cc=dev@dpdk.org \
    --cc=john.mcnamara@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).