From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Zhang, Helin" <helin.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/3] net/ixgbe: replace macro with inline function
Date: Thu, 1 Jun 2017 05:09:05 +0000 [thread overview]
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B5C98B0@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1495828350-10259-2-git-send-email-qi.z.zhang@intel.com>
Hi Qi,
> -----Original Message-----
> From: Zhang, Qi Z
> Sent: Saturday, May 27, 2017 3:52 AM
> To: Zhang, Helin; Lu, Wenzhuo
> Cc: dev@dpdk.org; Zhang, Qi Z
> Subject: [PATCH 1/3] net/ixgbe: replace macro with inline function
>
> Code clean, replace macro with inline funtion for searching next no void
> pattern and next no void action
>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
> drivers/net/ixgbe/ixgbe_flow.c | 208 +++++++++++++++--------------------------
> 1 file changed, 73 insertions(+), 135 deletions(-)
This patch is good, but don't understand the necessity to replace the macro. Would you like to add more explanation in the commit log?
next prev parent reply other threads:[~2017-06-01 5:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-26 19:52 [dpdk-dev] [PATCH 0/3] net/ixgbe: enable signature match and ipv6 for consistent API Qi Zhang
2017-05-26 19:52 ` [dpdk-dev] [PATCH 1/3] net/ixgbe: replace macro with inline function Qi Zhang
2017-06-01 5:09 ` Lu, Wenzhuo [this message]
2017-05-26 19:52 ` [dpdk-dev] [PATCH 2/3] net/ixgbe: enable signature match for consistent API Qi Zhang
2017-06-01 5:50 ` Lu, Wenzhuo
2017-06-01 5:56 ` Zhang, Qi Z
2017-06-01 6:13 ` Lu, Wenzhuo
2017-06-01 6:14 ` Zhang, Qi Z
2017-05-26 19:52 ` [dpdk-dev] [PATCH 3/3] net/ixgbe: enable IPv6 " Qi Zhang
2017-06-01 6:15 ` Lu, Wenzhuo
2017-06-01 6:19 ` Zhang, Qi Z
2017-06-07 23:08 ` [dpdk-dev] [PATCH v2 0/3] net/ixgbe: enable signature match and ipv6 " Qi Zhang
2017-06-07 23:08 ` [dpdk-dev] [PATCH v2 1/3] net/ixgbe: replace macro with inline function Qi Zhang
2017-06-07 23:08 ` [dpdk-dev] [PATCH v2 2/3] net/ixgbe: enable signature match for consistent API Qi Zhang
2017-06-07 23:08 ` [dpdk-dev] [PATCH v2 3/3] net/ixgbe: enable IPv6 " Qi Zhang
2017-06-08 6:57 ` [dpdk-dev] [PATCH v2 0/3] net/ixgbe: enable signature match and ipv6 " Lu, Wenzhuo
2017-07-05 2:21 ` [dpdk-dev] [PATCH v4 " Qi Zhang
2017-07-05 2:21 ` [dpdk-dev] [PATCH v4 1/3] net/ixgbe: replace macro with inline function Qi Zhang
2017-07-05 2:21 ` [dpdk-dev] [PATCH v4 2/3] net/ixgbe: enable signature match for consistent API Qi Zhang
2017-07-05 2:21 ` [dpdk-dev] [PATCH v4 3/3] net/ixgbe: enable IPv6 " Qi Zhang
2017-07-05 18:30 ` [dpdk-dev] [PATCH v4 0/3] net/ixgbe: enable signature match and ipv6 " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6A0DE07E22DDAD4C9103DF62FEBC09093B5C98B0@shsmsx102.ccr.corp.intel.com \
--to=wenzhuo.lu@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=qi.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).