From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Zhang, Helin" <helin.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 1/3] net/ixgbe: remove reduandent code
Date: Thu, 1 Jun 2017 07:05:34 +0000 [thread overview]
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B5C9AE5@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1496259940-15547-2-git-send-email-qi.z.zhang@intel.com>
Hi Qi,
> -----Original Message-----
> From: Zhang, Qi Z
> Sent: Thursday, June 1, 2017 3:46 AM
> To: Lu, Wenzhuo; Zhang, Helin
> Cc: dev@dpdk.org; Zhang, Qi Z
> Subject: [PATCH v2 1/3] net/ixgbe: remove reduandent code
>
> Remove reduandent code.
> item->type != RTE_FLOW_ITEM_TYPE_END already cover type ==
> item->RTE_FLOW_ITEM_TYPE_VLAN.
>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
> drivers/net/ixgbe/ixgbe_flow.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c
> index da7b1cc..2c09444 100644
> --- a/drivers/net/ixgbe/ixgbe_flow.c
> +++ b/drivers/net/ixgbe/ixgbe_flow.c
> @@ -1549,13 +1549,7 @@ ixgbe_parse_fdir_filter_normal(const struct
> rte_flow_attr *attr,
> */
Please change the above comments too.
> index++;
> NEXT_ITEM_OF_PATTERN(item, pattern, index);
> - if (item->type == RTE_FLOW_ITEM_TYPE_VLAN) {
> - memset(rule, 0, sizeof(struct ixgbe_fdir_rule));
> - rte_flow_error_set(error, EINVAL,
> - RTE_FLOW_ERROR_TYPE_ITEM,
> - item, "Not supported by fdir filter");
> - return -rte_errno;
> - } else if (item->type != RTE_FLOW_ITEM_TYPE_END) {
> + if (item->type != RTE_FLOW_ITEM_TYPE_END) {
> memset(rule, 0, sizeof(struct ixgbe_fdir_rule));
> rte_flow_error_set(error, EINVAL,
> RTE_FLOW_ERROR_TYPE_ITEM,
> --
> 2.7.4
next prev parent reply other threads:[~2017-06-01 7:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 19:45 [dpdk-dev] [PATCH v2 0/3] ixgbe: enable flex filter for rte_flow Qi Zhang
2017-05-31 19:45 ` [dpdk-dev] [PATCH v2 1/3] net/ixgbe: remove reduandent code Qi Zhang
2017-06-01 7:05 ` Lu, Wenzhuo [this message]
2017-05-31 19:45 ` [dpdk-dev] [PATCH v2 2/3] net/ixgbe: fix fdir mask not be reset Qi Zhang
2017-06-01 7:17 ` Lu, Wenzhuo
2017-05-31 19:45 ` [dpdk-dev] [PATCH v2 3/3] net/ixgbe: enable flex bytes for generic flow API Qi Zhang
2017-06-02 1:49 ` Lu, Wenzhuo
2017-06-02 2:00 ` Zhang, Qi Z
2017-06-02 2:14 ` Lu, Wenzhuo
2017-06-01 17:36 ` [dpdk-dev] [PATCH v3 0/3] ixgbe: enable flex filter for rte_flow Qi Zhang
2017-06-01 17:36 ` [dpdk-dev] [PATCH v3 1/3] net/ixgbe: remove reduandent code Qi Zhang
2017-06-02 1:19 ` Lu, Wenzhuo
2017-06-01 17:36 ` [dpdk-dev] [PATCH v3 2/3] net/ixgbe: fix fdir mask not be reset Qi Zhang
2017-06-01 17:36 ` [dpdk-dev] [PATCH v3 3/3] net/ixgbe: enable flex bytes for generic flow API Qi Zhang
2017-06-06 10:26 ` [dpdk-dev] [PATCH v3 0/3] ixgbe: enable flex filter for rte_flow Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6A0DE07E22DDAD4C9103DF62FEBC09093B5C9AE5@shsmsx102.ccr.corp.intel.com \
--to=wenzhuo.lu@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=qi.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).