From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Zhang, Helin" <helin.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 3/3] net/ixgbe: enable flex bytes for generic flow API
Date: Fri, 2 Jun 2017 01:49:14 +0000 [thread overview]
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B5CAFB2@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1496259940-15547-4-git-send-email-qi.z.zhang@intel.com>
Hi Qi,
> -----Original Message-----
> From: Zhang, Qi Z
> Sent: Thursday, June 1, 2017 3:46 AM
> To: Lu, Wenzhuo; Zhang, Helin
> Cc: dev@dpdk.org; Zhang, Qi Z
> Subject: [PATCH v2 3/3] net/ixgbe: enable flex bytes for generic flow API
>
> Add fdir flex byte support for rte_flow APIs.
>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
>
> v2:
> - fix couple checkpatch errors.
>
> drivers/net/ixgbe/ixgbe_ethdev.h | 3 +
> drivers/net/ixgbe/ixgbe_fdir.c | 31 ++++++++-
> drivers/net/ixgbe/ixgbe_flow.c | 137
> ++++++++++++++++++++++++++++++++++++++-
> 3 files changed, 167 insertions(+), 4 deletions(-)
> diff --git a/drivers/net/ixgbe/ixgbe_fdir.c b/drivers/net/ixgbe/ixgbe_fdir.c
> index 7f6c7b5..950f5ba 100644
> --- a/drivers/net/ixgbe/ixgbe_fdir.c
> +++ b/drivers/net/ixgbe/ixgbe_fdir.c
> @@ -302,7 +302,7 @@ fdir_set_input_mask_82599(struct rte_eth_dev *dev)
> * mask VM pool and DIPv6 since there are currently not supported
> * mask FLEX byte, it will be set in flex_conf
> */
> - uint32_t fdirm = IXGBE_FDIRM_POOL | IXGBE_FDIRM_DIPv6 |
> IXGBE_FDIRM_FLEX;
> + uint32_t fdirm = IXGBE_FDIRM_POOL | IXGBE_FDIRM_DIPv6;
> uint32_t fdirtcpm; /* TCP source and destination port masks. */
> uint32_t fdiripv6m; /* IPv6 source and destination masks. */
> volatile uint32_t *reg;
> @@ -333,6 +333,10 @@ fdir_set_input_mask_82599(struct rte_eth_dev *dev)
> return -EINVAL;
> }
>
> + /* flex byte mask */
> + if (info->mask.flex_bytes_mask == 0)
> + fdirm |= IXGBE_FDIRM_FLEX;
> +
> IXGBE_WRITE_REG(hw, IXGBE_FDIRM, fdirm);
Should the same change be done for x550?
next prev parent reply other threads:[~2017-06-02 1:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 19:45 [dpdk-dev] [PATCH v2 0/3] ixgbe: enable flex filter for rte_flow Qi Zhang
2017-05-31 19:45 ` [dpdk-dev] [PATCH v2 1/3] net/ixgbe: remove reduandent code Qi Zhang
2017-06-01 7:05 ` Lu, Wenzhuo
2017-05-31 19:45 ` [dpdk-dev] [PATCH v2 2/3] net/ixgbe: fix fdir mask not be reset Qi Zhang
2017-06-01 7:17 ` Lu, Wenzhuo
2017-05-31 19:45 ` [dpdk-dev] [PATCH v2 3/3] net/ixgbe: enable flex bytes for generic flow API Qi Zhang
2017-06-02 1:49 ` Lu, Wenzhuo [this message]
2017-06-02 2:00 ` Zhang, Qi Z
2017-06-02 2:14 ` Lu, Wenzhuo
2017-06-01 17:36 ` [dpdk-dev] [PATCH v3 0/3] ixgbe: enable flex filter for rte_flow Qi Zhang
2017-06-01 17:36 ` [dpdk-dev] [PATCH v3 1/3] net/ixgbe: remove reduandent code Qi Zhang
2017-06-02 1:19 ` Lu, Wenzhuo
2017-06-01 17:36 ` [dpdk-dev] [PATCH v3 2/3] net/ixgbe: fix fdir mask not be reset Qi Zhang
2017-06-01 17:36 ` [dpdk-dev] [PATCH v3 3/3] net/ixgbe: enable flex bytes for generic flow API Qi Zhang
2017-06-06 10:26 ` [dpdk-dev] [PATCH v3 0/3] ixgbe: enable flex filter for rte_flow Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6A0DE07E22DDAD4C9103DF62FEBC09093B5CAFB2@shsmsx102.ccr.corp.intel.com \
--to=wenzhuo.lu@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=qi.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).