From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: "Dai, Wei" <wei.dai@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: add support of 2.5G and 5G on X550
Date: Wed, 26 Jul 2017 13:26:10 +0000 [thread overview]
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B67CB9F@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1501061376-41938-1-git-send-email-wei.dai@intel.com>
Hi Wei,
> -----Original Message-----
> From: Dai, Wei
> Sent: Wednesday, July 26, 2017 5:30 AM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>
> Cc: dev@dpdk.org; Dai, Wei <wei.dai@intel.com>
> Subject: [PATCH v2] net/ixgbe: add support of 2.5G and 5G on X550
>
> This patch adds support of 2.5G and 5G ethernet interface on X550.
>
> Signed-off-by: Wei Dai <wei.dai@intel.com>
> ---
> drivers/net/ixgbe/ixgbe_ethdev.c | 33 ++++++++++++++++++++++++++++++--
> -
> 1 file changed, 30 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index 194058f..60e1d5a 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -2647,9 +2647,28 @@ ixgbe_dev_start(struct rte_eth_dev *dev)
>
> speed = 0x0;
> if (*link_speeds == ETH_LINK_SPEED_AUTONEG) {
> - speed = (hw->mac.type != ixgbe_mac_82598EB) ?
> - IXGBE_LINK_SPEED_82599_AUTONEG :
> - IXGBE_LINK_SPEED_82598_AUTONEG;
> + switch (hw->mac.type) {
> + case ixgbe_mac_82598EB:
> + speed = IXGBE_LINK_SPEED_82598_AUTONEG;
> + break;
> +
> + case ixgbe_mac_82599EB:
> + case ixgbe_mac_X540:
> + speed = IXGBE_LINK_SPEED_82599_AUTONEG;
> + break;
> +
> + case ixgbe_mac_X550:
> + case ixgbe_mac_X550EM_x:
> + case ixgbe_mac_X550EM_a:
> + speed = IXGBE_LINK_SPEED_100_FULL |
> + IXGBE_LINK_SPEED_1GB_FULL |
> + IXGBE_LINK_SPEED_10GB_FULL |
> + IXGBE_LINK_SPEED_2_5GB_FULL |
> + IXGBE_LINK_SPEED_5GB_FULL;
Thanks for the patch. It looks good to me. A suggestion, why not define a macro like IXGBE_LINK_SPEED_82599_AUTONEG for x550?
> + break;
> + default:
> + speed = IXGBE_LINK_SPEED_82599_AUTONEG;
> + }
> } else {
> if (*link_speeds & ETH_LINK_SPEED_10G)
> speed |= IXGBE_LINK_SPEED_10GB_FULL; @@ -
> 3972,6 +3991,14 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev,
> link.link_speed = ETH_SPEED_NUM_1G;
> break;
>
> + case IXGBE_LINK_SPEED_2_5GB_FULL:
> + link.link_speed = ETH_SPEED_NUM_2_5G;
> + break;
> +
> + case IXGBE_LINK_SPEED_5GB_FULL:
> + link.link_speed = ETH_SPEED_NUM_5G;
> + break;
> +
> case IXGBE_LINK_SPEED_10GB_FULL:
> link.link_speed = ETH_SPEED_NUM_10G;
> break;
> --
> 2.7.5
next prev parent reply other threads:[~2017-07-26 13:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 2:00 [dpdk-dev] [PATCH] net/ixgbe: add support of 2.5G and 5G Wei Dai
2017-07-26 9:29 ` [dpdk-dev] [PATCH v2] net/ixgbe: add support of 2.5G and 5G on X550 Wei Dai
2017-07-26 13:26 ` Lu, Wenzhuo [this message]
2017-07-26 14:10 ` Dai, Wei
2017-07-26 14:13 ` Lu, Wenzhuo
2017-07-26 14:31 ` Dai, Wei
2017-07-26 14:43 ` [dpdk-dev] [PATCH v3] " Wei Dai
2017-07-26 15:01 ` Lu, Wenzhuo
2017-07-26 15:27 ` Dai, Wei
2017-07-26 15:29 ` [dpdk-dev] [PATCH v4] " Wei Dai
2017-07-26 16:59 ` Lu, Wenzhuo
2017-07-26 23:57 ` Dai, Wei
2017-07-27 1:02 ` [dpdk-dev] [PATCH v5] " Wei Dai
2017-07-27 1:07 ` Lu, Wenzhuo
2017-07-31 13:14 ` Ferruh Yigit
2017-07-31 17:48 ` Lu, Wenzhuo
2017-07-31 18:12 ` [dpdk-dev] [PATCH v6] " Wenzhuo Lu
2017-07-31 18:19 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6A0DE07E22DDAD4C9103DF62FEBC09093B67CB9F@shsmsx102.ccr.corp.intel.com \
--to=wenzhuo.lu@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=wei.dai@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).