From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Wu, Jingjing" <jingjing.wu@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>,
Stephen Hurd <stephen.hurd@broadcom.com>,
"Ajit Khaparde" <ajit.khaparde@broadcom.com>
Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: new API to add VF MAC address from PF
Date: Thu, 17 Aug 2017 13:36:57 +0000 [thread overview]
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B693659@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <fc43bdc8-fb00-734e-bb31-0651671a508e@intel.com>
Hi Ferruh,
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Thursday, August 17, 2017 9:05 AM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; dev@dpdk.org
> Cc: Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com>;
> Stephen Hurd <stephen.hurd@broadcom.com>; Ajit Khaparde
> <ajit.khaparde@broadcom.com>
> Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: new API to add VF MAC address
> from PF
>
> On 7/25/2017 3:09 PM, Wenzhuo Lu wrote:
> > Currently, on i40e the parameter 'pool' of API
> > rte_eth_dev_mac_addr_add means the VMDq pool, not VF.
>
> The argument "pool" in rte_eth_dev_mac_addr_add() IS VMDq pool.
> This is not just for i40e, this is by API definition.
>
> > So, it's wrong to use it to set the VF MAC address.
>
> Agreed, it seems testpmd function cmd_vf_mac_addr_parsed() implemented
> wrong.
>
> > As this API is also used by the VMDq example, ideally we need a
> > parameter to tell the pool is VMDq or VF.
> > But it's hard to change it because of the ABI change concern.
>
> I think we shouldn't NOT update rte_eth_dev_mac_addr_add() API, it is not
> wrong.
Agree :)
>
> But should fix testpmd ""mac_addr add port <port_id> vf <vf_id>
> <mac_addr>" command.
>
> Can you please update this patch as two patches:
>
> 1- i40e rte_pmd_i40e_add_vf_mac_addr() API
>
> 2- Fix testpmd function, instead of inserting new i40e API replace it with
> wrong rte_eth_dev_mac_addr_add() call.
> And I guess bnxt driver also has API to add VF MAC, can you add that one too?
Thanks for the suggestion. Will send a new version.
>
> > Now the solution is to provide a new API, users can call it to add VF
> > MAC address from PF on i40e.
> >
> > Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
>
> <...>
next prev parent reply other threads:[~2017-08-17 13:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-24 20:51 [dpdk-dev] [PATCH] " Wenzhuo Lu
2017-07-25 14:09 ` [dpdk-dev] [PATCH v2] " Wenzhuo Lu
2017-08-17 13:05 ` Ferruh Yigit
2017-08-17 13:36 ` Lu, Wenzhuo [this message]
2017-08-17 18:33 ` [dpdk-dev] [PATCH v3 0/2] fix adding VF MAC in testpmd Wenzhuo Lu
2017-08-17 18:33 ` [dpdk-dev] [PATCH v3 1/2] net/i40e: new API to add VF MAC address from PF Wenzhuo Lu
2017-08-18 0:32 ` Stephen Hemminger
2017-08-18 16:43 ` Ferruh Yigit
2017-08-19 12:52 ` Lu, Wenzhuo
2017-08-17 18:33 ` [dpdk-dev] [PATCH v3 2/2] app/testpmd: fix wrong API of adding VF MAC Wenzhuo Lu
2017-08-28 9:53 ` [dpdk-dev] [PATCH v3 0/2] fix adding VF MAC in testpmd Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6A0DE07E22DDAD4C9103DF62FEBC09093B693659@shsmsx102.ccr.corp.intel.com \
--to=wenzhuo.lu@intel.com \
--cc=ajit.khaparde@broadcom.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jingjing.wu@intel.com \
--cc=stephen.hurd@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).