From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: Yong Wang <wang.yong19@zte.com.cn>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix uninitialized variable
Date: Wed, 11 Oct 2017 02:57:55 +0000 [thread overview]
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B6C240A@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1505791044-5322-1-git-send-email-wang.yong19@zte.com.cn>
Hi,
> -----Original Message-----
> From: Yong Wang [mailto:wang.yong19@zte.com.cn]
> Sent: Tuesday, September 19, 2017 11:17 AM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>
> Cc: dev@dpdk.org; Yong Wang <wang.yong19@zte.com.cn>
> Subject: [PATCH] net/ixgbe: fix uninitialized variable
>
> In func ixgbe_dev_link_update(), "link.link_autoneg" is used in func call
> rte_ixgbe_dev_atomic_write_link_status(), but is uninitialized.
>
> Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
> ---
> drivers/net/ixgbe/ixgbe_ethdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index 9ca5cbc..971de0c 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -3957,6 +3957,7 @@ static int
> ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev,
> link.link_status = ETH_LINK_DOWN;
> link.link_speed = 0;
> link.link_duplex = ETH_LINK_HALF_DUPLEX;
> + link.link_autoneg = ETH_LINK_AUTONEG;
TBH, I don't find ixgbe uses this field. But this patch doesn't harm.
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> memset(&old, 0, sizeof(old));
> rte_ixgbe_dev_atomic_read_link_status(dev, &old);
>
> --
> 1.8.3.1
next prev parent reply other threads:[~2017-10-11 2:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-19 3:17 Yong Wang
2017-10-11 2:57 ` Lu, Wenzhuo [this message]
2017-10-11 22:53 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6A0DE07E22DDAD4C9103DF62FEBC09093B6C240A@shsmsx102.ccr.corp.intel.com \
--to=wenzhuo.lu@intel.com \
--cc=dev@dpdk.org \
--cc=wang.yong19@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).