From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: Roger B Melton <rmelton@cisco.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] net/e1000: correct VLAN tag byte order for i35x LB packets
Date: Mon, 16 Oct 2017 00:43:54 +0000 [thread overview]
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B6D1EA1@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20171012172435.34700-1-rmelton@cisco.com>
Hi,
> -----Original Message-----
> From: Roger B Melton [mailto:rmelton@cisco.com]
> Sent: Friday, October 13, 2017 1:25 AM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>
> Cc: dev@dpdk.org; Roger B Melton <rmelton@cisco.com>
> Subject: [PATCH v2] net/e1000: correct VLAN tag byte order for i35x LB
> packets
>
> When copying VLAN tags from the RX descriptor to the vlan_tci field in the
> mbuf header, igb_rxtx.c:eth_igb_recv_pkts() and
> eth_igb_recv_scattered_pkts() both assume that the VLAN tag is always little
> endian. While i350, i354 and /i350vf VLAN non-loopback packets are stored
> little endian, VLAN tags in loopback packets for those devices are big endian.
>
> For i350, i354 and i350vf VLAN loopback packets, swap the tag when copying
> from the RX descriptor to the mbuf header. This will ensure that the mbuf
> vlan_tci is always little endian.
>
> Signed-off-by: Roger B Melton <rmelton@cisco.com>
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
next prev parent reply other threads:[~2017-10-16 0:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-12 17:24 Roger B Melton
2017-10-16 0:43 ` Lu, Wenzhuo [this message]
2017-10-25 21:37 ` Ferruh Yigit
2017-10-20 19:04 ` Ferruh Yigit
2017-10-23 17:42 ` Roger B. Melton
2017-10-25 18:11 ` Ferruh Yigit
2017-10-25 20:16 ` Bruce Richardson
2017-10-25 20:22 ` Ferruh Yigit
2017-10-25 20:45 ` Roger B. Melton
2017-10-25 20:48 ` Richardson, Bruce
2017-10-25 21:11 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6A0DE07E22DDAD4C9103DF62FEBC09093B6D1EA1@shsmsx102.ccr.corp.intel.com \
--to=wenzhuo.lu@intel.com \
--cc=dev@dpdk.org \
--cc=rmelton@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).