From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: "Wu, Jingjing" <jingjing.wu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] net/avf: fix Rx interrupt mapping
Date: Wed, 9 May 2018 05:24:29 +0000 [thread overview]
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B798D6F@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1525316935-108339-2-git-send-email-jingjing.wu@intel.com>
Hi Jingjing,
> -----Original Message-----
> From: Wu, Jingjing
> Sent: Thursday, May 3, 2018 11:09 AM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>
> Cc: Wu, Jingjing <jingjing.wu@intel.com>; dev@dpdk.org; stable@dpdk.org
> Subject: [PATCH] net/avf: fix Rx interrupt mapping
>
> Vector used for rx mapping is different if WB_ON_ITR is supported. The
> mapping table need to be updated.
>
> Fixes: d6bde6b5eae9 ("net/avf: enable Rx interrupt")
>
> Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
> Cc: stable@dpdk.org
> ---
> drivers/net/avf/avf_ethdev.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c index
> a1ae3a2..db0eda4 100644
> --- a/drivers/net/avf/avf_ethdev.c
> +++ b/drivers/net/avf/avf_ethdev.c
> @@ -339,13 +339,13 @@ static int avf_config_rx_queues_irqs(struct
> rte_eth_dev *dev,
> AVF_WRITE_FLUSH(hw);
> /* map all queues to the same interrupt */
> for (i = 0; i < dev->data->nb_rx_queues; i++)
> - vf->rxq_map[0] |= 1 << i;
> + vf->rxq_map[vf->msix_base] |= 1 << i;
> } else {
> if (!rte_intr_allow_others(intr_handle)) {
> vf->nb_msix = 1;
> vf->msix_base = AVF_MISC_VEC_ID;
> for (i = 0; i < dev->data->nb_rx_queues; i++) {
> - vf->rxq_map[0] |= 1 << i;
> + vf->rxq_map[AVF_MISC_VEC_ID] |= 1 << i;
Looks better using " vf->msix_base" here too.
> intr_handle->intr_vec[i] = AVF_MISC_VEC_ID;
> }
> PMD_DRV_LOG(DEBUG,
Better updating the debug log either.
> --
> 2.4.11
next prev parent reply other threads:[~2018-05-09 5:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-03 3:08 Jingjing Wu
2018-05-03 3:08 ` Jingjing Wu
2018-05-09 5:24 ` Lu, Wenzhuo [this message]
2018-05-11 15:09 ` [dpdk-stable] [PATCH v2] " Jingjing Wu
2018-05-11 15:09 ` Jingjing Wu
2018-05-14 12:34 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6A0DE07E22DDAD4C9103DF62FEBC09093B798D6F@shsmsx102.ccr.corp.intel.com \
--to=wenzhuo.lu@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).