From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] ethdev: fix device info getting
Date: Fri, 13 Jul 2018 01:56:00 +0000 [thread overview]
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B803E5E@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <0aacbeca-6bb9-2be9-76cd-2857c46b9eca@solarflare.com>
Hi Andrew,
> -----Original Message-----
> From: Andrew Rybchenko [mailto:arybchenko@solarflare.com]
> Sent: Thursday, July 12, 2018 4:06 PM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] ethdev: fix device info getting
>
> On 12.07.2018 08:27, Wenzhuo Lu wrote:
> > The device information cannot be gotten correctly before the
> > configuration is set. Because on some NICs the information has
> > dependence on the configuration.
> >
> > Fixes: 3be82f5cc5e3 ("ethdev: support PMD-tuned Tx/Rx parameters")
> > Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> > ---
> > lib/librte_ethdev/rte_ethdev.c | 47 +++++++++++++++++++++------------------
> ---
> > 1 file changed, 24 insertions(+), 23 deletions(-)
> >
> > diff --git a/lib/librte_ethdev/rte_ethdev.c
> > b/lib/librte_ethdev/rte_ethdev.c index 3d556a8..9d60bea 100644
> > --- a/lib/librte_ethdev/rte_ethdev.c
> > +++ b/lib/librte_ethdev/rte_ethdev.c
> > @@ -1017,28 +1017,6 @@ struct rte_eth_dev *
> >
> > RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -EINVAL);
> >
> > - dev = &rte_eth_devices[port_id];
> > -
> > - RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_infos_get, -
> ENOTSUP);
> > - RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_configure, -
> ENOTSUP);
> > -
> > - rte_eth_dev_info_get(port_id, &dev_info);
> > -
> > - /* If number of queues specified by application for both Rx and Tx is
> > - * zero, use driver preferred values. This cannot be done individually
> > - * as it is valid for either Tx or Rx (but not both) to be zero.
> > - * If driver does not provide any preferred valued, fall back on
> > - * EAL defaults.
> > - */
> > - if (nb_rx_q == 0 && nb_tx_q == 0) {
> > - nb_rx_q = dev_info.default_rxportconf.nb_queues;
> > - if (nb_rx_q == 0)
> > - nb_rx_q = RTE_ETH_DEV_FALLBACK_RX_NBQUEUES;
> > - nb_tx_q = dev_info.default_txportconf.nb_queues;
> > - if (nb_tx_q == 0)
> > - nb_tx_q = RTE_ETH_DEV_FALLBACK_TX_NBQUEUES;
> > - }
> > -
> > if (nb_rx_q > RTE_MAX_QUEUES_PER_PORT) {
> > RTE_ETHDEV_LOG(ERR,
> > "Number of RX queues requested (%u) is greater
> than max
> > supported(%d)\n", @@ -1053,6 +1031,11 @@ struct rte_eth_dev *
> > return -EINVAL;
> > }
> >
> > + dev = &rte_eth_devices[port_id];
> > +
> > + RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_infos_get, -
> ENOTSUP);
> > + RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_configure, -
> ENOTSUP);
> > +
> > if (dev->data->dev_started) {
> > RTE_ETHDEV_LOG(ERR,
> > "Port %u must be stopped to allow configuration\n",
> @@ -1060,8
> > +1043,26 @@ struct rte_eth_dev *
> > return -EBUSY;
> > }
> >
> > - /* Copy the dev_conf parameter into the dev structure */
> > + /* Copy the dev_conf parameter into the dev structure,
> > + * then get the info.
> > + */
> > memcpy(&dev->data->dev_conf, &local_conf,
> > sizeof(dev->data->dev_conf));
> > + rte_eth_dev_info_get(port_id, &dev_info);
> > +
> > + /* If number of queues specified by application for both Rx and Tx is
> > + * zero, use driver preferred values. This cannot be done individually
> > + * as it is valid for either Tx or Rx (but not both) to be zero.
> > + * If driver does not provide any preferred valued, fall back on
> > + * EAL defaults.
> > + */
> > + if (nb_rx_q == 0 && nb_tx_q == 0) {
> > + nb_rx_q = dev_info.default_rxportconf.nb_queues;
> > + if (nb_rx_q == 0)
> > + nb_rx_q = RTE_ETH_DEV_FALLBACK_RX_NBQUEUES;
> > + nb_tx_q = dev_info.default_txportconf.nb_queues;
> > + if (nb_tx_q == 0)
> > + nb_tx_q = RTE_ETH_DEV_FALLBACK_TX_NBQUEUES;
>
> Values assigned in this branch are not checked against
> RTE_MAX_QUEUES_PER_PORT and RTE_MAX_QUEUES_PER_PORT now
O, I supposed the default values cannot be larger than RTE_MAX_QUEUES_PER_PORT. But, yes, it's each NIC's decision. My assumption can be wrong. I'll move the check down here.
>
> > + }
> >
> > /*
> > * Check that the numbers of RX and TX queues are not greater
next prev parent reply other threads:[~2018-07-13 1:56 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 5:27 Wenzhuo Lu
2018-07-12 8:06 ` Andrew Rybchenko
2018-07-13 1:56 ` Lu, Wenzhuo [this message]
2018-07-13 2:42 ` [dpdk-dev] [PATCH v2] " Wenzhuo Lu
2018-07-13 8:02 ` Andrew Rybchenko
2018-07-16 1:08 ` Lu, Wenzhuo
2018-07-16 1:58 ` Lu, Wenzhuo
2018-08-01 15:36 ` Thomas Monjalon
2018-08-13 2:50 ` Lu, Wenzhuo
2018-08-13 8:38 ` Andrew Rybchenko
2018-08-14 0:57 ` Lu, Wenzhuo
2018-08-22 16:55 ` Ferruh Yigit
2018-08-23 8:58 ` Andrew Rybchenko
2018-10-22 12:01 ` Ferruh Yigit
2018-10-22 12:13 ` Thomas Monjalon
2018-10-23 1:25 ` Lu, Wenzhuo
2018-10-23 7:28 ` Thomas Monjalon
2018-11-06 0:56 ` Lu, Wenzhuo
2018-11-06 7:40 ` Andrew Rybchenko
2018-11-08 2:09 ` [dpdk-dev] [PATCH v3 1/2] " Wenzhuo Lu
2018-11-08 2:09 ` [dpdk-dev] [PATCH v3 2/2] ethdev: device configuration enhancement Wenzhuo Lu
2018-11-08 6:25 ` Andrew Rybchenko
2018-11-09 21:10 ` Ferruh Yigit
2018-11-13 0:46 ` Lu, Wenzhuo
2018-11-13 9:40 ` Ferruh Yigit
2018-11-14 1:28 ` Lu, Wenzhuo
2018-11-13 11:12 ` [dpdk-dev] [PATCH v4 1/3] ethdev: fix invalid device configuration after failure Ferruh Yigit
2018-11-13 11:12 ` [dpdk-dev] [PATCH v4 2/3] ethdev: fix device info getting Ferruh Yigit
2018-11-13 11:19 ` Andrew Rybchenko
2018-11-13 11:12 ` [dpdk-dev] [PATCH v4 3/3] ethdev: eliminate interim variable Ferruh Yigit
2018-11-13 11:22 ` Andrew Rybchenko
2018-11-13 11:51 ` Ferruh Yigit
2018-11-13 11:56 ` Andrew Rybchenko
2018-11-13 11:19 ` [dpdk-dev] [PATCH v4 1/3] ethdev: fix invalid device configuration after failure Andrew Rybchenko
2018-11-13 17:49 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6A0DE07E22DDAD4C9103DF62FEBC09093B803E5E@shsmsx102.ccr.corp.intel.com \
--to=wenzhuo.lu@intel.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).