From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: "Mcnamara, John" <john.mcnamara@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] e1000: fix ieee1588 timestamp issue
Date: Fri, 31 Jul 2015 01:03:53 +0000 [thread overview]
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC0909D19DAD@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <B27915DBBA3421428155699D51E4CFE2022D8A48@IRSMSX103.ger.corp.intel.com>
Hi John,
> -----Original Message-----
> From: Mcnamara, John
> Sent: Thursday, July 30, 2015 5:59 PM
> To: Lu, Wenzhuo; dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH] e1000: fix ieee1588 timestamp issue
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu
> > Sent: Thursday, July 30, 2015 9:34 AM
> > To: dev@dpdk.org
> > Subject: [dpdk-dev] [PATCH] e1000: fix ieee1588 timestamp issue
> >
> > Ieee1588 reads system time to set its timestamp. On 1G NICs, for
> > example, i350, system time is disabled by default. It means the
> > ieee1588 timestamp will always be 0.
> > This patch enables system time when ieee1588 is enabled.
>
> Looks good.
>
>
> > +#define E1000_TSAUXC_DISABLE_SYSTIME 0x80000000
>
> Probably best to move this to the top of the file with the other timesync defines.
Thanks for looking into this. I'll send a V2.
>
>
> I wonder if this would also fix the following known issue with i210 timesyncing
> from the release notes:
>
> http://dpdk.org/doc/guides/rel_notes/known_issues.html#ieee1588-support-
> possibly-not-working-with-an-intel-ethernet-controller-i210-nic
>
> I don't have an i210 NIC to test but perhaps someone could verify it.
>
> John
next prev parent reply other threads:[~2015-07-31 1:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-30 8:34 Wenzhuo Lu
2015-07-30 9:58 ` Mcnamara, John
2015-07-31 1:03 ` Lu, Wenzhuo [this message]
2015-07-31 1:20 ` [dpdk-dev] [PATCH v2] " Wenzhuo Lu
2015-07-31 7:53 ` Mcnamara, John
2015-08-03 12:45 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6A0DE07E22DDAD4C9103DF62FEBC0909D19DAD@shsmsx102.ccr.corp.intel.com \
--to=wenzhuo.lu@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).