From: "Zhang, AlvinX" <alvinx.zhang@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
"Wang, Haiyue" <haiyue.wang@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>,
"Ye, Xiaolong" <xiaolong.ye@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [RFC 1/7] net/igc: base driver
Date: Mon, 24 Feb 2020 03:58:16 +0000 [thread overview]
Message-ID: <6CE17E955B70FA409286764E3E0B36411280EEB4@CDSMSX102.ccr.corp.intel.com> (raw)
In-Reply-To: <227edcf2-2365-8f9e-186a-fb00b1a6ae80@intel.com>
Hi Ferruh,
I have add some new features to the module last few weeks, I'm going to resubmit all codes as you suggest.
Thanks very much
BR,
Alvin
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Wednesday, January 22, 2020 12:27 AM
> To: Zhang, AlvinX <alvinx.zhang@intel.com>; Wang, Haiyue
> <haiyue.wang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>; Ye, Xiaolong <xiaolong.ye@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [RFC 1/7] net/igc: base driver
>
> On 1/10/2020 3:00 AM, alvinx.zhang@intel.com wrote:
> > From: Alvin Zhang <alvinx.zhang@intel.com>
> >
> > Add shared code source files to support basic operations to be called
> > in poll mode driver.
> >
> > Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
>
> Hi Alvin,
>
> I would suggest a different organization of the patches.
>
> Currently first patch dumps all shared code, second all the DPDK driver files.
> Later patches does in each patch, Makefile based build system, meson based
> build system and documentation.
>
> First question if all shared code are used, if not please drop the ones that are
> not used as much as possible.
>
> Second please try to split into the logical pieces, like a logical piece can be
> setting MTU (just a sample) and you can put shared code, dpdk code and
> documentation related to it in same patch.
>
> Also can you please start the series with a skeleton, which introduces the
> build system files, configs, Maintainer file update, generic docs. At this stage
> code can be empty, and the driver can be disabled by default.
> And if you have to, second patch can have a minimum required shared code
> drop.
> After this the driver can be built gradually feature by feature, perhaps
> starting from the probe/remove support.
>
> Thanks,
> ferruh
prev parent reply other threads:[~2020-02-24 3:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-10 3:00 alvinx.zhang
2020-01-10 3:00 ` [dpdk-dev] [RFC 2/7] net/igc: igc poll mode driver alvinx.zhang
2020-01-10 3:00 ` [dpdk-dev] [RFC 3/7] drivers/net: add igc make alvinx.zhang
2020-01-21 16:43 ` Ferruh Yigit
2020-02-24 4:06 ` Zhang, AlvinX
2020-01-10 3:00 ` [dpdk-dev] [RFC 4/7] igc: add igc library alvinx.zhang
2020-01-10 3:00 ` [dpdk-dev] [RFC 5/7] drivers/net: add meson build for igc alvinx.zhang
2020-01-10 3:00 ` [dpdk-dev] [RFC 6/7] config/common_base: add igc PMD flags alvinx.zhang
2020-01-10 3:00 ` [dpdk-dev] [RFC 7/7] doc: add igc guide and feature list alvinx.zhang
2020-01-21 16:27 ` [dpdk-dev] [RFC 1/7] net/igc: base driver Ferruh Yigit
2020-02-24 3:58 ` Zhang, AlvinX [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6CE17E955B70FA409286764E3E0B36411280EEB4@CDSMSX102.ccr.corp.intel.com \
--to=alvinx.zhang@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=haiyue.wang@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).