From: "Kovacevic, Marko" <marko.kovacevic@intel.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Cc: "akhil.goyal@nxp.com" <akhil.goyal@nxp.com>
Subject: Re: [dpdk-dev] [PATCH] test/compress: fix size of test buffer
Date: Thu, 24 Jan 2019 18:24:07 +0000 [thread overview]
Message-ID: <6DC05C7C5F25994B81B3F2F214251F6602080A9A@IRSMSX104.ger.corp.intel.com> (raw)
In-Reply-To: <20190124120555.10548-1-marko.kovacevic@intel.com>
> Changed size of test buffer to 100 to allow qat to run compress unit-test,
> qat_comp_process_response():
> QAT intermediate buffer may be too small for output, try configuring a larger
> size
>
> Fixes: c1bbb613ce96 ("test/compress: add out of space test")
> Cc: marko.kovacevic@intel.com
>
> Signed-off-by: Marko Kovacevic <marko.kovacevic@intel.com>
> ---
> test/test/test_compressdev.c | 25 ++++++++++++++++++-------
> 1 file changed, 18 insertions(+), 7 deletions(-)
>
> diff --git a/test/test/test_compressdev.c b/test/test/test_compressdev.c
> index e8476ed..4db65c4 100644
> --- a/test/test/test_compressdev.c
> +++ b/test/test/test_compressdev.c
> @@ -42,7 +42,7 @@
> #define GZIP_HEADER_SIZE 10
> #define GZIP_TRAILER_SIZE 8
>
> -#define OUT_OF_SPACE_BUF 1
> +#define OUT_OF_SPACE_BUF 100
>
> const char *
> huffman_type_strings[] = {
> @@ -597,13 +597,15 @@ prepare_sgl_bufs(const char *test_buf, struct
> rte_mbuf *head_buf,
> uint32_t total_data_size,
> struct rte_mempool *small_mbuf_pool,
> struct rte_mempool *large_mbuf_pool,
> - uint8_t limit_segs_in_sgl)
> + uint8_t limit_segs_in_sgl,
> + const struct test_data_params *test_params)
> {
> uint32_t remaining_data = total_data_size;
> uint16_t num_remaining_segs = DIV_CEIL(remaining_data,
> SMALL_SEG_SIZE);
> struct rte_mempool *pool;
> struct rte_mbuf *next_seg;
> uint32_t data_size;
> + unsigned int out_of_space = test_params->out_of_space;
> char *buf_ptr;
> const char *data_ptr = test_buf;
> uint16_t i;
> @@ -639,6 +641,10 @@ prepare_sgl_bufs(const char *test_buf, struct
> rte_mbuf *head_buf,
> * Allocate the rest of the segments,
> * copy the rest of the data and chain the segments.
> */
> + if (out_of_space)
> + num_remaining_segs = 1;
> +
> +
> for (i = 0; i < num_remaining_segs; i++) {
>
> if (i == (num_remaining_segs - 1)) {
> @@ -647,9 +653,11 @@ prepare_sgl_bufs(const char *test_buf, struct
> rte_mbuf *head_buf,
> pool = large_mbuf_pool;
> else
> pool = small_mbuf_pool;
> - data_size = remaining_data;
> + out_of_space ? data_size = out_of_space :
> + (data_size = remaining_data);
> } else {
> - data_size = SMALL_SEG_SIZE;
> +
> + (data_size = SMALL_SEG_SIZE);
> pool = small_mbuf_pool;
> }
>
> @@ -759,7 +767,8 @@ test_deflate_comp_decomp(const struct
> interim_data_params *int_data,
> data_size,
> ts_params->small_mbuf_pool,
> ts_params->large_mbuf_pool,
> - MAX_SEGS) < 0)
> + MAX_SEGS,
> + test_data) < 0)
> goto exit;
> }
> } else {
> @@ -791,7 +800,8 @@ test_deflate_comp_decomp(const struct
> interim_data_params *int_data,
> data_size,
> ts_params->small_mbuf_pool,
> ts_params->large_mbuf_pool,
> - MAX_SEGS) < 0)
> + MAX_SEGS,
> + test_data) < 0)
> goto exit;
> }
>
> @@ -1019,7 +1029,8 @@ test_deflate_comp_decomp(const struct
> interim_data_params *int_data,
> data_size,
> ts_params->small_mbuf_pool,
> ts_params->large_mbuf_pool,
> - MAX_SEGS) < 0)
> + MAX_SEGS,
> + test_data) < 0)
> goto exit;
> }
>
> --
Self Nack
After some investigation from Pablo and after a conversation was had we have come to the conclusion that there might be an error somewhere else and just a check that needs to be added and that the unit test just exposed it and not that the unit test itself was wrong I can't confirm that as of yet until further investigation is done
next prev parent reply other threads:[~2019-01-24 18:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-24 12:05 Marko Kovacevic
2019-01-24 18:24 ` Kovacevic, Marko [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-01-22 11:17 Marko Kovacevic
2019-01-22 13:43 ` Kovacevic, Marko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6DC05C7C5F25994B81B3F2F214251F6602080A9A@IRSMSX104.ger.corp.intel.com \
--to=marko.kovacevic@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).