From: "David Harton (dharton)" <dharton@cisco.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"wenzhuo.lu@intel.co" <wenzhuo.lu@intel.co>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] ixgbe: initialize scattered_rx during dev_configure
Date: Wed, 23 Aug 2017 12:56:38 +0000 [thread overview]
Message-ID: <6a28e8c0c8a64733a5f1bbbbe22c8c78@XCH-RCD-016.cisco.com> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB977258489B4F98@irsmsx105.ger.corp.intel.com>
> -----Original Message-----
> From: Ananyev, Konstantin [mailto:konstantin.ananyev@intel.com]
> Sent: Wednesday, August 23, 2017 6:32 AM
> To: David Harton (dharton) <dharton@cisco.com>; wenzhuo.lu@intel.co
> Cc: dev@dpdk.org
> Subject: RE: [PATCH] ixgbe: initialize scattered_rx during dev_configure
>
> Hi David,
>
> >
> > An application may want to manipulate the MTU settings of a device
> > without having to start the device first.
> > In order to remove the need to start the device the ixgbe/ixgbevf
> > drivers need to initialize the scattered_rx value during
> > dev_configure.
>
> Not sure how that would help?
> As I can see ixgbe_dev_mtu_set() uses rx_conf->enable_scatter to check is
> multiseg RX allowed or not.
Hi Konstantin,
I see. The problem has been fixed already. Originally (v2.2), the check in ixgbe_dev_mtu_set() was made against dev->data->scattered_rx but it has been changed.
Sorry, I'll rescind the request.
Thanks!
Dave
> Konstantin
>
> >
> > Signed-off-by: David Harton <dharton@cisco.com>
> > ---
> > drivers/net/ixgbe/ixgbe_ethdev.c | 14 ++++++++++++++
> > 1 file changed, 14 insertions(+)
> >
> > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> > b/drivers/net/ixgbe/ixgbe_ethdev.c
> > index 22171d8..e85bdb4 100644
> > --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> > @@ -2372,6 +2372,13 @@ static int eth_ixgbevf_pci_remove(struct
> rte_pci_device *pci_dev)
> > intr->flags |= IXGBE_FLAG_NEED_LINK_UPDATE;
> >
> > /*
> > + * Update scattered_rx so we can update MTU immediately
> > + * following configure without having to start the device
> > + */
> > + if (dev->data->dev_conf.rxmode.enable_scatter)
> > + dev->data->scattered_rx = 1;
> > +
> > + /*
> > * Initialize to TRUE. If any of Rx queues doesn't meet the bulk
> > * allocation or vector Rx preconditions we will reset it.
> > */
> > @@ -4949,6 +4956,13 @@ static int
> > ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev,
> > #endif
> >
> > /*
> > + * Update scattered_rx so we can update MTU immediately
> > + * following configure without having to start the device
> > + */
> > + if (dev->data->dev_conf.rxmode.enable_scatter)
> > + dev->data->scattered_rx = 1;
> > +
> > + /*
> > * Initialize to TRUE. If any of Rx queues doesn't meet the bulk
> > * allocation or vector Rx preconditions we will reset it.
> > */
> > --
> > 1.8.3.1
prev parent reply other threads:[~2017-08-23 12:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 1:33 David Harton
2017-08-23 10:31 ` Ananyev, Konstantin
2017-08-23 12:56 ` David Harton (dharton) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a28e8c0c8a64733a5f1bbbbe22c8c78@XCH-RCD-016.cisco.com \
--to=dharton@cisco.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=wenzhuo.lu@intel.co \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).