From: fengchengwen <fengchengwen@huawei.com>
To: Amit Prakash Shukla <amitprakashs@marvell.com>,
Kevin Laatz <kevin.laatz@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>
Cc: <dev@dpdk.org>, <jerinj@marvell.com>, <vattunuru@marvell.com>,
<ndabilpuram@marvell.com>, <anoobj@marvell.com>,
<mb@smartsharesystems.com>
Subject: Re: [PATCH] lib/dmadev: get DMA device using device ID
Date: Sat, 9 Dec 2023 15:11:34 +0800 [thread overview]
Message-ID: <6a4a2eb0-fb33-ea1c-ee1a-738640f188d7@huawei.com> (raw)
In-Reply-To: <20231208075526.2696553-1-amitprakashs@marvell.com>
Hi Amit,
On 2023/12/8 15:55, Amit Prakash Shukla wrote:
> DMA library has a function to get DMA device based on device name but
> there is no function to get DMA device using device id.
>
> Added a function that lookup for the dma device using device id and
> returns the pointer to the same.
>
> Signed-off-by: Amit Prakash Shukla <amitprakashs@marvell.com>
> ---
> lib/dmadev/rte_dmadev.c | 9 +++++++++
> lib/dmadev/rte_dmadev_pmd.h | 14 ++++++++++++++
> lib/dmadev/version.map | 1 +
> 3 files changed, 24 insertions(+)
>
> diff --git a/lib/dmadev/rte_dmadev.c b/lib/dmadev/rte_dmadev.c
> index 4e5e420c82..83f49e77f2 100644
> --- a/lib/dmadev/rte_dmadev.c
> +++ b/lib/dmadev/rte_dmadev.c
> @@ -397,6 +397,15 @@ rte_dma_is_valid(int16_t dev_id)
> rte_dma_devices[dev_id].state != RTE_DMA_DEV_UNUSED;
> }
>
> +struct rte_dma_dev *
> +rte_dma_pmd_get_dev_by_id(const int dev_id)
> +{
> + if (!rte_dma_is_valid(dev_id))
> + return NULL;
> +
> + return &rte_dma_devices[dev_id];
> +}
> +
> uint16_t
> rte_dma_count_avail(void)
> {
> diff --git a/lib/dmadev/rte_dmadev_pmd.h b/lib/dmadev/rte_dmadev_pmd.h
> index c61cedfb23..f68c3ac6aa 100644
> --- a/lib/dmadev/rte_dmadev_pmd.h
> +++ b/lib/dmadev/rte_dmadev_pmd.h
> @@ -167,6 +167,20 @@ struct rte_dma_dev *rte_dma_pmd_allocate(const char *name, int numa_node,
> __rte_internal
> int rte_dma_pmd_release(const char *name);
>
> +/**
> + * @internal
> + * Get the rte_dma_dev structure device pointer for the device id.
> + *
> + * @param dev_id
> + * Device ID value to select the device structure.
> + *
> + * @return
> + * - rte_dma_dev structure pointer for the given device ID on success, NULL
> + * otherwise.
> + */
> +__rte_internal
> +struct rte_dma_dev *rte_dma_pmd_get_dev_by_id(const int dev_id);
> +
> #ifdef __cplusplus
> }
> #endif
> diff --git a/lib/dmadev/version.map b/lib/dmadev/version.map
> index 2a3736514c..2cd57c43d3 100644
> --- a/lib/dmadev/version.map
> +++ b/lib/dmadev/version.map
> @@ -26,6 +26,7 @@ INTERNAL {
> rte_dma_fp_objs;
> rte_dma_pmd_allocate;
> rte_dma_pmd_release;
> + rte_dma_pmd_get_dev_by_id;
Should arranged alphabetically in version.map
With above fixed
Acked-by: Chengwen Feng <fengchengwen@huawei.com>
Thanks
>
> local: *;
> };
>
next prev parent reply other threads:[~2023-12-09 7:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 7:55 Amit Prakash Shukla
2023-12-09 7:11 ` fengchengwen [this message]
2023-12-18 10:41 ` [EXT] " Amit Prakash Shukla
2023-12-11 10:23 ` Bruce Richardson
2023-12-18 11:27 ` [EXT] " Amit Prakash Shukla
2023-12-19 11:00 ` [PATCH v2] " Amit Prakash Shukla
2024-01-08 14:47 ` Anoob Joseph
2024-02-06 6:24 ` Amit Prakash Shukla
2024-02-08 16:25 ` Thomas Monjalon
2024-02-09 8:18 ` fengchengwen
2024-02-09 11:05 ` [EXT] " Amit Prakash Shukla
2024-02-09 11:18 ` Thomas Monjalon
2024-02-09 11:30 ` Amit Prakash Shukla
2024-02-09 17:36 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a4a2eb0-fb33-ea1c-ee1a-738640f188d7@huawei.com \
--to=fengchengwen@huawei.com \
--cc=amitprakashs@marvell.com \
--cc=anoobj@marvell.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=kevin.laatz@intel.com \
--cc=mb@smartsharesystems.com \
--cc=ndabilpuram@marvell.com \
--cc=vattunuru@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).