From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Alejandro Lucero <alejandro.lucero@netronome.com>, dev@dpdk.org
Cc: stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2 3/5] bus/pci: use IOVAs check when setting IOVA mode
Date: Wed, 3 Oct 2018 13:55:55 +0100 [thread overview]
Message-ID: <6b0b9159-d25b-56aa-0ca0-dd61b5206b04@intel.com> (raw)
In-Reply-To: <1535719857-19092-4-git-send-email-alejandro.lucero@netronome.com>
On 31-Aug-18 1:50 PM, Alejandro Lucero wrote:
> Although VT-d emulation currently only supports 39 bits, it could
> be iovas being within that supported range. This patch allows
> IOVA mode in such a case.
>
> Indeed, memory initialization code can be modified for using lower
> virtual addresses than those used by the kernel for 64 bits processes
> by default, and therefore memsegs iovas can use 39 bits or less for
> most system. And this is likely 100% true for VMs.
>
> Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
> ---
> drivers/bus/pci/linux/pci.c | 15 ++++++++++-----
> 1 file changed, 10 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/bus/pci/linux/pci.c b/drivers/bus/pci/linux/pci.c
> index 04648ac..215dc10 100644
> --- a/drivers/bus/pci/linux/pci.c
> +++ b/drivers/bus/pci/linux/pci.c
> @@ -588,10 +588,11 @@
> fclose(fp);
>
> mgaw = ((vtd_cap_reg & VTD_CAP_MGAW_MASK) >> VTD_CAP_MGAW_SHIFT) + 1;
> - if (mgaw < X86_VA_WIDTH)
> - return false;
>
> - return true;
> + if (!rte_eal_check_dma_mask(mgaw))
> + return true;
> + else
> + return false;
return rte_eal_check_dma_mask(mgaw) == 0; ?
> }
> #elif defined(RTE_ARCH_PPC_64)
> static bool
> @@ -615,13 +616,17 @@
> {
> struct rte_pci_device *dev = NULL;
> struct rte_pci_driver *drv = NULL;
> + int iommu_dma_mask_check_done = 0;
>
> FOREACH_DRIVER_ON_PCIBUS(drv) {
> FOREACH_DEVICE_ON_PCIBUS(dev) {
> if (!rte_pci_match(drv, dev))
> continue;
> - if (!pci_one_device_iommu_support_va(dev))
> - return false;
> + if (!iommu_dma_mask_check_done) {
> + if (!pci_one_device_iommu_support_va(dev))
> + return false;
> + iommu_dma_mask_check_done = 1;
> + }
> }
The commit message doesn't explain why are we only checking a single
device. Indeed, i am not 100% clear as to why, so some explanation in
the commit message and preferably a comment in code would be more than
welcome :)
> }
> return true;
>
--
Thanks,
Anatoly
next prev parent reply other threads:[~2018-10-03 12:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-31 12:50 [dpdk-stable] [PATCH v2 0/5] use IOVAs check based on DMA mask Alejandro Lucero
2018-08-31 12:50 ` [dpdk-stable] [PATCH v2 1/5] mem: add function for checking memsegs IOVAs addresses Alejandro Lucero
2018-10-03 12:43 ` [dpdk-stable] [dpdk-dev] " Burakov, Anatoly
2018-08-31 12:50 ` [dpdk-stable] [PATCH v2 2/5] mem: use address hint for mapping hugepages Alejandro Lucero
2018-10-03 12:50 ` [dpdk-stable] [dpdk-dev] " Burakov, Anatoly
2018-10-04 11:43 ` Alejandro Lucero
2018-10-04 12:08 ` Burakov, Anatoly
2018-10-04 13:15 ` Alejandro Lucero
2018-10-04 15:43 ` Burakov, Anatoly
2018-10-04 17:58 ` Alejandro Lucero
2018-08-31 12:50 ` [dpdk-stable] [PATCH v2 3/5] bus/pci: use IOVAs check when setting IOVA mode Alejandro Lucero
2018-10-03 12:55 ` Burakov, Anatoly [this message]
2018-08-31 12:50 ` [dpdk-stable] [PATCH v2 4/5] net/nfp: check hugepages IOVAs based on DMA mask Alejandro Lucero
2018-08-31 12:50 ` [dpdk-stable] [PATCH v2 5/5] net/nfp: support IOVA VA mode Alejandro Lucero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b0b9159-d25b-56aa-0ca0-dd61b5206b04@intel.com \
--to=anatoly.burakov@intel.com \
--cc=alejandro.lucero@netronome.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).