From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: Stephen Hemminger <stephen@networkplumber.org>,
Alex Kiselev <alex@bisonrouter.com>
Cc: dev@dpdk.org, Keith Wiles <keith.wiles@intel.com>
Subject: Re: [PATCH] net/tap: fix the overflow of the network interface index.
Date: Tue, 4 Oct 2022 17:34:36 +0300 [thread overview]
Message-ID: <6b307778-897c-6bdc-60fd-38c09b5b8e7f@oktetlabs.ru> (raw)
In-Reply-To: <20220721081921.37221f7c@hermes.local>
On 7/21/22 18:19, Stephen Hemminger wrote:
> On Thu, 21 Jul 2022 11:13:01 +0000
> Alex Kiselev <alex@bisonrouter.com> wrote:
>
>> On Linux and most other systems, network interface index is a 32-bit
>> integer. Indexes overflowing the 16-bit integer are frequently seen
>> when used inside a Docker container.
>>
>> Signed-off-by: Alex Kiselev <alex@bisonrouter.com>
>
> Looks good, Linux API is inconsistent in use of signed vs unsigned
> int for the ifindex. But negative values are never used/returned.
>
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
Fixes: 7c25284e30c2 ("net/tap: add netlink back-end for flow API")
Fixes: 2bc06869cd94 ("net/tap: add remote netdevice traffic capture")
Cc: stable@dpdk.org
Applied to dpdk-next-net/main, thanks.
prev parent reply other threads:[~2022-10-04 14:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 11:13 Alex Kiselev
2022-07-21 11:13 ` Alex Kiselev
2022-07-21 15:19 ` Stephen Hemminger
2022-10-04 14:34 ` Andrew Rybchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b307778-897c-6bdc-60fd-38c09b5b8e7f@oktetlabs.ru \
--to=andrew.rybchenko@oktetlabs.ru \
--cc=alex@bisonrouter.com \
--cc=dev@dpdk.org \
--cc=keith.wiles@intel.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).