From: Hemant Agrawal <hemant.agrawal@nxp.com>
To: santosh <santosh.shukla@caviumnetworks.com>,
"olivier.matz@6wind.com" <olivier.matz@6wind.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "thomas@monjalon.net" <thomas@monjalon.net>,
"jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>
Subject: Re: [dpdk-dev] Shared compilation issue - mempool/octeontx: add build and log infrastructure
Date: Mon, 16 Oct 2017 12:18:24 +0530 [thread overview]
Message-ID: <6bda52aa-6084-0db9-d78e-57019c2f1f7b@nxp.com> (raw)
In-Reply-To: <3e228854-d5d4-7dc1-6c25-29de7f6c37c7@caviumnetworks.com>
Hi Santosh,
On 10/14/2017 8:57 PM, santosh wrote:
>
> On Saturday 14 October 2017 11:37 AM, Hemant Agrawal wrote:
>> Santosh/jerin,
>> Your patch "mempool/octeontx: add build and log infrastructure" is causing shared build failure for NXP's patch "event/dpaa2: support event eth adapter", which is still under review.
>> http://dpdk.org/dev/patchwork/patch/30248/
>>
>> In your patch, you have added mempool to be dependent on event, which is not correct.
>>
>> "+DEPDIRS-mempool := bus event"
>
> Yes, Octeontx needed mbox definitions and it was defined at event area.
>
> But You are right that adding event dependency in mempool may create issues
> for future feature like you mentioned.
>
>> Ideally, if you have common code, you should put that in bus or mempool . This way you can make event, net or sec etc dependent on bus or mempool and not the otherway around.
>
> Right.
> Proposed change for makefile will be:
>
> diff --git a/drivers/Makefile b/drivers/Makefile
> index 3a5b22342..0467250aa 100644
> --- a/drivers/Makefile
> +++ b/drivers/Makefile
> @@ -32,13 +32,13 @@
> include $(RTE_SDK)/mk/rte.vars.mk
>
> DIRS-y += bus
> -DIRS-$(CONFIG_RTE_LIBRTE_EVENTDEV) += event
> -DEPDIRS-event := bus
> DIRS-y += mempool
> -DEPDIRS-mempool := bus event
> +DEPDIRS-mempool := bus
> DIRS-y += net
> DEPDIRS-net := bus mempool
> DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += crypto
> DEPDIRS-crypto := bus mempool
> +DIRS-$(CONFIG_RTE_LIBRTE_EVENTDEV) += event
> +DEPDIRS-event := bus mempool
>
> include $(RTE_SDK)/mk/rte.subdir.mk
>
> Can you give it a try and let me know your feedback.
>
This change breaks the octonetx compilation.
You may also have to move the the common code from event to mempool.
Regards,
Hemant
> Thanks.
>
>
next prev parent reply other threads:[~2017-10-16 6:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-14 6:07 Hemant Agrawal
2017-10-14 15:27 ` santosh
2017-10-16 6:48 ` Hemant Agrawal [this message]
2017-10-16 6:50 ` santosh
2017-10-16 13:47 ` santosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6bda52aa-6084-0db9-d78e-57019c2f1f7b@nxp.com \
--to=hemant.agrawal@nxp.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=olivier.matz@6wind.com \
--cc=santosh.shukla@caviumnetworks.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).