From: "Roger B. Melton" <rmelton@cisco.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: Qi Zhang <qi.z.zhang@intel.com>,
konstantin.ananyev@intel.com, jingjing.wu@intel.com,
beilei.xing@intel.com, dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/i40e: fix unexpected mbuf free in vPMD
Date: Tue, 10 Oct 2017 07:47:38 -0400 [thread overview]
Message-ID: <6c3a1cbd-e28a-a9cc-ed46-e08dc03644ce@cisco.com> (raw)
In-Reply-To: <20171010113959.GA40296@bricha3-MOBL3.ger.corp.intel.com>
On 10/10/17 7:39 AM, Bruce Richardson wrote:
> On Tue, Oct 10, 2017 at 07:05:33AM -0400, Roger B. Melton wrote:
>> Hi Bruce,
>>
>> I can. It will take a day or 2 to get the results.
>>
>> Regards,
>> Roger
>>
> Thanks. Keep us posted. We want to ensure we have the best fix possible
> for the issue in this release.
Thanks for finding a better solution ;-). I'll let you know the results
when I have them, just wanted you to know it may take a couple of days
to turn around.
-Roger
>
> /Bruce
>
>> On 10/10/17 4:48 AM, Bruce Richardson wrote:
>>> +Roger Melton
>>>
>>> On Tue, Oct 10, 2017 at 09:22:05AM -0400, Qi Zhang wrote:
>>>> vPMD tx does not set sw_ring's mbuf to NULL after free it.
>>>> So to prevent same mbuf be free again, we need more carefully
>>>> check in i40e_tx_queue_release_mbufs.
>>>>
>>>> Fixes: b4669bb95038 ("i40e: add vector Tx")
>>>> Cc: stable@dpdk.org
>>>>
>>>> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
>>>> ---
>>>> v2:
>>>> - fix at i40e_tx_queue_release_mbufs so no performance impact.
>>>>
>>> This patch also supercedes this one, http://dpdk.org/dev/patchwork/patch/29814/
>>> right?
>>> Roger, can you please confirm that this alternative fix works in your
>>> testing and that your patch is no longer necessary too.
>>>
>>> Thanks,
>>> /Bruce
>>>
>>> .
>>>
> .
>
next prev parent reply other threads:[~2017-10-10 11:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 13:22 [dpdk-stable] " Qi Zhang
2017-10-10 8:48 ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
2017-10-10 11:05 ` Roger B. Melton
2017-10-10 11:39 ` Bruce Richardson
2017-10-10 11:47 ` Roger B. Melton [this message]
2017-10-12 11:15 ` Roger B. Melton
2017-10-12 11:30 ` Richardson, Bruce
2017-10-12 17:28 ` [dpdk-stable] " Ferruh Yigit
-- strict thread matches above, loose matches on Subject: below --
2017-10-09 8:53 Qi Zhang
2017-10-09 12:44 ` [dpdk-stable] [dpdk-dev] " Ananyev, Konstantin
2017-10-09 13:20 ` Bruce Richardson
2017-10-10 1:10 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c3a1cbd-e28a-a9cc-ed46-e08dc03644ce@cisco.com \
--to=rmelton@cisco.com \
--cc=beilei.xing@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).