From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: Olivier Matz <olivier.matz@6wind.com>, dev@dpdk.org
Cc: "Keith Wiles" <keith.wiles@intel.com>,
"Hongzhi Guo" <guohongzhi1@huawei.com>,
"Morten Brørup" <mb@smartsharesystems.com>,
"Thomas Monjalon" <thomas@monjalon.net>,
stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH 2/4] net/tap: fix Rx cksum flags on TCP packets
Date: Tue, 8 Jun 2021 13:18:13 +0300 [thread overview]
Message-ID: <6d54bb29-2acd-463d-a96b-9bdabd97f347@oktetlabs.ru> (raw)
In-Reply-To: <20210427135755.927-3-olivier.matz@6wind.com>
On 4/27/21 4:57 PM, Olivier Matz wrote:
> Since commit d5df2ae0428a ("net: fix unneeded replacement of TCP
> checksum 0"), the functions rte_ipv4_udptcp_cksum() or
> rte_ipv6_udptcp_cksum() can return either 0x0000 or 0xffff when used to
> verify a packet containing a valid checksum.
>
> This new behavior broke the checksum verification in tap driver for TCP
> packets: these packets are marked with PKT_RX_L4_CKSUM_BAD.
>
> Fix this by checking the 2 possible values. A next commit will introduce
> a checksum verification helper to simplify this a bit.
>
> Fixes: d5df2ae0428a ("net: fix unneeded replacement of TCP checksum 0")
> Cc: stable@dpdk.org
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
next prev parent reply other threads:[~2021-06-08 10:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210427135755.927-1-olivier.matz@6wind.com>
2021-04-27 13:57 ` [dpdk-stable] [PATCH 1/4] net/tap: fix Rx cksum flags on IP options packets Olivier Matz
2021-04-30 14:48 ` Ferruh Yigit
2021-06-08 10:13 ` [dpdk-stable] [dpdk-dev] " Andrew Rybchenko
2021-06-08 12:29 ` Olivier Matz
2021-06-08 12:34 ` Andrew Rybchenko
2021-06-08 12:49 ` Olivier Matz
2021-06-08 13:57 ` Andrew Rybchenko
2021-06-08 14:30 ` Olivier Matz
2021-04-27 13:57 ` [dpdk-stable] [PATCH 2/4] net/tap: fix Rx cksum flags on TCP packets Olivier Matz
2021-06-08 10:18 ` Andrew Rybchenko [this message]
[not found] ` <20210630135158.8108-1-olivier.matz@6wind.com>
2021-06-30 13:51 ` [dpdk-stable] [PATCH v2 1/4] net/tap: fix Rx cksum flags on IP options packets Olivier Matz
2021-06-30 13:51 ` [dpdk-stable] [PATCH v2 2/4] net/tap: fix Rx cksum flags on TCP packets Olivier Matz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d54bb29-2acd-463d-a96b-9bdabd97f347@oktetlabs.ru \
--to=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=guohongzhi1@huawei.com \
--cc=keith.wiles@intel.com \
--cc=mb@smartsharesystems.com \
--cc=olivier.matz@6wind.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).