From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Nirmoy Das <ndas@suse.de>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] kni: define HAVE_VF_VLAN_PROTO for SLES12SP3
Date: Tue, 4 Apr 2017 14:43:52 +0100 [thread overview]
Message-ID: <6d6af113-0133-c938-a8ba-c636303b628d@intel.com> (raw)
In-Reply-To: <20170404131948.13899-1-ndas@suse.de>
On 4/4/2017 2:19 PM, Nirmoy Das wrote:
> Add support for SLES12SP3, which uses kernel 4.4,
> but backported features from newer kernels.
>
> Signed-off-by: Nirmoy Das <ndas@suse.de>
> ---
> lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h b/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h
> index 84826b26e..173599ccd 100644
> --- a/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h
> +++ b/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h
> @@ -710,6 +710,9 @@ struct _kc_ethtool_pauseparam {
> #elif ( LINUX_VERSION_CODE >= KERNEL_VERSION(3,12,28) )
> /* SLES12 is at least 3.12.28+ based */
> #define SLE_VERSION_CODE SLE_VERSION(12,0,0)
> +#elif (LINUX_VERSION_CODE >= KERNEL_VERSION(4, 4, 57))
> +/* SLES12SP3 is at least 4.4.57+ based */
> +#define SLE_VERSION_CODE SLE_VERSION(12, 3, 0)
> #endif /* LINUX_VERSION_CODE == KERNEL_VERSION(x,y,z) */
> #endif /* CONFIG_SUSE_KERNEL */
> #ifndef SLE_VERSION_CODE
> @@ -3929,8 +3932,10 @@ skb_set_hash(struct sk_buff *skb, __u32 hash, __always_unused int type)
> #define vlan_tx_tag_present skb_vlan_tag_present
> #endif
>
> -#if ( LINUX_VERSION_CODE >= KERNEL_VERSION(4,9,0) )
> +#if ((LINUX_VERSION_CODE >= KERNEL_VERSION(4, 9, 0)) \
> + || (defined(SLE_VERSION_CODE) && \
> + (SLE_VERSION_CODE >= SLE_VERSION(12, 3, 0))))
> #define HAVE_VF_VLAN_PROTO
> -#endif /* >= 4.9.0 */
> +#endif /* >= 4.9.0, >= SLES12SP3 */
Is it possible to use SLE_VERSION_CODE check same as rest of the document?:
(SLE_VERSION_CODE && SLE_VERSION_CODE >= SLE_VERSION(12, 3, 0))
#if ((LINUX_VERSION_CODE >= KERNEL_VERSION(4, 9, 0)) || \
(SLE_VERSION_CODE && SLE_VERSION_CODE >= SLE_VERSION(12, 3, 0)))
#define HAVE_VF_VLAN_PROTO
#endif /* >= 4.9.0, >= SLES12SP3 */
>
> #endif /* _KCOMPAT_H_ */
>
next prev parent reply other threads:[~2017-04-04 13:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-04 13:19 Nirmoy Das
2017-04-04 13:43 ` Ferruh Yigit [this message]
2017-04-04 14:16 ` [dpdk-dev] [PATCH v3] " Nirmoy Das
2017-04-04 14:46 ` Ferruh Yigit
2017-04-04 15:12 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d6af113-0133-c938-a8ba-c636303b628d@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=ndas@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).