From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Jin Yu <jin.yu@intel.com>, tiwei.bie@intel.com
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH v2] vhost: fix compile error
Date: Wed, 6 Nov 2019 20:59:57 +0100 [thread overview]
Message-ID: <6dae0e7b-08f5-a427-725b-604a86f87107@redhat.com> (raw)
In-Reply-To: <20191030094055.37889-1-jin.yu@intel.com>
Hi Jin,
On 10/30/19 10:40 AM, Jin Yu wrote:
> Compile librte_vhost/vhost_crypto.c needs the rte_hash.h
> So we need the librte_hash to be compiled before vhost.
> Add the DEPDIRs to make sure this.
>
> Bugzilla ID: 356
> Fixes: 939066d96563 ("vhost/crypto: add public function implementation")
> Cc: stable@dpdk.org
>
> Signed-off-by: Jin Yu <jin.yu@intel.com>
> ---
> V2 - add the librte_crytodev
> ---
> lib/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/Makefile b/lib/Makefile
> index 41c463d92..b2a143d4f 100644
> --- a/lib/Makefile
> +++ b/lib/Makefile
> @@ -46,7 +46,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_RAWDEV) += librte_rawdev
> DEPDIRS-librte_rawdev := librte_eal librte_ethdev
> DIRS-$(CONFIG_RTE_LIBRTE_VHOST) += librte_vhost
> DEPDIRS-librte_vhost := librte_eal librte_mempool librte_mbuf librte_ethdev \
> - librte_net
> + librte_net librte_hash librte_cryptodev
> DIRS-$(CONFIG_RTE_LIBRTE_HASH) += librte_hash
> DEPDIRS-librte_hash := librte_eal librte_ring
> DIRS-$(CONFIG_RTE_LIBRTE_EFD) += librte_efd
>
http://mails.dpdk.org/archives/test-report/2019-October/105347.html
The Intel compilation reports a breakage with this patch, and the
breakage happens in some crypto drivers. Could you please check it
is not a regression due to your patch?
*Make Build Failed #1:
OS: CENTOS76-64
Target: x86_64-native-linuxapp-clang
CC zlib_pmd.o.pmd.o
LD qat_device.o
LD zlib_pmd.o
CC hw_atl_utils_fw2x.o
1 error generated.
make[6]: *** [dpaa2_sec_dpseci.o] Error 1
make[5]: *** [dpaa2_sec] Error 2
make[5]: *** Waiting for unfinished jobs....
CC hw_atl_b0.o
CC qat_logs.o
CC zlib_pmd_ops.o
CC rte_pmd_atlantic.o
--
CC axgbe_rxtx_vec_sse.o
AR librte_pmd_octeontx_crypto.a
AR librte_pmd_bond.a
INSTALL-LIB librte_pmd_octeontx_crypto.a
INSTALL-LIB librte_pmd_bond.a
make[4]: *** [crypto] Error 2
make[4]: *** Waiting for unfinished jobs....
CC dpaa2_mux.o
== Build drivers/net/ena
CC dpaa2_sparser.o
CC mc/dpni.o
--
CC hunt_nic.o
CC medford_nic.o
CC medford2_nic.o
AR librte_pmd_sfc_efx.a
INSTALL-LIB librte_pmd_sfc_efx.a
make[3]: *** [drivers] Error 2
make[2]: *** [all] Error 2
make[1]: *** [pre_install] Error 2
make: *** [install] Error 2
next prev parent reply other threads:[~2019-11-06 20:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 10:34 [dpdk-stable] [PATCH] " Jin Yu
2019-10-29 13:35 ` Tiwei Bie
2019-10-30 1:41 ` Yu, Jin
2019-10-30 9:37 ` Jin Yu
2019-10-30 9:40 ` [dpdk-stable] [PATCH v2] " Jin Yu
2019-11-04 4:41 ` Tiwei Bie
2019-11-06 19:52 ` Maxime Coquelin
2019-11-06 19:59 ` Maxime Coquelin [this message]
2019-11-06 20:05 ` David Marchand
2019-11-06 20:30 ` Maxime Coquelin
2019-11-06 20:59 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6dae0e7b-08f5-a427-725b-604a86f87107@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=jin.yu@intel.com \
--cc=stable@dpdk.org \
--cc=tiwei.bie@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).