From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>, dev@dpdk.org
Cc: Ivan Malov <ivan.malov@oktetlabs.ru>, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] net/sfc: add device state check to reta update operation
Date: Tue, 3 Oct 2017 23:04:11 +0100 [thread overview]
Message-ID: <6db7ff3a-25cc-fdfc-14a6-a3f8e3b9f1b2@intel.com> (raw)
In-Reply-To: <1507016634-6298-1-git-send-email-arybchenko@solarflare.com>
On 10/3/2017 8:43 AM, Andrew Rybchenko wrote:
> From: Ivan Malov <ivan.malov@oktetlabs.ru>
>
> The callback must not attempt to program RSS table to the HW
> in non-started state; the new table must be remembered and
> applied on the next start
>
> Fixes: 32bcfb0a50b1 ("net/sfc: update RSS redirection table")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> Reviewed-by: Andy Moreton <amoreton@solarflare.com>
> ---
> drivers/net/sfc/sfc_ethdev.c | 13 +++++++++----
> 1 file changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c
> index 9e65b6a..8650f87 100644
> --- a/drivers/net/sfc/sfc_ethdev.c
> +++ b/drivers/net/sfc/sfc_ethdev.c
> @@ -1399,11 +1399,16 @@ sfc_dev_rss_reta_update(struct rte_eth_dev *dev,
> }
> }
>
> - rc = efx_rx_scale_tbl_set(sa->nic, EFX_RSS_CONTEXT_DEFAULT,
> - rss_tbl_new, EFX_RSS_TBL_SIZE);
> - if (rc == 0)
> - rte_memcpy(sa->rss_tbl, rss_tbl_new, sizeof(sa->rss_tbl));
> + if (sa->state == SFC_ADAPTER_STARTED) {
This is causing a build error with clang:
.../dpdk/drivers/net/sfc/sfc_ethdev.c:1402:6: error: variable 'rc' is
used uninitialized whenever 'if' condition is false
[-Werror,-Wsometimes-uninitialized]
if (sa->state == SFC_ADAPTER_STARTED) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
.../dpdk/drivers/net/sfc/sfc_ethdev.c:1418:10: note: uninitialized use
occurs here
return -rc;
^~
.../dpdk/drivers/net/sfc/sfc_ethdev.c:1402:2: note: remove the 'if' if
its condition is always true
if (sa->state == SFC_ADAPTER_STARTED) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
.../dpdk/drivers/net/sfc/sfc_ethdev.c:1357:8: note: initialize the
variable 'rc' to silence this warning
int rc;
^
= 0
> + rc = efx_rx_scale_tbl_set(sa->nic, EFX_RSS_CONTEXT_DEFAULT,
> + rss_tbl_new, EFX_RSS_TBL_SIZE);
> + if (rc != 0)
> + goto fail_scale_tbl_set;
> + }
> +
> + rte_memcpy(sa->rss_tbl, rss_tbl_new, sizeof(sa->rss_tbl));
>
> +fail_scale_tbl_set:
> bad_reta_entry:
> sfc_adapter_unlock(sa);
>
>
prev parent reply other threads:[~2017-10-03 22:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-03 7:43 Andrew Rybchenko
2017-10-03 22:04 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6db7ff3a-25cc-fdfc-14a6-a3f8e3b9f1b2@intel.com \
--to=ferruh.yigit@intel.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ivan.malov@oktetlabs.ru \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).