From: "Tan, Jianfeng" <jianfeng.tan@intel.com>
To: Olivier Matz <olivier.matz@6wind.com>, dev@dpdk.org
Cc: Anatoly Burakov <anatoly.burakov@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3 3/5] eal: set name when creating a control thread
Date: Fri, 27 Apr 2018 23:46:45 +0800 [thread overview]
Message-ID: <6de0fd38-b674-3f90-7cd0-098e4ae0ee21@intel.com> (raw)
In-Reply-To: <20180424144651.13145-4-olivier.matz@6wind.com>
Hi Olivier,
After this patch, I find the two IPC threads block at
pthread_barrier_wait(), and never wake up. Please refer below for more
information. The system is Ubuntu 16.04.
On 4/24/2018 10:46 PM, Olivier Matz wrote:
> To avoid code duplication, add a parameter to rte_ctrl_thread_create()
> to specify the name of the thread.
>
> This requires to add a wrapper for the thread start routine in
> rte_thread_init(), which will first wait that the thread is configured.
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> ---
> drivers/net/kni/rte_eth_kni.c | 3 +-
> lib/librte_eal/common/eal_common_proc.c | 15 +++-----
> lib/librte_eal/common/eal_common_thread.c | 52 +++++++++++++++++++++++++---
> lib/librte_eal/common/include/rte_lcore.h | 7 ++--
> lib/librte_eal/linuxapp/eal/eal_interrupts.c | 13 ++-----
> lib/librte_eal/linuxapp/eal/eal_timer.c | 12 +------
> lib/librte_vhost/socket.c | 25 +++----------
> 7 files changed, 66 insertions(+), 61 deletions(-)
[...]
> diff --git a/lib/librte_eal/common/eal_common_thread.c b/lib/librte_eal/common/eal_common_thread.c
> index efbccddbc..94d2a6e42 100644
> --- a/lib/librte_eal/common/eal_common_thread.c
> +++ b/lib/librte_eal/common/eal_common_thread.c
> @@ -7,6 +7,7 @@
> #include <stdint.h>
> #include <unistd.h>
> #include <pthread.h>
> +#include <signal.h>
> #include <sched.h>
> #include <assert.h>
> #include <string.h>
> @@ -141,10 +142,53 @@ eal_thread_dump_affinity(char *str, unsigned size)
> return ret;
> }
>
> +
> +struct rte_thread_ctrl_params {
> + void *(*start_routine)(void *);
> + void *arg;
> + pthread_barrier_t configured;
> +};
> +
> +static void *rte_thread_init(void *arg)
> +{
> + struct rte_thread_ctrl_params *params = arg;
> + void *(*start_routine)(void *) = params->start_routine;
> + void *routine_arg = params->arg;
> +
> + pthread_barrier_wait(¶ms->configured);
This thread never wakes up. The call trace as below:
#0 0x00007ffff72a8154 in futex_wait (private=0, expected=0,
futex_word=0x7fffffffcff4)
at ../sysdeps/unix/sysv/linux/futex-internal.h:61
#1 futex_wait_simple (private=0, expected=0, futex_word=0x7fffffffcff4)
at ../sysdeps/nptl/futex-internal.h:135
#2 __pthread_barrier_wait (barrier=0x7fffffffcff0) at
pthread_barrier_wait.c:184
#3 0x000000000055216a in rte_thread_init (arg=0x7fffffffcfe0) at
/home/tan/git/dpdk/lib/librte_eal/common/eal_common_thread.c:160
#4 0x00007ffff72a16ba in start_thread (arg=0x7ffff6ecf700) at
pthread_create.c:333
#5 0x00007ffff6fd741d in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:109
> +
> + return start_routine(routine_arg);
> +}
> +
> __rte_experimental int
> -rte_ctrl_thread_create(pthread_t *thread,
> - const pthread_attr_t *attr,
> - void *(*start_routine)(void *), void *arg)
> +rte_ctrl_thread_create(pthread_t *thread, const char *name,
> + const pthread_attr_t *attr,
> + void *(*start_routine)(void *), void *arg)
> {
> - return pthread_create(thread, attr, start_routine, arg);
> + struct rte_thread_ctrl_params params = {
> + .start_routine = start_routine,
> + .arg = arg,
> + };
> + int ret;
> +
> + pthread_barrier_init(¶ms.configured, NULL, 2);
> +
> + ret = pthread_create(thread, attr, rte_thread_init, (void *)¶ms);
> + if (ret != 0)
> + return ret;
> +
> + if (name != NULL) {
> + ret = rte_thread_setname(*thread, name);
> + if (ret < 0)
> + goto fail;
> + }
> +
> + pthread_barrier_wait(¶ms.configured);
Here, the thread wakes up normally, and continues.
Any idea on what's going on?
Thanks,
Jianfeng
> +
> + return 0;
> +
> +fail:
> + pthread_cancel(*thread);
> + pthread_join(*thread, NULL);
> + return ret;
> }
next prev parent reply other threads:[~2018-04-27 15:46 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-03 13:04 [dpdk-dev] [PATCH v2 0/4] fix control thread affinities Olivier Matz
2018-04-03 13:04 ` [dpdk-dev] [PATCH v2 1/4] eal: use sizeof to avoid a double use of a define Olivier Matz
2018-04-10 16:18 ` Burakov, Anatoly
2018-04-03 13:04 ` [dpdk-dev] [PATCH v2 2/4] eal: new function to create control threads Olivier Matz
2018-04-10 16:18 ` Burakov, Anatoly
2018-04-03 13:04 ` [dpdk-dev] [PATCH v2 3/4] eal: set name when creating a control thread Olivier Matz
2018-04-10 16:34 ` Burakov, Anatoly
2018-04-23 12:49 ` Olivier Matz
2018-04-17 22:32 ` Thomas Monjalon
2018-04-23 12:52 ` Olivier Matz
2018-04-03 13:04 ` [dpdk-dev] [PATCH v2 4/4] eal: set affinity for control threads Olivier Matz
2018-04-10 16:18 ` Burakov, Anatoly
2018-04-03 13:13 ` [dpdk-dev] [PATCH v2 0/4] fix control thread affinities Olivier Matz
2018-04-10 16:20 ` Burakov, Anatoly
2018-04-24 14:46 ` [dpdk-dev] [PATCH v3 0/5] " Olivier Matz
2018-04-24 14:46 ` [dpdk-dev] [PATCH v3 1/5] eal: use sizeof to avoid a double use of a define Olivier Matz
2018-04-24 14:46 ` [dpdk-dev] [PATCH v3 2/5] eal: new function to create control threads Olivier Matz
2018-04-24 14:46 ` [dpdk-dev] [PATCH v3 3/5] eal: set name when creating a control thread Olivier Matz
2018-04-24 16:08 ` Burakov, Anatoly
2018-04-27 15:46 ` Tan, Jianfeng [this message]
2018-04-27 16:17 ` Tan, Jianfeng
2018-04-27 16:46 ` Burakov, Anatoly
2018-04-24 14:46 ` [dpdk-dev] [PATCH v3 4/5] eal: set affinity for control threads Olivier Matz
2018-04-24 14:46 ` [dpdk-dev] [PATCH v3 5/5] examples: use new API to create " Olivier Matz
2018-04-24 22:53 ` [dpdk-dev] [PATCH v3 0/5] fix control thread affinities Thomas Monjalon
2018-04-30 15:45 ` [dpdk-dev] pthread_barrier_deadlock in -rc1 (was: "Re: [PATCH v3 0/5] fix control thread affinities") Maxime Coquelin
2018-04-30 18:46 ` Olivier Matz
2018-05-01 8:59 ` Thomas Monjalon
2018-05-02 8:19 ` [dpdk-dev] pthread_barrier_deadlock in -rc1 Tan, Jianfeng
2018-05-02 8:34 ` Maxime Coquelin
2018-05-02 8:50 ` Tan, Jianfeng
2018-05-02 9:05 ` Maxime Coquelin
2018-05-02 9:20 ` Olivier Matz
2018-05-02 9:32 ` Tan, Jianfeng
2018-05-02 9:41 ` Maxime Coquelin
2018-05-02 9:30 ` Burakov, Anatoly
2018-05-02 9:38 ` Tan, Jianfeng
2018-05-02 9:57 ` Olivier Matz
2018-05-02 10:01 ` Tan, Jianfeng
2018-05-02 10:08 ` Olivier Matz
2018-05-02 10:16 ` Tan, Jianfeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6de0fd38-b674-3f90-7cd0-098e4ae0ee21@intel.com \
--to=jianfeng.tan@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).