From: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, konstantin.ananyev@intel.com, bruce.richardson@intel.com
Subject: Re: [dpdk-dev] [PATCH 1/2] eal/x86: use cpuid builtin
Date: Thu, 24 Aug 2017 09:21:58 +0100 [thread overview]
Message-ID: <6ed25652-da53-139f-37b1-12079f51c95e@intel.com> (raw)
In-Reply-To: <6484062.ssFnLodFTS@xps>
On 23/08/2017 21:49, Thomas Monjalon wrote:
> Please could you explain why the asm code was used?
I guess we were not aware that there was a builtin for it.
> Are you sure this builtin is implemented everywhere?
>
Actually the builtin used in this patch is not supported in most CLANG
version (just recently merged upstream),
so I have reworked the patch to use builtin supported in both GCC and
CLANG 3.4+.
Thanks,
Sergio
prev parent reply other threads:[~2017-08-24 8:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 12:42 Sergio Gonzalez Monroy
2017-08-23 12:42 ` [dpdk-dev] [PATCH 2/2] eal/x86: implement x86 specific tsc hz Sergio Gonzalez Monroy
2017-08-23 13:17 ` Bruce Richardson
2017-08-23 13:57 ` Sergio Gonzalez Monroy
2017-08-23 14:03 ` Bruce Richardson
2017-08-23 20:49 ` [dpdk-dev] [PATCH 1/2] eal/x86: use cpuid builtin Thomas Monjalon
2017-08-24 8:21 ` Sergio Gonzalez Monroy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ed25652-da53-139f-37b1-12079f51c95e@intel.com \
--to=sergio.gonzalez.monroy@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).