From: Shreyansh Jain <shreyansh.jain@nxp.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] eal: add Bus log type
Date: Sun, 2 Jul 2017 11:01:41 +0530 [thread overview]
Message-ID: <6f67d562-e9e3-5a17-84d3-9685dad7b701@nxp.com> (raw)
In-Reply-To: <4669455.PggrvpOhcS@xps>
On Tuesday 20 June 2017 02:24 AM, Thomas Monjalon wrote:
> 19/06/2017 13:03, Shreyansh Jain:
>>> --- a/lib/librte_eal/common/include/rte_log.h
>>> +++ b/lib/librte_eal/common/include/rte_log.h
>>> @@ -87,6 +87,7 @@ extern struct rte_logs rte_logs;
>>> #define RTE_LOGTYPE_CRYPTODEV 17 /**< Log related to cryptodev. */
>>> #define RTE_LOGTYPE_EFD 18 /**< Log related to EFD. */
>>> #define RTE_LOGTYPE_EVENTDEV 19 /**< Log related to eventdev. */
>>> +#define RTE_LOGTYPE_BUS 20 /**< Log related to Bus. */
>>
>> Just wanted to ping - is there something wrong/unacceptable about this?
>
> Sorry for not replying before.
And I am sorry for spotting your reply so late.
>
> The strange thing is that it is not used.
Yes, because somehow I forgot this while pushing bus/fslmc. I (had (*)) plan to change this for bus/fslmc in subsequent patches.
> At least, the existing bus logs should be converted.
> I've spotted few lines in drivers/bus/fslmc/.
>
> And more importantly, we must switch to the new dynamic types
> using rte_log_register().
>
(*)
ok. In which case, this patch would become redundant. I will add support for this in dpaa (and dpaa2 driver, next).
-
Shreyansh
prev parent reply other threads:[~2017-07-02 5:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-24 5:38 Shreyansh Jain
2017-06-19 11:03 ` Shreyansh Jain
2017-06-19 20:54 ` Thomas Monjalon
2017-07-02 5:31 ` Shreyansh Jain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f67d562-e9e3-5a17-84d3-9685dad7b701@nxp.com \
--to=shreyansh.jain@nxp.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).