From: Iain Barker <iain.barker@oracle.com>
To: "Xing, Beilei" <beilei.xing@intel.com>, users@dpdk.org
Subject: Re: [dpdk-users] VLAN tags always stripped on i40evf [VMware SR-IOV]
Date: Fri, 27 Oct 2017 06:05:35 -0700 (PDT) [thread overview]
Message-ID: <70000a5a-f6e1-4cda-bce0-e80f4e72807f@default> (raw)
In-Reply-To: <94479800C636CB44BD422CB454846E013205FCB4@SHSMSX101.ccr.corp.intel.com>
Original message from Iain Barker:
>
> --- drivers/net/i40e/i40e_rxtx.c.orig 2016-11-30 04:28:48.000000000 -0500
> +++ drivers/net/i40e/i40e_rxtx.c 2017-10-10 15:07:10.851398087 -0400
> @@ -93,6 +93,8 @@
> rte_le_to_cpu_16(rxdp->wb.qword0.lo_dword.l2tag1);
> PMD_RX_LOG(DEBUG, "Descriptor l2tag1: %u",
> rte_le_to_cpu_16(rxdp->wb.qword0.lo_dword.l2tag1));
> + // vlan got stripped. Re-inject vlan from tci
> + rte_vlan_insert(&mb);
> } else {
> mb->vlan_tci = 0;
> }
>
From: Xing, Beilei [mailto:beilei.xing@intel.com] :
>
>NACK this patch as it will impact performance.
>
>VLAN strip is supported by latest i40e kernel driver, it works well in kernel PF +
>DPDK VF mode with i40e kernel driver 2.1.26 and DPDK 17.08. Please refer to
>Latest kernel driver.
>
>Beilei
Thanks Beilei.
I wasn't proposing to submit the patch. I was just using it as a demonstration of the problem.
i.e. that the TCI has the required data, but it was stripped before the frame arrives at the app.
This is not Linux kernel as the host for PF, it is VMware ESXi.
The latest Intel PF driver I see for i40e is version 2.0.6. Will that work?
prev parent reply other threads:[~2017-10-27 13:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 13:48 Iain Barker
2017-10-11 13:19 ` Iain Barker
2017-10-27 2:23 ` Xing, Beilei
2017-10-27 13:05 ` Iain Barker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70000a5a-f6e1-4cda-bce0-e80f4e72807f@default \
--to=iain.barker@oracle.com \
--cc=beilei.xing@intel.com \
--cc=users@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).