From: "Hunt, David" <david.hunt@intel.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4 1/6] lib: distributor performance enhancements
Date: Thu, 19 Jan 2017 12:07:41 +0000 [thread overview]
Message-ID: <70254cc9-2f57-00f0-cde0-bbf0200cb370@intel.com> (raw)
In-Reply-To: <20170116163654.GA26296@bricha3-MOBL3.ger.corp.intel.com>
Thanks for the comments Bruce. Addressed below.
On 16/1/2017 4:36 PM, Bruce Richardson wrote:
> On Mon, Jan 09, 2017 at 07:50:43AM +0000, David Hunt wrote:
>> Now sends bursts of up to 8 mbufs to each worker, and tracks
>> the in-flight flow-ids (atomic scheduling)
>>
>> New file with a new api, similar to the old API except with _burst
>> at the end of the function names
>>
> Can you explain why this is necessary, and also how the new version
> works compared to the old. I know this is explained in the cover letter,
> but the cover letter does not make the git commit log.
Sure. I'll add extra comments into the git comment. The main reason is to
preserve the original API. This gives the user the choice to migrate to
the new
API should they wish to.
>> Signed-off-by: David Hunt <david.hunt@intel.com>
>> ---
> <snip>
>> diff --git a/lib/librte_distributor/rte_distributor_burst.c
>> b/lib/librte_distributor/rte_distributor_burst.c
>> new file mode 100644
>> index 0000000..ae7cf9d
>> --- /dev/null
>> +++ b/lib/librte_distributor/rte_distributor_burst.c
>> @@ -0,0 +1,558 @@
>> +/*-
>> + * BSD LICENSE
>> + *
>> + * Copyright(c) 2016 Intel Corporation. All rights reserved.
> Update year since we aren't in 2016 any more.
>
>> + *
>> + * Redistribution and use in source and binary forms, with or without
>> + * modification, are permitted provided that the following conditions
>> + * are met:
>> + *
>> + * * Redistributions of source code must retain the above copyright
>> + * notice, this list of conditions and the following disclaimer.
>> + * * Redistributions in binary form must reproduce the above
>> copyright
>> + * notice, this list of conditions and the following
>> disclaimer in
>> + * the documentation and/or other materials provided with the
>> + * distribution.
>> + * * Neither the name of Intel Corporation nor the names of its
>> + * contributors may be used to endorse or promote products
>> derived
>> + * from this software without specific prior written permission.
>> + *
>> + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
>> CONTRIBUTORS
>> + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
>> + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND
>> FITNESS FOR
>> + * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
>> COPYRIGHT
>> + * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
>> INCIDENTAL,
>> + * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
>> + * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
>> OF USE,
>> + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
>> ON ANY
>> + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR
>> TORT
>> + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF
>> THE USE
>> + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH
>> DAMAGE.
>> + */
>> +
>> +#include <stdio.h>
>> +#include <sys/queue.h>
>> +#include <string.h>
>> +#include <rte_mbuf.h>
>> +#include <rte_memory.h>
>> +#include <rte_cycles.h>
>> +#include <rte_memzone.h>
>> +#include <rte_errno.h>
>> +#include <rte_string_fns.h>
>> +#include <rte_eal_memconfig.h>
>> +#include "rte_distributor_priv.h"
>> +#include "rte_distributor_burst.h"
>> +
>> +TAILQ_HEAD(rte_dist_burst_list, rte_distributor_burst);
>> +
>> +static struct rte_tailq_elem rte_dist_burst_tailq = {
>> + .name = "RTE_DIST_BURST",
>> +};
>> +EAL_REGISTER_TAILQ(rte_dist_burst_tailq)
>> +
>> +/**** APIs called by workers ****/
>> +
>> +/**** Burst Packet APIs called by workers ****/
>> +
>> +/* This function should really be called return_pkt_burst() */
> 1) Why should it be?
> 2) Why isn't it called that?
> Please explain the naming.
It seemed to me that the main use of this function was to return
the packets from the worker rather than requesting new packets,
whilst also toggling the bit to tell the distributor to send more packets.
So I guess it's OK as it is. I've removed the comment to remove this
confusion.
>> +void
>> +rte_distributor_request_pkt_burst(struct rte_distributor_burst *d,
>> + unsigned int worker_id, struct rte_mbuf **oldpkt,
>> + unsigned int count)
>> +{
>> + struct rte_distributor_buffer_burst *buf = &(d->bufs[worker_id]);
>> + unsigned int i;
>> +
>> + volatile int64_t *retptr64;
>> +
>> +
>> + /* if we dont' have any packets to return, return. */
>> + if (count == 0)
>> + return;
>> +
> So if we don't return anything we don't get any more packets, right?
> What happens if we return fewer packets than we were previously given?
> If that is allowed, why the restriction on returning at least one?
You are correct. We should be able to return 0, and still flip the
handshake
bit to request more packets. This check will be removed.
>> + retptr64 = &(buf->retptr64[0]);
> <snip>
>> +
>> +int
>> +rte_distributor_get_pkt_burst(struct rte_distributor_burst *d,
>> + unsigned int worker_id, struct rte_mbuf **pkts,
>> + struct rte_mbuf **oldpkt, unsigned int return_count)
>> +{
>> + unsigned int count;
>> + uint64_t retries = 0;
>> +
>> + rte_distributor_request_pkt_burst(d, worker_id, oldpkt,
>> return_count);
>> +
>> + count = rte_distributor_poll_pkt_burst(d, worker_id, pkts);
>> + while (count == 0) {
>> + rte_pause();
>> + retries++;
>> + if (retries > 1000)
>> + return 0;
> This behaviour is different to the original get_pkt() behaviour in that
> it has a timeout. Why the change to add the timeout, and should the
> timeout not be user configurable in some way?
I had another look at this, and managed to clean up this logic. There is
no longer a need for the retry.
In the old logic, the poll_pkt function returned a pointer, or NULL when
the handshake bit was not ready.
In the new logic, up until now, I had similar logic, but return 0 for
both the case where the bit was not ready,
and the bit was ready and the number of valid pointers was 0. This meant
that there was no way for the loop
to break out when the application was exiting or flushing. I've now
introduced a -1 return when the bit
is not ready, so will continue looping. But when the distributor sets
the bot with no packets, the poll_pkt
function will return 0, allowing the loop to exit and return to the caller.
Thanks for that comment, Bruce, it's fixed a major shortcoming in the
logic.
>> +
>> + uint64_t t = rte_rdtsc()+100;
> need spaces around the "+"
Done
>> +
>> + while (rte_rdtsc() < t)
>> + rte_pause();
>> +
>> + count = rte_distributor_poll_pkt_burst(d, worker_id, pkts);
>> + }
>> + return count;
>> +}
>> +
>> +int
>> +rte_distributor_return_pkt_burst(struct rte_distributor_burst *d,
>> + unsigned int worker_id, struct rte_mbuf **oldpkt, int num)
>> +{
>> + struct rte_distributor_buffer_burst *buf = &d->bufs[worker_id];
>> + unsigned int i;
>> +
>> + for (i = 0; i < RTE_DIST_BURST_SIZE; i++)
>> + /* Switch off the return bit first */
>> + buf->retptr64[i] &= ~RTE_DISTRIB_RETURN_BUF;
>> +
>> + for (i = num; i-- > 0; )
>> + buf->retptr64[i] = (((int64_t)(uintptr_t)oldpkt[i]) <<
>> + RTE_DISTRIB_FLAG_BITS) | RTE_DISTRIB_RETURN_BUF;
>> +
>> + /* set the GET_BUF but even if we got no returns */
>> + buf->retptr64[0] |= RTE_DISTRIB_GET_BUF;
> Does this mean we are requesting more packets here?
No, we're setting retptr which means that the distributor will start
processing the returns cacheline.
The only way to request more packets is
buf->bufptr64[0] |= RTE_DISTRIB_GET_BUF;
This is usually called when you are shutting down a thread and want to
return what you have, and not
request any new packets from the distributor.
>
>> +
>> + return 0;
>> +}
>> +
>> +/**** APIs called on distributor core ***/
>> +
> <snip>
>> +
>> +static unsigned int
>> +release(struct rte_distributor_burst *d, unsigned int wkr)
> I think this function needs a comment describing what it is doing,
> and where is it called from and why. Other functions on distributor side
> probably need the same thing too.
Done.
>> +{
>> + struct rte_distributor_buffer_burst *buf = &(d->bufs[wkr]);
>> + unsigned int i;
>> +
>> + if (d->backlog[wkr].count == 0)
>> + return 0;
>> +
>> + while (!(d->bufs[wkr].bufptr64[0] & RTE_DISTRIB_GET_BUF))
>> + rte_pause();
>> +
>> + handle_returns(d, wkr);
>> +
>> + buf->count = 0;
>> +
>> + for (i = 0; i < d->backlog[wkr].count; i++) {
>> + d->bufs[wkr].bufptr64[i] = d->backlog[wkr].pkts[i] |
>> + RTE_DISTRIB_GET_BUF | RTE_DISTRIB_VALID_BUF;
>> + d->in_flight_tags[wkr][i] = d->backlog[wkr].tags[i];
>> + }
>> + buf->count = i;
>> + for ( ; i < RTE_DIST_BURST_SIZE ; i++) {
>> + buf->bufptr64[i] = RTE_DISTRIB_GET_BUF;
>> + d->in_flight_tags[wkr][i] = 0;
>> + }
>> +
>> + d->backlog[wkr].count = 0;
>> +
>> + /* Clear the GET bit */
>> + buf->bufptr64[0] &= ~RTE_DISTRIB_GET_BUF;
>> + return buf->count;
>> +
>> +}
> <snip>
>> +/**
>> + * API called by a worker to get new packets to process. Any
>> previous packets
>> + * given to the worker is assumed to have completed processing, and
>> may be
>> + * optionally returned to the distributor via the oldpkt parameter.
>> + *
>> + * @param d
>> + * The distributor instance to be used
>> + * @param worker_id
>> + * The worker instance number to use - must be less that
>> num_workers passed
>> + * at distributor creation time.
>> + * @param pkts
>> + * The mbufs pointer array to be filled in (up to 8 packets)
>> + * @param oldpkt
>> + * The previous packet, if any, being processed by the worker
>> + * @param retcount
>> + * The number of packets being returneda
> I think you need to document that it can't be zero, if I read the above
> C implementation correctly.
Can be zero now, after resolving some issues indicated above. We should
be able to return zero
to indicated that we've processed all in the burst but are not returning
any (i.e. drop)
>> + *
>> + * @return
>> + * The number of packets in the pkts array
>> + */
>> +int
>> +rte_distributor_get_pkt_burst(struct rte_distributor_burst *d,
>> + unsigned int worker_id, struct rte_mbuf **pkts,
>> + struct rte_mbuf **oldpkt, unsigned int retcount);
>> +
>> +/**
> <snip>
>> +
>> +/**
>> + * Number of packets to deal with in bursts. Needs to be 8 so as to
>> + * fit in one cache line.
>> + */
>> +#define RTE_DIST_BURST_SIZE (sizeof(__m128i) / sizeof(uint16_t))
> Does this compile for non-x86 with the references to __m128i?
Changed to rte_xmm_t
>> +
> <snip>
>> +
>> + struct rte_distributor_returned_pkts returns;
>> +};
>> +
>> +/* All different signature compare functions */
>> +enum rte_distributor_match_function {
>> + RTE_DIST_MATCH_SCALAR = 0,
>> + RTE_DIST_MATCH_NUM
> I think this last entry should be "RTE_DIST_NUM_MATCH_FNS", as
> "NUM" is not a match function, and the define doesn't ready right.
Done.
>> +};
>> +
>> +struct rte_distributor_burst {
>> + TAILQ_ENTRY(rte_distributor_burst) next; /**< Next in list. */
>> +
>> + char name[RTE_DISTRIBUTOR_NAMESIZE]; /**< Name of the ring. */
>> + unsigned int num_workers; /**< Number of workers
>> polling */
>> +
>> + /**>
>> + * First cache line in the this array are the tags inflight
>> + * on the worker core. Second cache line are the backlog
>> + * that are going to go to the worker core.
>> + */
>> + uint16_t
>> in_flight_tags[RTE_DISTRIB_MAX_WORKERS][RTE_DIST_BURST_SIZE*2]
>> + __rte_cache_aligned;
>> +
>> + struct rte_distributor_backlog backlog[RTE_DISTRIB_MAX_WORKERS]
>> + __rte_cache_aligned;
>> +
>> + struct rte_distributor_buffer_burst bufs[RTE_DISTRIB_MAX_WORKERS];
>> +
>> + struct rte_distributor_returned_pkts returns;
>> +
>> + enum rte_distributor_match_function dist_match_fn;
>> +};
>> +
>> +#ifdef __cplusplus
>> +}
>> +#endif
>> +
>> +#endif
>> diff --git a/lib/librte_distributor/rte_distributor_version.map
>> b/lib/librte_distributor/rte_distributor_version.map
>> index 73fdc43..39795a1 100644
>> --- a/lib/librte_distributor/rte_distributor_version.map
>> +++ b/lib/librte_distributor/rte_distributor_version.map
>> @@ -2,14 +2,23 @@ DPDK_2.0 {
>> global:
>> rte_distributor_clear_returns;
>> + rte_distributor_clear_returns_burst;
>> rte_distributor_create;
>> + rte_distributor_create_burst;
>> rte_distributor_flush;
>> + rte_distributor_flush_burst;
>> rte_distributor_get_pkt;
>> + rte_distributor_get_pkt_burst;
>> rte_distributor_poll_pkt;
>> + rte_distributor_poll_pkt_burst;
>> rte_distributor_process;
>> + rte_distributor_process_burst;
>> rte_distributor_request_pkt;
>> + rte_distributor_request_pkt_burst;
>> rte_distributor_return_pkt;
>> + rte_distributor_return_pkt_burst;
>> rte_distributor_returned_pkts;
>> + rte_distributor_returned_pkts_burst;
>> local: *;
>> };
> The new functions are not present in DPDK 2.0, so you need a new node
> for the 17.02 release.
Sure.
> Regards,
> /Bruce
>
Thanks Bruce. I'll get a new revision up later today.
Regards,
Dave.
next prev parent reply other threads:[~2017-01-19 12:07 UTC|newest]
Thread overview: 202+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-01 4:50 [dpdk-dev] [PATCH v1 1/2] distributor lib " David Hunt
2016-12-01 4:50 ` [dpdk-dev] [PATCH v1 1/2] lib: distributor " David Hunt
2016-12-22 4:37 ` [dpdk-dev] [PATCH v2 0/5] distributor library " David Hunt
2016-12-22 4:37 ` [dpdk-dev] [PATCH v2 1/5] lib: distributor " David Hunt
2016-12-22 12:47 ` Jerin Jacob
2016-12-22 16:14 ` Hunt, David
2017-01-02 10:22 ` [dpdk-dev] [WARNING: A/V UNSCANNABLE][PATCH v3 0/6] distributor-performance-improvements David Hunt
2017-01-02 10:22 ` [dpdk-dev] [WARNING: A/V UNSCANNABLE][PATCH v3 1/6] lib: distributor performance enhancements David Hunt
2017-01-02 10:22 ` [dpdk-dev] [WARNING: A/V UNSCANNABLE][PATCH v3 2/6] lib: add distributor vector flow matching David Hunt
2017-01-02 10:22 ` [dpdk-dev] [WARNING: A/V UNSCANNABLE][PATCH v3 3/6] test: unit tests for new distributor burst api David Hunt
2017-01-02 10:22 ` [dpdk-dev] [WARNING: A/V UNSCANNABLE][PATCH v3 4/6] test: add distributor_perf autotest David Hunt
2017-01-02 10:22 ` [dpdk-dev] [WARNING: A/V UNSCANNABLE][PATCH v3 5/6] example: distributor app showing burst api David Hunt
2017-01-02 10:22 ` [dpdk-dev] [WARNING: A/V UNSCANNABLE][PATCH v3 6/6] doc: distributor library changes for new " David Hunt
2017-01-09 7:50 ` [dpdk-dev] [PATCH v4 0/6] distributor library performance enhancements David Hunt
2017-01-09 7:50 ` [dpdk-dev] [PATCH v4 1/6] lib: distributor " David Hunt
2017-01-13 15:19 ` Bruce Richardson
2017-01-19 14:58 ` Hunt, David
2017-01-16 16:36 ` Bruce Richardson
2017-01-19 12:07 ` Hunt, David [this message]
2017-01-20 9:18 ` [dpdk-dev] [PATCH v5 0/6] distributor library " David Hunt
2017-01-20 9:18 ` [dpdk-dev] [PATCH v5 1/6] lib: distributor " David Hunt
2017-01-23 9:24 ` [dpdk-dev] [PATCH v6 0/6] distributor library " David Hunt
2017-01-23 9:24 ` [dpdk-dev] [PATCH v6 1/6] lib: distributor " David Hunt
2017-02-21 3:17 ` [dpdk-dev] [PATCH v7 0/17] distributor library " David Hunt
2017-02-21 3:17 ` [dpdk-dev] [PATCH v7 01/17] lib: rename legacy distributor lib files David Hunt
2017-02-21 10:27 ` Hunt, David
2017-02-24 14:03 ` Bruce Richardson
2017-03-01 9:55 ` Hunt, David
2017-03-01 7:47 ` [dpdk-dev] [PATCH v8 0/18] distributor library performance enhancements David Hunt
2017-03-01 7:47 ` [dpdk-dev] [PATCH v8 01/18] lib: rename legacy distributor lib files David Hunt
2017-03-06 9:10 ` [dpdk-dev] [PATCH v9 00/18] distributor lib performance enhancements David Hunt
2017-03-06 9:10 ` [dpdk-dev] [PATCH v9 01/18] lib: rename legacy distributor lib files David Hunt
2017-03-15 6:19 ` [dpdk-dev] [PATCH v10 0/18] distributor library performance enhancements David Hunt
2017-03-15 6:19 ` [dpdk-dev] [PATCH v10 01/18] lib: rename legacy distributor lib files David Hunt
2017-03-20 10:08 ` [dpdk-dev] [PATCH v11 0/18] distributor lib performance enhancements David Hunt
2017-03-20 10:08 ` [dpdk-dev] [PATCH v11 01/18] lib: rename legacy distributor lib files David Hunt
2017-03-20 10:08 ` [dpdk-dev] [PATCH v11 02/18] lib: create private header file David Hunt
2017-03-20 10:08 ` [dpdk-dev] [PATCH v11 03/18] lib: add new distributor code David Hunt
2017-03-20 10:08 ` [dpdk-dev] [PATCH v11 04/18] lib: add SIMD flow matching to distributor David Hunt
2017-03-20 10:08 ` [dpdk-dev] [PATCH v11 05/18] test/distributor: extra params for autotests David Hunt
2017-03-20 10:08 ` [dpdk-dev] [PATCH v11 06/18] lib: switch distributor over to new API David Hunt
2017-03-20 10:08 ` [dpdk-dev] [PATCH v11 07/18] lib: make v20 header file private David Hunt
2017-03-27 13:10 ` Thomas Monjalon
2017-03-28 8:47 ` Hunt, David
2017-03-20 10:08 ` [dpdk-dev] [PATCH v11 08/18] lib: add symbol versioning to distributor David Hunt
2017-03-27 13:02 ` Thomas Monjalon
2017-03-28 8:25 ` Hunt, David
2017-03-20 10:08 ` [dpdk-dev] [PATCH v11 09/18] test: test single and burst distributor API David Hunt
2017-03-20 10:08 ` [dpdk-dev] [PATCH v11 10/18] test: add perf test for distributor burst mode David Hunt
2017-03-20 10:08 ` [dpdk-dev] [PATCH v11 11/18] examples/distributor: allow for extra stats David Hunt
2017-03-20 10:08 ` [dpdk-dev] [PATCH v11 12/18] examples/distributor: wait for ports to come up David Hunt
2017-03-20 10:08 ` [dpdk-dev] [PATCH v11 13/18] examples/distributor: add dedicated core for dist David Hunt
2017-03-20 10:08 ` [dpdk-dev] [PATCH v11 14/18] examples/distributor: tweaks for performance David Hunt
2017-03-27 13:04 ` Thomas Monjalon
2017-03-28 8:45 ` Hunt, David
2017-03-20 10:08 ` [dpdk-dev] [PATCH v11 15/18] examples/distributor: give Rx thread a core David Hunt
2017-03-20 10:08 ` [dpdk-dev] [PATCH v11 16/18] doc: distributor library changes for new burst API David Hunt
2017-03-24 14:49 ` Mcnamara, John
2017-03-20 10:08 ` [dpdk-dev] [PATCH v11 17/18] doc: distributor app " David Hunt
2017-03-20 10:08 ` [dpdk-dev] [PATCH v11 18/18] maintainers: add to distributor lib maintainers David Hunt
2017-03-27 13:06 ` [dpdk-dev] [PATCH v11 0/18] distributor lib performance enhancements Thomas Monjalon
2017-03-29 14:48 ` Thomas Monjalon
2017-03-15 6:19 ` [dpdk-dev] [PATCH v10 02/18] lib: create private header file David Hunt
2017-03-15 17:18 ` Thomas Monjalon
2017-03-16 10:43 ` Hunt, David
2017-03-16 15:40 ` Thomas Monjalon
2017-03-15 6:19 ` [dpdk-dev] [PATCH v10 03/18] lib: add new distributor code David Hunt
2017-03-15 6:19 ` [dpdk-dev] [PATCH v10 04/18] lib: add SIMD flow matching to distributor David Hunt
2017-03-15 6:19 ` [dpdk-dev] [PATCH v10 05/18] test/distributor: extra params for autotests David Hunt
2017-03-15 6:19 ` [dpdk-dev] [PATCH v10 06/18] lib: switch distributor over to new API David Hunt
2017-03-15 6:19 ` [dpdk-dev] [PATCH v10 07/18] lib: make v20 header file private David Hunt
2017-03-15 6:19 ` [dpdk-dev] [PATCH v10 08/18] lib: add symbol versioning to distributor David Hunt
2017-03-15 6:19 ` [dpdk-dev] [PATCH v10 09/18] test: test single and burst distributor API David Hunt
2017-03-15 6:19 ` [dpdk-dev] [PATCH v10 10/18] test: add perf test for distributor burst mode David Hunt
2017-03-15 6:19 ` [dpdk-dev] [PATCH v10 11/18] examples/distributor: allow for extra stats David Hunt
2017-03-15 6:19 ` [dpdk-dev] [PATCH v10 12/18] examples/distributor: wait for ports to come up David Hunt
2017-03-15 6:19 ` [dpdk-dev] [PATCH v10 13/18] examples/distributor: add dedicated core for dist David Hunt
2017-03-15 6:19 ` [dpdk-dev] [PATCH v10 14/18] examples/distributor: tweaks for performance David Hunt
2017-03-15 6:19 ` [dpdk-dev] [PATCH v10 15/18] examples/distributor: give Rx thread a core David Hunt
2017-03-15 6:19 ` [dpdk-dev] [PATCH v10 16/18] doc: distributor library changes for new burst API David Hunt
2017-03-15 6:19 ` [dpdk-dev] [PATCH v10 17/18] doc: distributor app " David Hunt
2017-03-15 6:19 ` [dpdk-dev] [PATCH v10 18/18] maintainers: add to distributor lib maintainers David Hunt
2017-03-06 9:10 ` [dpdk-dev] [PATCH v9 02/18] lib: create private header file David Hunt
2017-03-06 9:10 ` [dpdk-dev] [PATCH v9 03/18] lib: add new burst oriented distributor structs David Hunt
2017-03-06 9:10 ` [dpdk-dev] [PATCH v9 04/18] lib: add new distributor code David Hunt
2017-03-10 16:03 ` Bruce Richardson
2017-03-14 10:43 ` Hunt, David
2017-03-06 9:10 ` [dpdk-dev] [PATCH v9 05/18] lib: add SIMD flow matching to distributor David Hunt
2017-03-06 9:10 ` [dpdk-dev] [PATCH v9 06/18] test/distributor: extra params for autotests David Hunt
2017-03-06 9:10 ` [dpdk-dev] [PATCH v9 07/18] lib: switch distributor over to new API David Hunt
2017-03-06 9:10 ` [dpdk-dev] [PATCH v9 08/18] lib: make v20 header file private David Hunt
2017-03-06 9:10 ` [dpdk-dev] [PATCH v9 09/18] lib: add symbol versioning to distributor David Hunt
2017-03-10 16:22 ` Bruce Richardson
2017-03-13 10:17 ` Hunt, David
2017-03-13 10:28 ` Hunt, David
2017-03-13 11:01 ` Van Haaren, Harry
2017-03-13 11:02 ` Hunt, David
2017-03-06 9:10 ` [dpdk-dev] [PATCH v9 10/18] test: test single and burst distributor API David Hunt
2017-03-06 9:10 ` [dpdk-dev] [PATCH v9 11/18] test: add perf test for distributor burst mode David Hunt
2017-03-06 9:10 ` [dpdk-dev] [PATCH v9 12/18] examples/distributor: allow for extra stats David Hunt
2017-03-10 16:46 ` Bruce Richardson
2017-03-14 10:44 ` Hunt, David
2017-03-06 9:10 ` [dpdk-dev] [PATCH v9 13/18] sample: distributor: wait for ports to come up David Hunt
2017-03-10 16:48 ` Bruce Richardson
2017-03-06 9:10 ` [dpdk-dev] [PATCH v9 14/18] examples/distributor: give distributor a core David Hunt
2017-03-10 16:49 ` Bruce Richardson
2017-03-14 10:48 ` Hunt, David
2017-03-06 9:10 ` [dpdk-dev] [PATCH v9 15/18] examples/distributor: limit number of Tx rings David Hunt
2017-03-10 16:50 ` Bruce Richardson
2017-03-14 10:50 ` Hunt, David
2017-03-06 9:10 ` [dpdk-dev] [PATCH v9 16/18] examples/distributor: give Rx thread a core David Hunt
2017-03-10 16:51 ` Bruce Richardson
2017-03-14 9:34 ` Hunt, David
2017-03-06 9:10 ` [dpdk-dev] [PATCH v9 17/18] doc: distributor library changes for new burst API David Hunt
2017-03-07 17:25 ` Mcnamara, John
2017-03-06 9:10 ` [dpdk-dev] [PATCH v9 18/18] maintainers: add to distributor lib maintainers David Hunt
2017-03-10 16:54 ` [dpdk-dev] [PATCH v9 00/18] distributor lib performance enhancements Bruce Richardson
2017-03-01 7:47 ` [dpdk-dev] [PATCH v8 02/18] lib: create private header file David Hunt
2017-03-01 7:47 ` [dpdk-dev] [PATCH v8 03/18] lib: add new burst oriented distributor structs David Hunt
2017-03-01 7:47 ` [dpdk-dev] [PATCH v8 04/18] lib: add new distributor code David Hunt
2017-03-01 7:47 ` [dpdk-dev] [PATCH v8 05/18] lib: add SIMD flow matching to distributor David Hunt
2017-03-01 7:47 ` [dpdk-dev] [PATCH v8 06/18] test/distributor: extra params for autotests David Hunt
2017-03-01 7:47 ` [dpdk-dev] [PATCH v8 07/18] lib: switch distributor over to new API David Hunt
2017-03-01 7:47 ` [dpdk-dev] [PATCH v8 08/18] lib: make v20 header file private David Hunt
2017-03-01 7:47 ` [dpdk-dev] [PATCH v8 09/18] lib: add symbol versioning to distributor David Hunt
2017-03-01 14:50 ` Hunt, David
2017-03-01 7:47 ` [dpdk-dev] [PATCH v8 10/18] test: test single and burst distributor API David Hunt
2017-03-01 7:47 ` [dpdk-dev] [PATCH v8 11/18] test: add perf test for distributor burst mode David Hunt
2017-03-01 7:47 ` [dpdk-dev] [PATCH v8 12/18] examples/distributor: allow for extra stats David Hunt
2017-03-01 7:47 ` [dpdk-dev] [PATCH v8 13/18] sample: distributor: wait for ports to come up David Hunt
2017-03-01 7:47 ` [dpdk-dev] [PATCH v8 14/18] examples/distributor: give distributor a core David Hunt
2017-03-01 7:47 ` [dpdk-dev] [PATCH v8 15/18] examples/distributor: limit number of Tx rings David Hunt
2017-03-01 7:47 ` [dpdk-dev] [PATCH v8 16/18] examples/distributor: give Rx thread a core David Hunt
2017-03-01 7:47 ` [dpdk-dev] [PATCH v8 17/18] doc: distributor library changes for new burst API David Hunt
2017-03-01 7:47 ` [dpdk-dev] [PATCH v8 18/18] maintainers: add to distributor lib maintainers David Hunt
2017-02-21 3:17 ` [dpdk-dev] [PATCH v7 02/17] lib: symbol versioning of functions in distributor David Hunt
2017-02-24 14:05 ` Bruce Richardson
2017-02-21 3:17 ` [dpdk-dev] [PATCH v7 03/17] lib: create rte_distributor_private.h David Hunt
2017-02-24 14:07 ` Bruce Richardson
2017-02-21 3:17 ` [dpdk-dev] [PATCH v7 04/17] lib: add new burst oriented distributor structs David Hunt
2017-02-24 14:08 ` Bruce Richardson
2017-03-01 9:57 ` Hunt, David
2017-02-24 14:09 ` Bruce Richardson
2017-03-01 9:58 ` Hunt, David
2017-02-21 3:17 ` [dpdk-dev] [PATCH v7 05/17] lib: add new distributor code David Hunt
2017-02-24 14:11 ` Bruce Richardson
2017-02-21 3:17 ` [dpdk-dev] [PATCH v7 06/17] lib: add SIMD flow matching to distributor David Hunt
2017-02-24 14:11 ` Bruce Richardson
2017-02-21 3:17 ` [dpdk-dev] [PATCH v7 07/17] lib: apply symbol versioning to distibutor lib David Hunt
2017-02-21 11:50 ` Hunt, David
2017-02-24 14:12 ` Bruce Richardson
2017-02-21 3:17 ` [dpdk-dev] [PATCH v7 08/17] test: change params to distributor autotest David Hunt
2017-02-24 14:14 ` Bruce Richardson
2017-03-01 10:06 ` Hunt, David
2017-02-21 3:17 ` [dpdk-dev] [PATCH v7 09/17] test: switch distributor test over to burst API David Hunt
2017-02-21 3:17 ` [dpdk-dev] [PATCH v7 10/17] test: test single and burst distributor API David Hunt
2017-02-21 3:17 ` [dpdk-dev] [PATCH v7 11/17] test: add perf test for distributor burst mode David Hunt
2017-02-21 3:17 ` [dpdk-dev] [PATCH v7 12/17] example: add extra stats to distributor sample David Hunt
2017-02-24 14:16 ` Bruce Richardson
2017-02-21 3:17 ` [dpdk-dev] [PATCH v7 13/17] sample: distributor: wait for ports to come up David Hunt
2017-02-21 3:17 ` [dpdk-dev] [PATCH v7 14/17] sample: switch to new distributor API David Hunt
2017-02-24 14:16 ` Bruce Richardson
2017-02-21 3:17 ` [dpdk-dev] [PATCH v7 15/17] lib: make v20 header file private David Hunt
2017-02-24 14:18 ` Bruce Richardson
2017-02-21 3:17 ` [dpdk-dev] [PATCH v7 16/17] doc: distributor library changes for new burst api David Hunt
2017-02-21 16:18 ` Mcnamara, John
2017-02-21 3:17 ` [dpdk-dev] [PATCH v7 17/17] maintainers: add to distributor lib maintainers David Hunt
2017-02-24 14:01 ` [dpdk-dev] [PATCH v7 0/17] distributor library performance enhancements Bruce Richardson
2017-01-23 9:24 ` [dpdk-dev] [PATCH v6 2/6] lib: add distributor vector flow matching David Hunt
2017-01-23 9:24 ` [dpdk-dev] [PATCH v6 3/6] test: unit tests for new distributor burst API David Hunt
2017-01-23 9:24 ` [dpdk-dev] [PATCH v6 4/6] test: add distributor perf autotest David Hunt
2017-01-23 9:24 ` [dpdk-dev] [PATCH v6 5/6] examples/distributor_app: showing burst API David Hunt
2017-01-23 9:24 ` [dpdk-dev] [PATCH v6 6/6] doc: distributor library changes for new " David Hunt
2017-01-23 17:02 ` [dpdk-dev] [PATCH v6 0/6] distributor library performance enhancements Bruce Richardson
2017-01-24 8:56 ` Liu, Yong
2017-01-23 12:26 ` [dpdk-dev] [PATCH v5 1/6] lib: distributor " Bruce Richardson
2017-01-20 9:18 ` [dpdk-dev] [PATCH v5 2/6] lib: add distributor vector flow matching David Hunt
2017-01-20 9:18 ` [dpdk-dev] [PATCH v5 3/6] test: unit tests for new distributor burst API David Hunt
2017-01-20 9:18 ` [dpdk-dev] [PATCH v5 4/6] test: add distributor perf autotest David Hunt
2017-01-20 9:18 ` [dpdk-dev] [PATCH v5 5/6] examples/distributor_app: showing burst API David Hunt
2017-01-23 12:31 ` Bruce Richardson
2017-01-20 9:18 ` [dpdk-dev] [PATCH v5 6/6] doc: distributor library changes for new " David Hunt
2017-01-09 7:50 ` [dpdk-dev] [PATCH v4 2/6] lib: add distributor vector flow matching David Hunt
2017-01-13 15:26 ` Bruce Richardson
2017-01-19 14:59 ` Hunt, David
2017-01-16 16:40 ` Bruce Richardson
2017-01-19 12:11 ` Hunt, David
2017-01-09 7:50 ` [dpdk-dev] [PATCH v4 3/6] test: unit tests for new distributor burst api David Hunt
2017-01-13 15:33 ` Bruce Richardson
2017-01-09 7:50 ` [dpdk-dev] [PATCH v4 4/6] test: add distributor_perf autotest David Hunt
2017-01-09 7:50 ` [dpdk-dev] [PATCH v4 5/6] example: distributor app showing burst api David Hunt
2017-01-13 15:36 ` Bruce Richardson
2017-01-13 15:38 ` Bruce Richardson
2017-01-09 7:50 ` [dpdk-dev] [PATCH v4 6/6] doc: distributor library changes for new " David Hunt
2016-12-22 4:37 ` [dpdk-dev] [PATCH v2 2/5] test: unit tests for new distributor " David Hunt
2016-12-22 4:37 ` [dpdk-dev] [PATCH v2 3/5] test: add distributor_perf autotest David Hunt
2016-12-22 12:19 ` Jerin Jacob
2017-01-02 16:24 ` Hunt, David
2017-01-04 13:09 ` Jerin Jacob
2016-12-22 4:37 ` [dpdk-dev] [PATCH v2 4/5] example: distributor app showing burst api David Hunt
2016-12-22 4:37 ` [dpdk-dev] [PATCH v2 5/5] doc: distributor library changes for new " David Hunt
2016-12-01 4:50 ` [dpdk-dev] [PATCH v1 2/2] example: distributor app modified to use burstAPI David Hunt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70254cc9-2f57-00f0-cde0-bbf0200cb370@intel.com \
--to=david.hunt@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).