From: "Wiles, Keith" <keith.wiles@intel.com>
To: Matan Azrad <matan@mellanox.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>,
"jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/2] eal: add API to align integer to previous power of 2
Date: Mon, 19 Feb 2018 14:21:43 +0000 [thread overview]
Message-ID: <705E16BA-30AC-4306-B801-EDB06D810185@intel.com> (raw)
In-Reply-To: <AM4PR0501MB2657824F8F77CC4D17352153D2C80@AM4PR0501MB2657.eurprd05.prod.outlook.com>
> On Feb 19, 2018, at 8:13 AM, Matan Azrad <matan@mellanox.com> wrote:
>
> Hi Wiles
>
> From: Wiles, Keith, Monday, February 19, 2018 3:56 PM
>>> On Feb 19, 2018, at 12:03 AM, Matan Azrad <matan@mellanox.com> wrote:
>>>> Is this the type of API that needs to be marked experimental,
>>>
>>> I think it is relevant to any exposed API(not only for internal libraries).
>>>
>>>> we should be able to prove these functions, correct?
>>>
>>> Don't we need to prove any function in DPDK?
>>> What is your point?
>>
>>
>> My point is this is a inline function and can not be placed in the .map file as a
>> external API.
>
> Doesn't each API in .h file external? Why not?
> If it shouldn't be external and should be in .h file, I think it should be marked as internal, no?
We do not do a great job of using private headers as most of our headers are public ones and in the case or private they would not be external.
>
>> These simple type of APIs are easy to prove and making them
>> experimental seems to just cause an extra step.
>
> As Thomas mentioned here:
> https://dpdk.org/ml/archives/dev/2018-January/087719.html
>
> Any new API should be experimental.
>
> Thomas, Is it different for .h file inline APIs?
>
>> If the functions are not required that is a different problem or if the API is really only ever used by a
>> single function or module of files then it should be moved to the module/file
>> and made locate to the module/file.
>
> Agree.
> Looks like this function makes sense and may be used by other modules later.
>
Regards,
Keith
next prev parent reply other threads:[~2018-02-19 14:21 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-17 10:49 Pavan Nikhilesh
2018-02-17 10:49 ` [dpdk-dev] [PATCH 2/2] test: update common auto test Pavan Nikhilesh
2018-02-18 6:11 ` [dpdk-dev] [PATCH 1/2] eal: add API to align integer to previous power of 2 Matan Azrad
2018-02-18 15:39 ` Wiles, Keith
2018-02-19 6:03 ` Matan Azrad
2018-02-19 13:55 ` Wiles, Keith
2018-02-19 14:13 ` Matan Azrad
2018-02-19 14:21 ` Wiles, Keith [this message]
2018-02-19 16:18 ` Thomas Monjalon
2018-02-19 8:36 ` Pavan Nikhilesh
2018-02-19 11:36 ` [dpdk-dev] [PATCH v2 " Pavan Nikhilesh
2018-02-19 11:36 ` [dpdk-dev] [PATCH v2 2/2] test: update common auto test Pavan Nikhilesh
2018-02-19 12:09 ` [dpdk-dev] [PATCH v2 1/2] eal: add API to align integer to previous power of 2 Matan Azrad
2018-02-26 19:10 ` Pavan Nikhilesh
2018-02-27 19:30 ` Matan Azrad
2018-04-04 10:16 ` [dpdk-dev] [PATCH v3 " Pavan Nikhilesh
2018-04-04 10:16 ` [dpdk-dev] [PATCH v3 2/2] test: update common auto test Pavan Nikhilesh
2018-04-04 12:49 ` Thomas Monjalon
2018-04-04 12:54 ` Pavan Nikhilesh
2018-04-04 16:10 ` [dpdk-dev] [PATCH v3 1/2] eal: add API to align integer to previous power of 2 Matan Azrad
2018-04-04 16:42 ` Pavan Nikhilesh
2018-04-04 17:11 ` Matan Azrad
2018-04-04 17:51 ` Pavan Nikhilesh
2018-04-04 18:10 ` Matan Azrad
2018-04-04 18:15 ` Pavan Nikhilesh
2018-04-04 18:23 ` Matan Azrad
2018-04-04 18:36 ` Pavan Nikhilesh
2018-04-04 19:41 ` Matan Azrad
2018-04-04 13:20 ` [dpdk-dev] [PATCH v4] " Pavan Nikhilesh
2018-04-04 15:23 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=705E16BA-30AC-4306-B801-EDB06D810185@intel.com \
--to=keith.wiles@intel.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=matan@mellanox.com \
--cc=pbhagavatula@caviumnetworks.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).