From: "Roger B. Melton" <rmelton@cisco.com>
To: jingjing.wu@intel.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/i40e: Improve i40evf buffer cleanup in tx vector mode
Date: Thu, 5 Oct 2017 19:42:53 -0400 [thread overview]
Message-ID: <7098ec62-43ed-51c8-6711-a57cb92277d7@cisco.com> (raw)
In-Reply-To: <20171005191111.27557-1-rmelton@cisco.com>
Hi Everyone,
As soon as I submitted the patch, I realized I neglected to signoff.
What's the recommended procedure, resubmit the original signed off, or
bump to v1?
Thanks,
Roger
On 10/5/17 3:11 PM, Roger B Melton wrote:
> ---
>
> i40evf tx vector logic frees mbufs, but it does not remove the
> mbufs from software rings which leads to double frees. This change
> corrects that oversight. We've validated this fix within our application.
>
> drivers/net/i40e/i40e_rxtx_vec_common.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/i40e/i40e_rxtx_vec_common.h b/drivers/net/i40e/i40e_rxtx_vec_common.h
> index 39a6da0..fdc6fce 100644
> --- a/drivers/net/i40e/i40e_rxtx_vec_common.h
> +++ b/drivers/net/i40e/i40e_rxtx_vec_common.h
> @@ -127,6 +127,7 @@ i40e_tx_free_bufs(struct i40e_tx_queue *txq)
> if (likely(m != NULL)) {
> free[0] = m;
> nb_free = 1;
> + txep[0].mbuf = NULL;
> for (i = 1; i < n; i++) {
> m = rte_pktmbuf_prefree_seg(txep[i].mbuf);
> if (likely(m != NULL)) {
> @@ -139,14 +140,17 @@ i40e_tx_free_bufs(struct i40e_tx_queue *txq)
> free[0] = m;
> nb_free = 1;
> }
> + txep[i].mbuf = NULL;
> }
> }
> rte_mempool_put_bulk(free[0]->pool, (void **)free, nb_free);
> } else {
> + txep[0].mbuf = NULL;
> for (i = 1; i < n; i++) {
> m = rte_pktmbuf_prefree_seg(txep[i].mbuf);
> if (m != NULL)
> rte_mempool_put(m->pool, m);
> + txep[i].mbuf = NULL;
> }
> }
>
next prev parent reply other threads:[~2017-10-05 23:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 19:11 Roger B Melton
2017-10-05 23:42 ` Roger B. Melton [this message]
2017-10-06 0:33 ` Ferruh Yigit
2017-10-06 8:54 ` Bruce Richardson
2017-10-06 12:38 ` Roger B. Melton
2017-10-06 13:51 ` Bruce Richardson
2017-10-06 14:06 ` Roger B. Melton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7098ec62-43ed-51c8-6711-a57cb92277d7@cisco.com \
--to=rmelton@cisco.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).