From: "Legacy, Allain" <Allain.Legacy@windriver.com>
To: "YIGIT, FERRUH" <ferruh.yigit@intel.com>,
"ZHANG, HELIN" <helin.zhang@intel.com>,
"WU, JINGJING" <jingjing.wu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Peters, Matt" <Matt.Peters@windriver.com>
Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: mbuf alloc failed counter not incremented
Date: Mon, 24 Apr 2017 11:21:35 +0000 [thread overview]
Message-ID: <70A7408C6E1BFB41B192A929744D85239690E942@ALA-MBC.corp.ad.wrs.com> (raw)
In-Reply-To: <fc7fa349-d9b8-1330-b175-ec861a223bc7@intel.com>
> -----Original Message-----
> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
> Sent: Monday, April 24, 2017 1:47 AM
<...>
> > nmb = rte_mbuf_raw_alloc(rxq->mp);
> > - if (unlikely(!nmb))
> > + if (unlikely(!nmb)) {
> > + PMD_RX_LOG(DEBUG, "RX mbuf alloc failed
> port_id=%u "
> > + "queue_id=%u", (unsigned int)rxq-
> >port_id,
> > + (unsigned int)rxq->queue_id);
>
> Do we really want debug print here?
> When you think the speeds we are dealing with, if mbuf alloc starts failing we
> may hit this lines millions per second, which may make app unusable?
>
Sure, but isn't that the purpose of the PMD_RX_LOG/PMD_TX_LOG (i.e., to make it possible to log events in the rx/tx path when that becomes necessary)? Presumably, this would be a debug option only when necessary during development and not used to debug an issue live while the application needs to be useable/responsive.
next prev parent reply other threads:[~2017-04-24 11:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-27 16:30 [dpdk-dev] [PATCH] " Allain Legacy
2017-03-28 8:52 ` Zhang, Helin
2017-03-29 22:42 ` Legacy, Allain
2017-04-21 23:13 ` [dpdk-dev] [PATCH v2] " Allain Legacy
2017-04-24 5:46 ` Ferruh Yigit
2017-04-24 11:21 ` Legacy, Allain [this message]
2017-04-25 11:01 ` Zhang, Helin
2017-04-25 12:28 ` [dpdk-dev] [PATCH v3] " Allain Legacy
2017-04-25 17:31 ` Zhang, Helin
2017-04-26 8:21 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70A7408C6E1BFB41B192A929744D85239690E942@ALA-MBC.corp.ad.wrs.com \
--to=allain.legacy@windriver.com \
--cc=Matt.Peters@windriver.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=helin.zhang@intel.com \
--cc=jingjing.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).