From: "Legacy, Allain" <Allain.Legacy@windriver.com>
To: "ANANYEV, KONSTANTIN" <konstantin.ananyev@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Osman, Dahir" <Dahir.Osman@windriver.com>
Subject: Re: [dpdk-dev] [PATCH] ip_frag: free mbufs on reassembly table destroy
Date: Mon, 5 Jun 2017 14:49:09 +0000 [thread overview]
Message-ID: <70A7408C6E1BFB41B192A929744D8523969A6AB2@ALA-MBC.corp.ad.wrs.com> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB9772583FB058B4@IRSMSX109.ger.corp.intel.com>
> -----Original Message-----
> From: Ananyev, Konstantin [mailto:konstantin.ananyev@intel.com]
> Sent: Sunday, June 04, 2017 12:21 PM
<..>
> >
> > +/* delete fragmentation table */
> > +void
> > +rte_ip_frag_table_destroy(struct rte_ip_frag_tbl *tbl)
> > +{
> > + uint32_t i;
> > +
> > + for (i = 0; i < tbl->nb_entries; i++)
> > + ip_frag_free_immediate(&tbl->pkt[i]);
>
>
> Looks ok, just one thought: wouldn't it be better(faster) in most cases to
> iterate over lru list?
> I suppose usually we wouldn't have nearly all entries filled in.
> Konstantin
Ok, I will send a v2 patch soon.
next prev parent reply other threads:[~2017-06-05 14:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 17:04 Allain Legacy
2017-06-04 16:20 ` Ananyev, Konstantin
2017-06-05 14:49 ` Legacy, Allain [this message]
2017-06-05 15:49 ` [dpdk-dev] [PATCH v2] " Allain Legacy
2017-06-05 22:25 ` Ananyev, Konstantin
2017-06-22 15:56 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70A7408C6E1BFB41B192A929744D8523969A6AB2@ALA-MBC.corp.ad.wrs.com \
--to=allain.legacy@windriver.com \
--cc=Dahir.Osman@windriver.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).