From: "Varghese, Vipin" <vipin.varghese@amd.com>
To: fengchengwen <fengchengwen@huawei.com>, dev@dpdk.org
Cc: ferruh.yigit@amd.com, neerav.parikh@amd.com
Subject: Re: [PATCH] app/dma-perf: calrify incorrect NUMA config
Date: Thu, 7 Mar 2024 21:36:26 +0530 [thread overview]
Message-ID: <70c24acc-531b-41db-9ae2-7ec008b6a7a4@amd.com> (raw)
In-Reply-To: <29fd85f4-d8bf-cd4e-f56c-8fd835e97e0e@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 1423 bytes --]
<snipped>
>> - printf("Error: Source or destination numa exceeds the acture numa nodes.\n");
>> + printf("Error: %s numa exceeds the available numa nodes.\n",
>> + (cfg->src_numa_node >= nr_sockets) ? "Source" : "Destination");
Thank you for comments, please find my reasoning as `change is added to
address spelling issue of acture numa to available numa`
> There are three cases to invoking:
> 1) src_numa_node >= nr_sockets
> 2) dst_numa_node >= nr_sockets
> 3) both src_numa_node and dst_numa_node >= nr_sockets
As per my testing, following scenarios are explored
1) if src-numa is incorrect, we get error message as `source is
incorrect numa`
2) if dst-numa is incorrect, we get error message as `destination is
incorrect numa`
3) if both src-numa and dst-numa are incorrect, we get error as `source
is incorrect numa`, fixing source and rerunning `destination is
incorrect numa` (which is expected)
>
> It could cover cases 1&2 in your commit, but could not cover case 3.
I am happy to make changes to reflect the third scenario also. But
please note as shared, the real intention is to fix ` acture numa` to
something meaningful.
> So I think we should keep original implement.
I humbly disagree, based on the explanation as shared above. I can share
v2 patch to address
1. acture numa
2. soruce or destination or src & destination
<snipped>
[-- Attachment #2: Type: text/html, Size: 2605 bytes --]
next prev parent reply other threads:[~2024-03-07 16:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 15:02 Vipin Varghese
2024-03-07 13:19 ` fengchengwen
2024-03-07 16:06 ` Varghese, Vipin [this message]
2024-03-11 6:00 ` [PATCH v2] " Vipin Varghese
2024-03-12 2:10 ` fengchengwen
2024-03-12 3:48 ` Varghese, Vipin
2024-03-13 9:37 ` Konstantin Ananyev
2024-03-20 1:14 ` Varghese, Vipin
2024-03-20 1:40 ` [PATCH v3] " Vipin Varghese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70c24acc-531b-41db-9ae2-7ec008b6a7a4@amd.com \
--to=vipin.varghese@amd.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=ferruh.yigit@amd.com \
--cc=neerav.parikh@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).