DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
	Kirill Rybalchenko <kirill.rybalchenko@intel.com>
Cc: dev@dpdk.org, andrey.chilikin@intel.com, beilei.xing@intel.com,
	jingjing.wu@intel.com
Subject: Re: [dpdk-dev] [PATCH v2 0/2] ethdev: add support for raw flow type for flow director
Date: Thu, 05 Oct 2017 00:42:53 +0200	[thread overview]
Message-ID: <7117136.lgPSGqLcVY@xps> (raw)
In-Reply-To: <acd3ba0d-b813-9c8f-e957-81228abd4d12@intel.com>

04/10/2017 21:47, Ferruh Yigit:
> On 10/4/2017 6:56 PM, Thomas Monjalon wrote:
> > 04/10/2017 19:44, Ferruh Yigit:
> >> On 10/4/2017 5:57 PM, Thomas Monjalon wrote:
> >>> 03/10/2017 21:02, Ferruh Yigit:
> >>>> On 9/20/2017 9:42 AM, Kirill Rybalchenko wrote:
> >>>>> For complex packets use raw flow type with pre-constructed packet buffer
> >>>>> instead of creating a packet internally in PMD.
> >>>
> >>> Sorry for not catching this series before.
> >>>
> >>> As it has been said several times on this mailing list,
> >>> the flow director API is deprecated.
> >>> I think everybody here knows that it is going to be replaced
> >>> by rte_flow.
> >>>
> >>> That's why it does not make sense to extend flow director.
> >>> We are not going to update PMDs to support a new type
> >>> of legacy flow director.
> >>> Please focus your efforts on rte_flow.
> >>
> >> As far as I can see this is not to to extend flow director. But driver
> >> uses this struct and adding a new feature into driver requires update in
> >> this struct.
> >>
> >> I guess idea was for new filter functionalities PMD should use rte_flow,
> >> that is the new shiny method we have, I see the point here. But I don't
> >> see the point of making these structs under use completely immutable.
> > 
> > I don't know what is RTE_ETH_FLOW_RAW.
> > Let's start by explaining it, how it is used by users,
> > and why this struct is needed.
> 
> Let me answer as much as I get from patches, if something is missing or
> wrong Kirill needs to correct it.
> 
> Driver (i40e) works with static pre-defined flow and pctypes. But new
> feature DDP lets loading custom profiles and work with custom and
> perhaps not yet defined flow and pctypes. So there are a few other
> patches to make driver more dynamic.
> 
> For this case I40E_VALID_FLOW() fails with custom flow types, and
> RTE_ETH_FLOW_RAW used as kind of (void *) to be able to work with new
> dynamic types.

So the application could use a new flow type?
If an application has to be modified for this, it can use rte_flow.
Again, no new feature in legacy flow director.

  reply	other threads:[~2017-10-04 22:42 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-24 15:30 [dpdk-dev] [PATCH " Kirill Rybalchenko
2017-08-24 15:30 ` [dpdk-dev] [PATCH 1/2] " Kirill Rybalchenko
2017-09-04 10:35   ` Radu Nicolau
2017-08-24 15:30 ` [dpdk-dev] [PATCH 2/2] net/i40e: " Kirill Rybalchenko
2017-09-04 10:38   ` Radu Nicolau
2017-09-20  8:42 ` [dpdk-dev] [PATCH v2 0/2] ethdev: " Kirill Rybalchenko
2017-09-20  8:42   ` [dpdk-dev] [PATCH v2 1/2] " Kirill Rybalchenko
2017-09-20  8:42   ` [dpdk-dev] [PATCH v2 2/2] net/i40e: " Kirill Rybalchenko
2017-10-03 19:02   ` [dpdk-dev] [PATCH v2 0/2] ethdev: " Ferruh Yigit
2017-10-04 16:57     ` Thomas Monjalon
2017-10-04 17:44       ` Ferruh Yigit
2017-10-04 17:56         ` Thomas Monjalon
2017-10-04 19:47           ` Ferruh Yigit
2017-10-04 22:42             ` Thomas Monjalon [this message]
2017-10-05  9:09             ` Rybalchenko, Kirill
2017-10-05 20:52   ` [dpdk-dev] [PATCH v3 0/4] " Kirill Rybalchenko
2017-10-05 20:52     ` [dpdk-dev] [PATCH v3 1/4] " Kirill Rybalchenko
2017-10-05 20:52     ` [dpdk-dev] [PATCH v3 2/4] net/i40e: " Kirill Rybalchenko
2017-10-05 20:52     ` [dpdk-dev] [PATCH v3 3/4] app/testpmd: add raw flow type to " Kirill Rybalchenko
2017-10-05 20:52     ` [dpdk-dev] [PATCH v3 4/4] doc: add description of raw flow type in flow director in testpmd Kirill Rybalchenko
2017-10-10 20:13     ` [dpdk-dev] [PATCH v4 0/4] add support for raw flow type for flow director Kirill Rybalchenko
2017-10-10 20:13       ` [dpdk-dev] [PATCH v4 1/4] ethdev: " Kirill Rybalchenko
2017-10-10 20:13       ` [dpdk-dev] [PATCH v4 2/4] net/i40e: " Kirill Rybalchenko
2017-10-10 20:13       ` [dpdk-dev] [PATCH v4 3/4] app/testpmd: add raw flow type to " Kirill Rybalchenko
2017-10-10 20:13       ` [dpdk-dev] [PATCH v4 4/4] doc: add description of raw mode in flow director in testpmd Kirill Rybalchenko
2017-10-10 20:28       ` [dpdk-dev] [PATCH v5 0/4] add support for raw flow type for flow director Kirill Rybalchenko
2017-10-10 20:28         ` [dpdk-dev] [PATCH v5 1/4] ethdev: " Kirill Rybalchenko
2017-10-11 22:26           ` Thomas Monjalon
2017-10-12 11:41             ` Rybalchenko, Kirill
2017-10-12 12:01               ` Thomas Monjalon
2017-10-12 16:14               ` Adrien Mazarguil
2017-10-10 20:28         ` [dpdk-dev] [PATCH v5 2/4] net/i40e: " Kirill Rybalchenko
2017-10-10 20:28         ` [dpdk-dev] [PATCH v5 3/4] app/testpmd: add raw flow type to " Kirill Rybalchenko
2017-10-13  3:27           ` Wu, Jingjing
2017-10-10 20:28         ` [dpdk-dev] [PATCH v5 4/4] doc: add description of raw mode in flow director in testpmd Kirill Rybalchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7117136.lgPSGqLcVY@xps \
    --to=thomas@monjalon.net \
    --cc=andrey.chilikin@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=jingjing.wu@intel.com \
    --cc=kirill.rybalchenko@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).