From: "lihuisong (C)" <lihuisong@huawei.com>
To: Jie Hai <haijie1@huawei.com>, <honnappa.nagarahalli@arm.com>,
<konstantin.v.ananyev@yandex.ru>, <dev@dpdk.org>,
<thomas@monjalon.net>, <david.marchand@redhat.com>,
<Ruifeng.Wang@arm.com>, <mb@smartsharesystems.com>
Cc: <fengchengwen@huawei.com>, <liudongdong3@huawei.com>
Subject: Re: [RESEND v7 1/3] ring: fix unmatched type definition and usage
Date: Thu, 9 Nov 2023 20:26:18 +0800 [thread overview]
Message-ID: <71243145-ec23-feea-5a32-d514a3dce60e@huawei.com> (raw)
In-Reply-To: <20231109102046.1277893-2-haijie1@huawei.com>
Acked-by: Huisong Li <lihuisong@huawei.com>
在 2023/11/9 18:20, Jie Hai 写道:
> Field 'flags' of struct rte_ring is defined as int type. However,
> it is used as unsigned int. To ensure consistency, change the
> type of flags to unsigned int. Since these two types has the
> same byte size, this change is not an ABI change.
>
> Fixes: af75078fece3 ("first public release")
>
> Signed-off-by: Jie Hai <haijie1@huawei.com>
> Acked-by: Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>
> Acked-by: Chengwen Feng <fengchengwen@huawei.com>
> Acked-by: Morten Brørup <mb@smartsharesystems.com>
> ---
> lib/ring/rte_ring_core.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/ring/rte_ring_core.h b/lib/ring/rte_ring_core.h
> index b7708730658a..14dac6495d83 100644
> --- a/lib/ring/rte_ring_core.h
> +++ b/lib/ring/rte_ring_core.h
> @@ -119,7 +119,7 @@ struct rte_ring_hts_headtail {
> struct rte_ring {
> char name[RTE_RING_NAMESIZE] __rte_cache_aligned;
> /**< Name of the ring. */
> - int flags; /**< Flags supplied at creation. */
> + uint32_t flags; /**< Flags supplied at creation. */
> const struct rte_memzone *memzone;
> /**< Memzone, if any, containing the rte_ring */
> uint32_t size; /**< Size of ring. */
next prev parent reply other threads:[~2023-11-09 12:26 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 9:10 [PATCH 0/2] add ring telemetry cmds Jie Hai
2023-01-17 9:10 ` [PATCH 1/2] ring: add ring list telemetry cmd Jie Hai
2023-01-17 9:10 ` [PATCH 2/2] ring: add ring info " Jie Hai
2023-01-17 13:03 ` [PATCH v2 0/2] add ring telemetry cmds Jie Hai
2023-01-17 13:03 ` [PATCH v2 1/2] ring: add ring list telemetry cmd Jie Hai
2023-01-22 16:40 ` Konstantin Ananyev
2023-01-31 3:09 ` Jie Hai
2023-01-17 13:03 ` [PATCH v2 2/2] ring: add ring info " Jie Hai
2023-01-22 17:49 ` Konstantin Ananyev
2023-01-31 3:11 ` Jie Hai
2023-01-31 2:28 ` [PATCH v3 0/2] add ring telemetry cmds Jie Hai
2023-01-31 2:28 ` [PATCH v3 1/2] ring: add ring list telemetry cmd Jie Hai
2023-01-31 16:44 ` Honnappa Nagarahalli
2023-02-03 7:20 ` Jie Hai
2023-01-31 2:28 ` [PATCH v3 2/2] ring: add ring info " Jie Hai
2023-01-31 16:44 ` Honnappa Nagarahalli
2023-02-03 7:04 ` Jie Hai
2023-02-02 13:07 ` Konstantin Ananyev
2023-02-03 7:28 ` Jie Hai
2023-02-10 2:48 ` [PATCH v4 0/3] add telemetry cmds for ring Jie Hai
2023-02-10 2:48 ` [PATCH v4 1/3] ring: fix unmatched type definition and usage Jie Hai
2023-02-10 2:48 ` [PATCH v4 2/3] ring: add telemetry cmd to list rings Jie Hai
2023-02-16 6:56 ` lihuisong (C)
2023-02-10 2:48 ` [PATCH v4 3/3] ring: add telemetry cmd for ring info Jie Hai
2023-02-14 23:13 ` Konstantin Ananyev
2023-02-16 6:54 ` lihuisong (C)
2023-02-20 12:55 ` David Marchand
2023-06-20 8:14 ` Jie Hai
2023-06-20 14:34 ` Thomas Monjalon
2023-07-04 8:04 ` Jie Hai
2023-07-04 14:11 ` Thomas Monjalon
2023-07-06 8:52 ` David Marchand
2023-07-07 2:18 ` Jie Hai
2023-02-15 3:04 ` [PATCH v4 0/3] add telemetry cmds for ring fengchengwen
2023-05-09 1:29 ` [PATCH v5 " Jie Hai
2023-05-09 1:29 ` [PATCH v5 1/3] ring: fix unmatched type definition and usage Jie Hai
2023-05-09 6:23 ` Ruifeng Wang
2023-05-09 8:15 ` Jie Hai
2023-05-09 1:29 ` [PATCH v5 2/3] ring: add telemetry cmd to list rings Jie Hai
2023-05-09 1:29 ` [PATCH v5 3/3] ring: add telemetry cmd for ring info Jie Hai
2023-05-09 6:50 ` Morten Brørup
2023-05-09 9:24 ` [PATCH v6 0/3] add telemetry cmds for ring Jie Hai
2023-05-09 9:24 ` [PATCH v6 1/3] ring: fix unmatched type definition and usage Jie Hai
2023-05-09 9:24 ` [PATCH v6 2/3] ring: add telemetry cmd to list rings Jie Hai
2023-05-09 9:24 ` [PATCH v6 3/3] ring: add telemetry cmd for ring info Jie Hai
2023-05-30 9:27 ` [PATCH v6 0/3] add telemetry cmds for ring Jie Hai
2023-06-12 14:54 ` Thomas Monjalon
2023-10-28 9:48 ` Jie Hai
2023-07-04 9:04 ` [PATCH v7 " Jie Hai
2023-07-04 9:04 ` [PATCH v7 1/3] ring: fix unmatched type definition and usage Jie Hai
2023-07-04 9:04 ` [PATCH v7 2/3] ring: add telemetry cmd to list rings Jie Hai
2023-07-04 9:04 ` [PATCH v7 3/3] ring: add telemetry cmd for ring info Jie Hai
2023-08-18 6:53 ` [PATCH v7 0/3] add telemetry cmds for ring Jie Hai
2023-09-12 1:52 ` Jie Hai
2023-10-10 2:25 ` Jie Hai
2023-10-25 1:22 ` Jie Hai
2023-10-28 9:50 ` Jie Hai
2023-11-08 2:55 ` lihuisong (C)
2023-11-09 10:20 ` [RESEND " Jie Hai
2023-11-09 10:20 ` [RESEND v7 1/3] ring: fix unmatched type definition and usage Jie Hai
2023-11-09 12:26 ` lihuisong (C) [this message]
2024-02-18 18:11 ` Thomas Monjalon
2024-02-19 8:24 ` Jie Hai
2023-11-09 10:20 ` [RESEND v7 2/3] ring: add telemetry cmd to list rings Jie Hai
2023-11-09 12:26 ` lihuisong (C)
2023-11-09 10:20 ` [RESEND v7 3/3] ring: add telemetry cmd for ring info Jie Hai
2023-11-09 12:27 ` lihuisong (C)
2024-01-27 8:33 ` [RESEND v7 0/3] add telemetry cmds for ring Jie Hai
2024-02-19 8:32 ` [PATCH v8 0/2] " Jie Hai
2024-02-19 8:32 ` [PATCH v8 1/2] ring: add telemetry cmd to list rings Jie Hai
2024-02-19 8:32 ` [PATCH v8 2/2] ring: add telemetry cmd for ring info Jie Hai
2024-02-19 10:09 ` [PATCH v8 0/2] add telemetry cmds for ring Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71243145-ec23-feea-5a32-d514a3dce60e@huawei.com \
--to=lihuisong@huawei.com \
--cc=Ruifeng.Wang@arm.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=haijie1@huawei.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=liudongdong3@huawei.com \
--cc=mb@smartsharesystems.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).