From: Thomas Monjalon <thomas@monjalon.net>
To: Herbert Guan <Herbert.Guan@arm.com>
Cc: dev@dpdk.org, jianbo.liu@linaro.org,
jerin.jacob@caviumnetworks.com, nelio.laranjeiro@6wind.com
Subject: Re: [dpdk-dev] [PATCH v2] eal/armv8: fix poly64/128 compile issue in old GCC(<4.9.0)
Date: Wed, 19 Jul 2017 15:31:11 +0300 [thread overview]
Message-ID: <7214394.Gg28SKYvWX@xps> (raw)
In-Reply-To: <HE1PR08MB280983F651AE1C484F6D81B186A60@HE1PR08MB2809.eurprd08.prod.outlook.com>
19/07/2017 11:21, Herbert Guan:
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > 13/07/2017 05:16, Herbert Guan:
> > > --- a/lib/librte_eal/common/include/arch/arm/rte_vect.h
> > > +++ b/lib/librte_eal/common/include/arch/arm/rte_vect.h
> > > +#if (GCC_VERSION < 40900)
> > > +typedef uint64_t poly64_t;
> > > +typedef uint64x2_t poly64x2_t;
> > > +typedef uint8_t poly128_t __attribute__((vector_size(16),
> > > aligned(16)));
> > > +#endif
> >
> > I think a better fix would be to switch to DPDK types
> > like rte_v128u8_t.
>
> Thanks a lot for your review and comment.
> But I have some concern in this approach. "poly128_t" is for
> ARM64 platform only and in fact it's more likely that rte_v128u8_t
> (generic DPDK data type) could be defined from poly128_t
> (ARM data type) which seems more reasonable.
How poly128_t is different from rte_v128u8_t?
You are defining poly128_t as (vector_size(16),aligned(16))
and rte_v128u8_t is exactly that.
Is it interpreted differently with newer compilers?
In that case, you could at least fallback on rte_v128u8_t.
next prev parent reply other threads:[~2017-07-19 12:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-12 10:50 [dpdk-dev] [PATCH] ARMv8: Use built-in data types for unsupported poly64/128 types for GCC version lower than 4.9.0 Herbert Guan
2017-07-12 15:36 ` Jianbo Liu
2017-07-12 17:45 ` Jerin Jacob
2017-07-13 3:13 ` Herbert Guan
2017-07-13 2:16 ` [dpdk-dev] [PATCH v2] eal/armv8: fix poly64/128 compile issue in old GCC(<4.9.0) Herbert Guan
2017-07-18 14:44 ` Thomas Monjalon
2017-07-19 8:21 ` Herbert Guan
2017-07-19 12:31 ` Thomas Monjalon [this message]
2017-07-24 10:25 ` Herbert Guan
2017-07-31 7:24 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7214394.Gg28SKYvWX@xps \
--to=thomas@monjalon.net \
--cc=Herbert.Guan@arm.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=jianbo.liu@linaro.org \
--cc=nelio.laranjeiro@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).