From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Oleksandr Kolomeiets <okl-plv@napatech.com>,
thomas@monjalon.net, aman.deep.singh@intel.com,
yuying.zhang@intel.com, orika@nvidia.com, mko-plv@napatech.com,
ckm@napatech.com
Cc: dev@dpdk.org
Subject: Re: [PATCH v4] app/testpmd: support updating flow rule actions
Date: Wed, 28 Feb 2024 17:33:02 +0000 [thread overview]
Message-ID: <728edc78-4fa1-4bb2-8e9f-f2feba6d0dc0@amd.com> (raw)
In-Reply-To: <20240223041919.131526-1-okl-plv@napatech.com>
On 2/23/2024 4:19 AM, Oleksandr Kolomeiets wrote:
> "flow update" updates a flow rule specified by a rule ID with a
> new action list by making a call to "rte_flow_actions_update()":
>
> flow update {port_id} {rule_id}
> actions {action} [/ {action} [...]] / end [user_id]
>
> Creating, updating and destroying a flow rule:
>
> testpmd> flow create 0 group 1 pattern eth / end actions drop / end
> Flow rule #0 created
> testpmd> flow update 0 0 actions queue index 1 / end
> Flow rule #0 updated with new actions
> testpmd> flow destroy 0 rule 0
> Flow rule #0 destroyed
>
> Signed-off-by: Oleksandr Kolomeiets <okl-plv@napatech.com>
> Reviewed-by: Mykola Kostenok <mko-plv@napatech.com>
> Reviewed-by: Christian Koue Muf <ckm@napatech.com>
>
Patch looks good to me.
@Ori, @Thomas, do you have any comment, if not I will proceed with the
patch?
next prev parent reply other threads:[~2024-02-28 17:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-26 13:21 [PATCH] " Oleksandr Kolomeiets
2024-02-01 9:59 ` [PATCH v2] " Oleksandr Kolomeiets
2024-02-02 9:55 ` Thomas Monjalon
2024-02-05 19:18 ` Dariusz Sosnowski
2024-02-12 8:37 ` Oleksandr Kolomeiets
2024-02-21 10:32 ` Thomas Monjalon
2024-02-22 9:04 ` [PATCH v3] " Oleksandr Kolomeiets
2024-02-23 4:19 ` [PATCH v4] " Oleksandr Kolomeiets
2024-02-28 17:33 ` Ferruh Yigit [this message]
2024-02-29 2:15 ` [PATCH v5] " Oleksandr Kolomeiets
2024-02-29 14:48 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=728edc78-4fa1-4bb2-8e9f-f2feba6d0dc0@amd.com \
--to=ferruh.yigit@amd.com \
--cc=aman.deep.singh@intel.com \
--cc=ckm@napatech.com \
--cc=dev@dpdk.org \
--cc=mko-plv@napatech.com \
--cc=okl-plv@napatech.com \
--cc=orika@nvidia.com \
--cc=thomas@monjalon.net \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).